Skip to content

[Python] Fix __int__ typo and join_fn type hints in Milvus search handler #40475

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Abacn merged 1 commit into from
Oct 9, 2026
+1 −5
Merged

[Python] Fix __int__ typo and join_fn type hints in Milvus search handler #40475

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions sdks/python/apache_beam/ml/rag/enrichment/milvus_search.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,6 @@
from pymilvus.exceptions import MilvusException

from apache_beam.ml.rag.types import EmbeddableItem
from apache_beam.ml.rag.types import Embedding
from apache_beam.ml.rag.utils import MilvusConnectionParameters
from apache_beam.ml.rag.utils import MilvusHelpers
from apache_beam.ml.rag.utils import retry_with_backoff
Expand Down Expand Up @@ -96,9 +95,6 @@ class VectorSearchMetrics(Enum):

class MilvusBaseRanker:
"""Base class for ranking algorithms in Milvus hybrid search strategy."""
def __int__(self):
return

def dict(self):
return {}

Expand Down Expand Up @@ -588,6 +584,6 @@ def batch_elements_kwargs(self) -> dict[str, int]:
return self._batching_kwargs


def join_fn(left: Embedding, right: dict[str, Any]) -> Embedding:
def join_fn(left: EmbeddableItem, right: dict[str, Any]) -> EmbeddableItem:
left.metadata['enrichment_data'] = right
return left
Loading