Refactor: extract shared table-model PlanNode and Operator code from datanode#17526
Open
Refactor: extract shared table-model PlanNode and Operator code from datanode#17526
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
This PR modularizes table-model planning/execution by extracting shared PlanNode and Operator-related code from datanode into common modules (node-commons and calc-commons), updating package names and dependencies accordingly.
Changes:
- Moved/refactored table-model aggregation/operator/window/rowpattern implementations into
calc-commonswith updated packages/imports. - Updated callers (CLI, REST, integration tests) to reference relocated common utilities/types.
- Adjusted operator context abstractions (
OperatorContext→CommonOperatorContext) and related wiring.
Reviewed changes
Copilot reviewed 294 out of 2180 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| iotdb-core/calc-commons/src/main/java/org/apache/iotdb/calc/execution/operator/source/relational/aggregation/grouped/array/HyperLogLogBigArray.java | Package/import migration to calc-commons |
| iotdb-core/calc-commons/src/main/java/org/apache/iotdb/calc/execution/operator/source/relational/aggregation/grouped/array/FloatBigArray.java | Package/import migration to calc-commons |
| iotdb-core/calc-commons/src/main/java/org/apache/iotdb/calc/execution/operator/source/relational/aggregation/grouped/array/DoubleBigArray.java | Package/import migration to calc-commons |
| iotdb-core/calc-commons/src/main/java/org/apache/iotdb/calc/execution/operator/source/relational/aggregation/grouped/array/ByteBigArray.java | Package/import migration to calc-commons |
| iotdb-core/calc-commons/src/main/java/org/apache/iotdb/calc/execution/operator/source/relational/aggregation/grouped/array/BooleanBigArray.java | Package/import migration to calc-commons |
| iotdb-core/calc-commons/src/main/java/org/apache/iotdb/calc/execution/operator/source/relational/aggregation/grouped/array/BinaryBigArray.java | Package migration to calc-commons |
| iotdb-core/calc-commons/src/main/java/org/apache/iotdb/calc/execution/operator/source/relational/aggregation/grouped/array/BigArrays.java | Package migration to calc-commons |
| iotdb-core/calc-commons/src/main/java/org/apache/iotdb/calc/execution/operator/source/relational/aggregation/grouped/LongGroupedApproxMostFrequentAccumulator.java | Package/import migration + SemanticException moved to commons |
| iotdb-core/calc-commons/src/main/java/org/apache/iotdb/calc/execution/operator/source/relational/aggregation/grouped/IntGroupedApproxMostFrequentAccumulator.java | Package/import migration + SemanticException moved to commons |
| iotdb-core/calc-commons/src/main/java/org/apache/iotdb/calc/execution/operator/source/relational/aggregation/grouped/GroupedVarianceAccumulator.java | Package/import migration to calc-commons |
| iotdb-core/calc-commons/src/main/java/org/apache/iotdb/calc/execution/operator/source/relational/aggregation/grouped/GroupedUserDefinedAggregateAccumulator.java | Package/import migration to calc-commons |
| iotdb-core/calc-commons/src/main/java/org/apache/iotdb/calc/execution/operator/source/relational/aggregation/grouped/GroupedSumAccumulator.java | Package/import migration to calc-commons |
| iotdb-core/calc-commons/src/main/java/org/apache/iotdb/calc/execution/operator/source/relational/aggregation/grouped/GroupedMinByAccumulator.java | Package migration to calc-commons |
| iotdb-core/calc-commons/src/main/java/org/apache/iotdb/calc/execution/operator/source/relational/aggregation/grouped/GroupedMinAccumulator.java | Package/import migration to calc-commons |
| iotdb-core/calc-commons/src/main/java/org/apache/iotdb/calc/execution/operator/source/relational/aggregation/grouped/GroupedMaxMinByBaseAccumulator.java | Package/import migration to calc-commons |
| iotdb-core/calc-commons/src/main/java/org/apache/iotdb/calc/execution/operator/source/relational/aggregation/grouped/GroupedMaxByAccumulator.java | Package migration to calc-commons |
| iotdb-core/calc-commons/src/main/java/org/apache/iotdb/calc/execution/operator/source/relational/aggregation/grouped/GroupedMaxAccumulator.java | Package/import migration to calc-commons |
| iotdb-core/calc-commons/src/main/java/org/apache/iotdb/calc/execution/operator/source/relational/aggregation/grouped/GroupedLastByAccumulator.java | Package/import migration to calc-commons |
| iotdb-core/calc-commons/src/main/java/org/apache/iotdb/calc/execution/operator/source/relational/aggregation/grouped/GroupedLastAccumulator.java | Package/import migration to calc-commons |
| iotdb-core/calc-commons/src/main/java/org/apache/iotdb/calc/execution/operator/source/relational/aggregation/grouped/GroupedFirstByAccumulator.java | Package/import migration to calc-commons |
| iotdb-core/calc-commons/src/main/java/org/apache/iotdb/calc/execution/operator/source/relational/aggregation/grouped/GroupedFirstAccumulator.java | Package/import migration to calc-commons |
| iotdb-core/calc-commons/src/main/java/org/apache/iotdb/calc/execution/operator/source/relational/aggregation/grouped/GroupedExtremeAccumulator.java | Package/import migration to calc-commons |
| iotdb-core/calc-commons/src/main/java/org/apache/iotdb/calc/execution/operator/source/relational/aggregation/grouped/GroupedCountIfAccumulator.java | Package/import migration to calc-commons |
| iotdb-core/calc-commons/src/main/java/org/apache/iotdb/calc/execution/operator/source/relational/aggregation/grouped/GroupedCountAllAccumulator.java | Package/import migration to calc-commons |
| iotdb-core/calc-commons/src/main/java/org/apache/iotdb/calc/execution/operator/source/relational/aggregation/grouped/GroupedCountAccumulator.java | Package/import migration to calc-commons |
| iotdb-core/calc-commons/src/main/java/org/apache/iotdb/calc/execution/operator/source/relational/aggregation/grouped/GroupedAvgAccumulator.java | Package/import migration to calc-commons |
| iotdb-core/calc-commons/src/main/java/org/apache/iotdb/calc/execution/operator/source/relational/aggregation/grouped/GroupedApproxPercentileWithWeightAccumulator.java | Package/import migration + SemanticException moved to commons |
| iotdb-core/calc-commons/src/main/java/org/apache/iotdb/calc/execution/operator/source/relational/aggregation/grouped/GroupedApproxPercentileAccumulator.java | Package/import migration to calc-commons |
| iotdb-core/calc-commons/src/main/java/org/apache/iotdb/calc/execution/operator/source/relational/aggregation/grouped/GroupedApproxCountDistinctAccumulator.java | Package/import migration + DEFAULT_STANDARD_ERROR import updated |
| iotdb-core/calc-commons/src/main/java/org/apache/iotdb/calc/execution/operator/source/relational/aggregation/grouped/GroupedAggregator.java | Updated time column template source to CommonOperatorUtils |
| iotdb-core/calc-commons/src/main/java/org/apache/iotdb/calc/execution/operator/source/relational/aggregation/grouped/GroupedAccumulator.java | Package/import migration to calc-commons |
| iotdb-core/calc-commons/src/main/java/org/apache/iotdb/calc/execution/operator/source/relational/aggregation/grouped/FloatGroupedApproxMostFrequentAccumulator.java | Package/import migration + SemanticException moved to commons |
| iotdb-core/calc-commons/src/main/java/org/apache/iotdb/calc/execution/operator/source/relational/aggregation/grouped/DoubleGroupedApproxMostFrequentAccumulator.java | Package/import migration + SemanticException moved to commons |
| iotdb-core/calc-commons/src/main/java/org/apache/iotdb/calc/execution/operator/source/relational/aggregation/grouped/BooleanGroupedApproxMostFrequentAccumulator.java | Package/import migration + SemanticException moved to commons |
| iotdb-core/calc-commons/src/main/java/org/apache/iotdb/calc/execution/operator/source/relational/aggregation/grouped/BlobGroupedApproxMostFrequentAccumulator.java | Package migration to calc-commons |
| iotdb-core/calc-commons/src/main/java/org/apache/iotdb/calc/execution/operator/source/relational/aggregation/grouped/BinaryGroupedApproxMostFrequentAccumulator.java | Package/import migration + SemanticException moved to commons |
| iotdb-core/calc-commons/src/main/java/org/apache/iotdb/calc/execution/operator/source/relational/aggregation/grouped/AbstractGroupedApproxPercentileAccumulator.java | Package/import migration to calc-commons |
| iotdb-core/calc-commons/src/main/java/org/apache/iotdb/calc/execution/operator/source/relational/aggregation/grouped/AbstractGroupedApproxMostFrequentAccumulator.java | Package/import migration to calc-commons |
| iotdb-core/calc-commons/src/main/java/org/apache/iotdb/calc/execution/operator/source/relational/aggregation/approximate/TDigest.java | Package migration + SemanticException moved to commons |
| iotdb-core/calc-commons/src/main/java/org/apache/iotdb/calc/execution/operator/source/relational/aggregation/approximate/StreamSummary.java | Package migration to calc-commons |
| iotdb-core/calc-commons/src/main/java/org/apache/iotdb/calc/execution/operator/source/relational/aggregation/approximate/SpaceSavingStateFactory.java | Package/import migration + static import updated |
| iotdb-core/calc-commons/src/main/java/org/apache/iotdb/calc/execution/operator/source/relational/aggregation/approximate/SpaceSavingByteCalculator.java | Package migration to calc-commons |
| iotdb-core/calc-commons/src/main/java/org/apache/iotdb/calc/execution/operator/source/relational/aggregation/approximate/SpaceSaving.java | Package migration to calc-commons |
| iotdb-core/calc-commons/src/main/java/org/apache/iotdb/calc/execution/operator/source/relational/aggregation/approximate/Pair.java | Package migration to calc-commons |
| iotdb-core/calc-commons/src/main/java/org/apache/iotdb/calc/execution/operator/source/relational/aggregation/approximate/ListNode2.java | Package migration to calc-commons |
| iotdb-core/calc-commons/src/main/java/org/apache/iotdb/calc/execution/operator/source/relational/aggregation/approximate/ITopK.java | Package migration to calc-commons |
| iotdb-core/calc-commons/src/main/java/org/apache/iotdb/calc/execution/operator/source/relational/aggregation/approximate/HyperLogLogStateFactory.java | Package/import migration to calc-commons |
| iotdb-core/calc-commons/src/main/java/org/apache/iotdb/calc/execution/operator/source/relational/aggregation/approximate/HyperLogLog.java | Package migration to calc-commons |
| iotdb-core/calc-commons/src/main/java/org/apache/iotdb/calc/execution/operator/source/relational/aggregation/approximate/ExternalizableUtil.java | Package migration to calc-commons |
| iotdb-core/calc-commons/src/main/java/org/apache/iotdb/calc/execution/operator/source/relational/aggregation/approximate/DoublyLinkedList.java | Package migration to calc-commons |
| iotdb-core/calc-commons/src/main/java/org/apache/iotdb/calc/execution/operator/source/relational/aggregation/approximate/Counter.java | Package migration to calc-commons |
| iotdb-core/calc-commons/src/main/java/org/apache/iotdb/calc/execution/operator/source/relational/aggregation/approximate/ApproxMostFrequentBucketSerializer.java | Package migration to calc-commons |
| iotdb-core/calc-commons/src/main/java/org/apache/iotdb/calc/execution/operator/source/relational/aggregation/approximate/ApproxMostFrequentBucketDeserializer.java | Package migration to calc-commons |
| iotdb-core/calc-commons/src/main/java/org/apache/iotdb/calc/execution/operator/source/relational/aggregation/Utils.java | Package migration to calc-commons |
| iotdb-core/calc-commons/src/main/java/org/apache/iotdb/calc/execution/operator/source/relational/aggregation/UserDefinedAggregateFunctionAccumulator.java | Package migration to calc-commons |
| iotdb-core/calc-commons/src/main/java/org/apache/iotdb/calc/execution/operator/source/relational/aggregation/TableVarianceAccumulator.java | Package migration + VarianceAccumulator moved to calc |
| iotdb-core/calc-commons/src/main/java/org/apache/iotdb/calc/execution/operator/source/relational/aggregation/TableModeAccumulator.java | Config dependency switched to CommonDescriptor |
| iotdb-core/calc-commons/src/main/java/org/apache/iotdb/calc/execution/operator/source/relational/aggregation/TableMinByAccumulator.java | Package migration to calc-commons |
| iotdb-core/calc-commons/src/main/java/org/apache/iotdb/calc/execution/operator/source/relational/aggregation/TableMaxMinByBaseAccumulator.java | Package migration + Utils static imports updated |
| iotdb-core/calc-commons/src/main/java/org/apache/iotdb/calc/execution/operator/source/relational/aggregation/TableMaxByAccumulator.java | Package migration to calc-commons |
| iotdb-core/calc-commons/src/main/java/org/apache/iotdb/calc/execution/operator/source/relational/aggregation/TableAggregator.java | Metrics wiring moved + time column template source updated |
| iotdb-core/calc-commons/src/main/java/org/apache/iotdb/calc/execution/operator/source/relational/aggregation/TableAccumulator.java | Package migration to calc-commons |
| iotdb-core/calc-commons/src/main/java/org/apache/iotdb/calc/execution/operator/source/relational/aggregation/SumAccumulator.java | Package migration to calc-commons |
| iotdb-core/calc-commons/src/main/java/org/apache/iotdb/calc/execution/operator/source/relational/aggregation/RecordIterator.java | ObjectTypeUtils dependency moved to calc |
| iotdb-core/calc-commons/src/main/java/org/apache/iotdb/calc/execution/operator/source/relational/aggregation/MinAccumulator.java | Package migration to calc-commons |
| iotdb-core/calc-commons/src/main/java/org/apache/iotdb/calc/execution/operator/source/relational/aggregation/MaxAccumulator.java | Package migration to calc-commons |
| iotdb-core/calc-commons/src/main/java/org/apache/iotdb/calc/execution/operator/source/relational/aggregation/MaskedRecordIterator.java | Package migration to calc-commons |
| iotdb-core/calc-commons/src/main/java/org/apache/iotdb/calc/execution/operator/source/relational/aggregation/LongApproxMostFrequentAccumulator.java | Package migration + SemanticException moved to commons |
| iotdb-core/calc-commons/src/main/java/org/apache/iotdb/calc/execution/operator/source/relational/aggregation/LastDescAccumulator.java | Package migration to calc-commons |
| iotdb-core/calc-commons/src/main/java/org/apache/iotdb/calc/execution/operator/source/relational/aggregation/LastByDescAccumulator.java | Package migration to calc-commons |
| iotdb-core/calc-commons/src/main/java/org/apache/iotdb/calc/execution/operator/source/relational/aggregation/LastByAccumulator.java | Package migration + Utils static import updated |
| iotdb-core/calc-commons/src/main/java/org/apache/iotdb/calc/execution/operator/source/relational/aggregation/LastAccumulator.java | Package migration + Utils static import updated |
| iotdb-core/calc-commons/src/main/java/org/apache/iotdb/calc/execution/operator/source/relational/aggregation/IntApproxMostFrequentAccumulator.java | Package migration + SemanticException moved to commons |
| iotdb-core/calc-commons/src/main/java/org/apache/iotdb/calc/execution/operator/source/relational/aggregation/FloatApproxMostFrequentAccumulator.java | Package migration + SemanticException moved to commons |
| iotdb-core/calc-commons/src/main/java/org/apache/iotdb/calc/execution/operator/source/relational/aggregation/FirstDescAccumulator.java | Package migration to calc-commons |
| iotdb-core/calc-commons/src/main/java/org/apache/iotdb/calc/execution/operator/source/relational/aggregation/FirstByDescAccumulator.java | Package migration to calc-commons |
| iotdb-core/calc-commons/src/main/java/org/apache/iotdb/calc/execution/operator/source/relational/aggregation/FirstByAccumulator.java | Package migration + Utils static import updated |
| iotdb-core/calc-commons/src/main/java/org/apache/iotdb/calc/execution/operator/source/relational/aggregation/FirstAccumulator.java | Package migration + Utils static import updated |
| iotdb-core/calc-commons/src/main/java/org/apache/iotdb/calc/execution/operator/source/relational/aggregation/ExtremeAccumulator.java | Package migration to calc-commons |
| iotdb-core/calc-commons/src/main/java/org/apache/iotdb/calc/execution/operator/source/relational/aggregation/DoubleApproxMostFrequentAccumulator.java | Package migration + SemanticException moved to commons |
| iotdb-core/calc-commons/src/main/java/org/apache/iotdb/calc/execution/operator/source/relational/aggregation/CountIfAccumulator.java | Package migration to calc-commons |
| iotdb-core/calc-commons/src/main/java/org/apache/iotdb/calc/execution/operator/source/relational/aggregation/CountAllAccumulator.java | Package migration to calc-commons |
| iotdb-core/calc-commons/src/main/java/org/apache/iotdb/calc/execution/operator/source/relational/aggregation/CountAccumulator.java | Package migration to calc-commons |
| iotdb-core/calc-commons/src/main/java/org/apache/iotdb/calc/execution/operator/source/relational/aggregation/BooleanApproxMostFrequentAccumulator.java | Package migration + SemanticException moved to commons |
| iotdb-core/calc-commons/src/main/java/org/apache/iotdb/calc/execution/operator/source/relational/aggregation/BlobApproxMostFrequentAccumulator.java | Package migration to calc-commons |
| iotdb-core/calc-commons/src/main/java/org/apache/iotdb/calc/execution/operator/source/relational/aggregation/BinaryApproxMostFrequentAccumulator.java | Package migration + SemanticException moved to commons |
| iotdb-core/calc-commons/src/main/java/org/apache/iotdb/calc/execution/operator/source/relational/aggregation/AvgAccumulator.java | Package migration to calc-commons |
| iotdb-core/calc-commons/src/main/java/org/apache/iotdb/calc/execution/operator/source/relational/aggregation/ApproxPercentileWithWeightAccumulator.java | Package migration + SemanticException moved to commons |
| iotdb-core/calc-commons/src/main/java/org/apache/iotdb/calc/execution/operator/source/relational/aggregation/ApproxPercentileAccumulator.java | Package migration to calc-commons |
| iotdb-core/calc-commons/src/main/java/org/apache/iotdb/calc/execution/operator/source/relational/aggregation/ApproxCountDistinctAccumulator.java | Package migration + imports updated |
| iotdb-core/calc-commons/src/main/java/org/apache/iotdb/calc/execution/operator/source/relational/aggregation/AggregationMask.java | Package migration to calc-commons |
| iotdb-core/calc-commons/src/main/java/org/apache/iotdb/calc/execution/operator/source/relational/aggregation/AbstractApproxPercentileAccumulator.java | Package migration + SemanticException moved to commons |
| iotdb-core/calc-commons/src/main/java/org/apache/iotdb/calc/execution/operator/source/relational/aggregation/AbstractApproxMostFrequentAccumulator.java | Package migration to calc-commons |
| iotdb-core/calc-commons/src/main/java/org/apache/iotdb/calc/execution/operator/source/relational/MergeSortSemiJoinOperator.java | OperatorContext abstraction changed to CommonOperatorContext |
| iotdb-core/calc-commons/src/main/java/org/apache/iotdb/calc/execution/operator/source/relational/MergeSortLeftJoinOperator.java | OperatorContext abstraction changed to CommonOperatorContext |
| iotdb-core/calc-commons/src/main/java/org/apache/iotdb/calc/execution/operator/source/relational/MergeSortInnerJoinOperator.java | OperatorContext abstraction changed to CommonOperatorContext |
| iotdb-core/calc-commons/src/main/java/org/apache/iotdb/calc/execution/operator/source/relational/AsofMergeSortLeftJoinOperator.java | OperatorContext abstraction changed to CommonOperatorContext |
| iotdb-core/calc-commons/src/main/java/org/apache/iotdb/calc/execution/operator/source/relational/AsofMergeSortInnerJoinOperator.java | OperatorContext abstraction changed to CommonOperatorContext |
| iotdb-core/calc-commons/src/main/java/org/apache/iotdb/calc/execution/operator/source/relational/AbstractAsofMergeSortJoinOperator.java | OperatorContext abstraction changed to CommonOperatorContext |
| iotdb-core/calc-commons/src/main/java/org/apache/iotdb/calc/execution/operator/process/window/utils/RowComparator.java | Package migration to calc-commons |
| iotdb-core/calc-commons/src/main/java/org/apache/iotdb/calc/execution/operator/process/window/utils/Range.java | Package migration to calc-commons |
| iotdb-core/calc-commons/src/main/java/org/apache/iotdb/calc/execution/operator/process/window/utils/ColumnList.java | Package migration to calc-commons |
| iotdb-core/calc-commons/src/main/java/org/apache/iotdb/calc/execution/operator/process/window/partition/frame/RowsFrame.java | Package migration + SemanticException moved to commons |
| iotdb-core/calc-commons/src/main/java/org/apache/iotdb/calc/execution/operator/process/window/partition/frame/RangeFrame.java | Package migration + static imports adjusted |
| iotdb-core/calc-commons/src/main/java/org/apache/iotdb/calc/execution/operator/process/window/partition/frame/GroupsFrame.java | Package migration + SemanticException moved to commons |
| iotdb-core/calc-commons/src/main/java/org/apache/iotdb/calc/execution/operator/process/window/partition/frame/FrameInfo.java | Planner AST types moved to commons |
| iotdb-core/calc-commons/src/main/java/org/apache/iotdb/calc/execution/operator/process/window/partition/frame/Frame.java | Package/import migration to calc-commons |
| iotdb-core/calc-commons/src/main/java/org/apache/iotdb/calc/execution/operator/process/window/partition/PartitionExecutor.java | Package/import migration to calc-commons |
| iotdb-core/calc-commons/src/main/java/org/apache/iotdb/calc/execution/operator/process/window/partition/Partition.java | Slice/ColumnList references moved to calc |
| iotdb-core/calc-commons/src/main/java/org/apache/iotdb/calc/execution/operator/process/window/function/value/ValueWindowFunction.java | Package/import migration to calc-commons |
| iotdb-core/calc-commons/src/main/java/org/apache/iotdb/calc/execution/operator/process/window/function/value/NthValueFunction.java | Package/import migration to calc-commons |
| iotdb-core/calc-commons/src/main/java/org/apache/iotdb/calc/execution/operator/process/window/function/value/LeadFunction.java | Package/import migration to calc-commons |
| iotdb-core/calc-commons/src/main/java/org/apache/iotdb/calc/execution/operator/process/window/function/value/LastValueFunction.java | Package/import migration to calc-commons |
| iotdb-core/calc-commons/src/main/java/org/apache/iotdb/calc/execution/operator/process/window/function/value/LagFunction.java | Package/import migration to calc-commons |
| iotdb-core/calc-commons/src/main/java/org/apache/iotdb/calc/execution/operator/process/window/function/value/FirstValueFunction.java | Package/import migration to calc-commons |
| iotdb-core/calc-commons/src/main/java/org/apache/iotdb/calc/execution/operator/process/window/function/rank/RowNumberFunction.java | Package/import migration to calc-commons |
| iotdb-core/calc-commons/src/main/java/org/apache/iotdb/calc/execution/operator/process/window/function/rank/RankWindowFunction.java | Package/import migration to calc-commons |
| iotdb-core/calc-commons/src/main/java/org/apache/iotdb/calc/execution/operator/process/window/function/rank/RankFunction.java | Package/import migration to calc-commons |
| iotdb-core/calc-commons/src/main/java/org/apache/iotdb/calc/execution/operator/process/window/function/rank/PercentRankFunction.java | Package/import migration to calc-commons |
| iotdb-core/calc-commons/src/main/java/org/apache/iotdb/calc/execution/operator/process/window/function/rank/NTileFunction.java | Package/import migration to calc-commons |
| iotdb-core/calc-commons/src/main/java/org/apache/iotdb/calc/execution/operator/process/window/function/rank/DenseRankFunction.java | Package/import migration to calc-commons |
| iotdb-core/calc-commons/src/main/java/org/apache/iotdb/calc/execution/operator/process/window/function/rank/CumeDistFunction.java | Package/import migration to calc-commons |
| iotdb-core/calc-commons/src/main/java/org/apache/iotdb/calc/execution/operator/process/window/function/aggregate/AggregationWindowFunction.java | Package/import migration to calc-commons |
| iotdb-core/calc-commons/src/main/java/org/apache/iotdb/calc/execution/operator/process/window/function/WindowFunctionFactory.java | Package/import migration to calc-commons |
| iotdb-core/calc-commons/src/main/java/org/apache/iotdb/calc/execution/operator/process/window/function/WindowFunction.java | Package/import migration to calc-commons |
| iotdb-core/calc-commons/src/main/java/org/apache/iotdb/calc/execution/operator/process/rowpattern/matcher/Split.java | Package migration to calc-commons |
| iotdb-core/calc-commons/src/main/java/org/apache/iotdb/calc/execution/operator/process/rowpattern/matcher/Save.java | Package migration to calc-commons |
| iotdb-core/calc-commons/src/main/java/org/apache/iotdb/calc/execution/operator/process/rowpattern/matcher/Program.java | Package migration to calc-commons |
| iotdb-core/calc-commons/src/main/java/org/apache/iotdb/calc/execution/operator/process/rowpattern/matcher/PatternCaptures.java | Captures dependency moved to calc plan utils |
| iotdb-core/calc-commons/src/main/java/org/apache/iotdb/calc/execution/operator/process/rowpattern/matcher/Matcher.java | Package migration + static import updated |
| iotdb-core/calc-commons/src/main/java/org/apache/iotdb/calc/execution/operator/process/rowpattern/matcher/MatchStart.java | Package migration to calc-commons |
| iotdb-core/calc-commons/src/main/java/org/apache/iotdb/calc/execution/operator/process/rowpattern/matcher/MatchResult.java | Package migration to calc-commons |
| iotdb-core/calc-commons/src/main/java/org/apache/iotdb/calc/execution/operator/process/rowpattern/matcher/MatchLabel.java | Package migration to calc-commons |
| iotdb-core/calc-commons/src/main/java/org/apache/iotdb/calc/execution/operator/process/rowpattern/matcher/MatchEnd.java | Package migration to calc-commons |
| iotdb-core/calc-commons/src/main/java/org/apache/iotdb/calc/execution/operator/process/rowpattern/matcher/Jump.java | Package migration to calc-commons |
| iotdb-core/calc-commons/src/main/java/org/apache/iotdb/calc/execution/operator/process/rowpattern/matcher/IntStack.java | Package migration to calc-commons |
| iotdb-core/calc-commons/src/main/java/org/apache/iotdb/calc/execution/operator/process/rowpattern/matcher/IntMultimap.java | Package migration to calc-commons |
| iotdb-core/calc-commons/src/main/java/org/apache/iotdb/calc/execution/operator/process/rowpattern/matcher/IntList.java | Package migration to calc-commons |
| iotdb-core/calc-commons/src/main/java/org/apache/iotdb/calc/execution/operator/process/rowpattern/matcher/Instruction.java | Package migration to calc-commons |
| iotdb-core/calc-commons/src/main/java/org/apache/iotdb/calc/execution/operator/process/rowpattern/matcher/Done.java | Package migration to calc-commons |
| iotdb-core/calc-commons/src/main/java/org/apache/iotdb/calc/execution/operator/process/rowpattern/matcher/ArrayView.java | Package migration to calc-commons |
| iotdb-core/calc-commons/src/main/java/org/apache/iotdb/calc/execution/operator/process/rowpattern/expression/ReferenceComputation.java | Package migration to calc-commons |
| iotdb-core/calc-commons/src/main/java/org/apache/iotdb/calc/execution/operator/process/rowpattern/expression/PatternExpressionComputation.java | Package migration + SemanticException moved to commons |
| iotdb-core/calc-commons/src/main/java/org/apache/iotdb/calc/execution/operator/process/rowpattern/expression/NaryOperator.java | Package migration to calc-commons |
| iotdb-core/calc-commons/src/main/java/org/apache/iotdb/calc/execution/operator/process/rowpattern/expression/NaryComputation.java | Package migration to calc-commons |
| iotdb-core/calc-commons/src/main/java/org/apache/iotdb/calc/execution/operator/process/rowpattern/expression/LogicalOperator.java | Package migration + SemanticException moved to commons |
| iotdb-core/calc-commons/src/main/java/org/apache/iotdb/calc/execution/operator/process/rowpattern/expression/ConstantComputation.java | Package migration to calc-commons |
| iotdb-core/calc-commons/src/main/java/org/apache/iotdb/calc/execution/operator/process/rowpattern/expression/ComparisonOperator.java | Package migration + SemanticException moved to commons |
| iotdb-core/calc-commons/src/main/java/org/apache/iotdb/calc/execution/operator/process/rowpattern/expression/CastComputation.java | AST DataType moved to commons |
| iotdb-core/calc-commons/src/main/java/org/apache/iotdb/calc/execution/operator/process/rowpattern/expression/BinaryOperator.java | Package migration to calc-commons |
| iotdb-core/calc-commons/src/main/java/org/apache/iotdb/calc/execution/operator/process/rowpattern/expression/BinaryComputation.java | Package migration to calc-commons |
| iotdb-core/calc-commons/src/main/java/org/apache/iotdb/calc/execution/operator/process/rowpattern/expression/ArithmeticOperator.java | Package migration + SemanticException moved to commons |
| iotdb-core/calc-commons/src/main/java/org/apache/iotdb/calc/execution/operator/process/rowpattern/PhysicalValuePointer.java | Package migration to calc-commons |
| iotdb-core/calc-commons/src/main/java/org/apache/iotdb/calc/execution/operator/process/rowpattern/PhysicalValueAccessor.java | Package migration to calc-commons |
| iotdb-core/calc-commons/src/main/java/org/apache/iotdb/calc/execution/operator/process/rowpattern/PhysicalAggregationPointer.java | Package migration to calc-commons |
| iotdb-core/calc-commons/src/main/java/org/apache/iotdb/calc/execution/operator/process/rowpattern/PatternVariableRecognizer.java | Package migration to calc-commons |
| iotdb-core/calc-commons/src/main/java/org/apache/iotdb/calc/execution/operator/process/rowpattern/PatternPartitionExecutor.java | Package migration + planner node deps moved to commons |
| iotdb-core/calc-commons/src/main/java/org/apache/iotdb/calc/execution/operator/process/rowpattern/PatternAggregators.java | Package migration to calc-commons |
| iotdb-core/calc-commons/src/main/java/org/apache/iotdb/calc/execution/operator/process/rowpattern/PatternAggregator.java | TIME_COLUMN_TEMPLATE source moved to CommonOperatorUtils |
| iotdb-core/calc-commons/src/main/java/org/apache/iotdb/calc/execution/operator/process/rowpattern/PatternAggregationTracker.java | Package migration to calc-commons |
| iotdb-core/calc-commons/src/main/java/org/apache/iotdb/calc/execution/operator/process/rowpattern/LogicalIndexNavigation.java | Added constructor bridging commons rowpattern pointers |
| iotdb-core/calc-commons/src/main/java/org/apache/iotdb/calc/execution/operator/process/join/merge/comparator/JoinKeyComparatorFactory.java | Package migration to calc-commons |
| iotdb-core/calc-commons/src/main/java/org/apache/iotdb/calc/execution/operator/process/join/merge/comparator/JoinKeyComparator.java | Package migration to calc-commons |
| iotdb-core/calc-commons/src/main/java/org/apache/iotdb/calc/execution/operator/process/join/merge/comparator/DescLongTypeJoinKeyComparator.java | Package migration to calc-commons |
| iotdb-core/calc-commons/src/main/java/org/apache/iotdb/calc/execution/operator/process/join/merge/comparator/DescLongTypeIgnoreEqualJoinKeyComparator.java | Package migration to calc-commons |
| iotdb-core/calc-commons/src/main/java/org/apache/iotdb/calc/execution/operator/process/join/merge/comparator/DescIntTypeJoinKeyComparator.java | Package migration to calc-commons |
| iotdb-core/calc-commons/src/main/java/org/apache/iotdb/calc/execution/operator/process/join/merge/comparator/DescFloatTypeJoinKeyComparator.java | Package migration to calc-commons |
| iotdb-core/calc-commons/src/main/java/org/apache/iotdb/calc/execution/operator/process/join/merge/comparator/DescDoubleTypeJoinKeyComparator.java | Package migration to calc-commons |
| iotdb-core/calc-commons/src/main/java/org/apache/iotdb/calc/execution/operator/process/join/merge/comparator/DescBooleanTypeJoinKeyComparator.java | Package migration to calc-commons |
| iotdb-core/calc-commons/src/main/java/org/apache/iotdb/calc/execution/operator/process/join/merge/comparator/DescBinaryTypeJoinKeyComparator.java | Package migration to calc-commons |
| iotdb-core/calc-commons/src/main/java/org/apache/iotdb/calc/execution/operator/process/join/merge/comparator/AscLongTypeJoinKeyComparator.java | Package migration to calc-commons |
| iotdb-core/calc-commons/src/main/java/org/apache/iotdb/calc/execution/operator/process/join/merge/comparator/AscLongTypeIgnoreEqualJoinKeyComparator.java | Package migration to calc-commons |
| iotdb-core/calc-commons/src/main/java/org/apache/iotdb/calc/execution/operator/process/join/merge/comparator/AscIntTypeJoinKeyComparator.java | Package migration to calc-commons |
| iotdb-core/calc-commons/src/main/java/org/apache/iotdb/calc/execution/operator/process/join/merge/comparator/AscFloatTypeJoinKeyComparator.java | Package migration to calc-commons |
| iotdb-core/calc-commons/src/main/java/org/apache/iotdb/calc/execution/operator/process/join/merge/comparator/AscDoubleTypeJoinKeyComparator.java | Package migration to calc-commons |
| iotdb-core/calc-commons/src/main/java/org/apache/iotdb/calc/execution/operator/process/join/merge/comparator/AscBooleanTypeJoinKeyComparator.java | Package migration to calc-commons |
| iotdb-core/calc-commons/src/main/java/org/apache/iotdb/calc/execution/operator/process/join/merge/comparator/AscBinaryTypeJoinKeyComparator.java | Package migration to calc-commons |
| iotdb-core/calc-commons/src/main/java/org/apache/iotdb/calc/execution/operator/process/join/merge/SortKeyComparator.java | SortKey moved to calc utils |
| iotdb-core/calc-commons/src/main/java/org/apache/iotdb/calc/execution/operator/process/gapfill/GapFillWoGroupWoMoOperator.java | OperatorContext abstraction changed + nextDateBin import moved |
| iotdb-core/calc-commons/src/main/java/org/apache/iotdb/calc/execution/operator/process/gapfill/GapFillWoGroupWMoOperator.java | OperatorContext abstraction changed + nextDateBin import moved |
| iotdb-core/calc-commons/src/main/java/org/apache/iotdb/calc/execution/operator/process/gapfill/GapFillWGroupWoMoOperator.java | OperatorContext abstraction changed + SortKey moved |
| iotdb-core/calc-commons/src/main/java/org/apache/iotdb/calc/execution/operator/process/gapfill/GapFillWGroupWMoOperator.java | OperatorContext abstraction changed + SortKey moved |
| iotdb-core/calc-commons/src/main/java/org/apache/iotdb/calc/execution/operator/process/gapfill/AbstractGapFillWoGroupOperator.java | OperatorContext abstraction changed + SortKey moved |
| iotdb-core/calc-commons/src/main/java/org/apache/iotdb/calc/execution/operator/process/gapfill/AbstractGapFillWGroupOperator.java | OperatorContext abstraction changed + SortKey moved |
| iotdb-core/calc-commons/src/main/java/org/apache/iotdb/calc/execution/operator/process/function/partition/Slice.java | ObjectTypeUtils + RecordIterator constant moved |
| iotdb-core/calc-commons/src/main/java/org/apache/iotdb/calc/execution/operator/process/function/partition/PartitionState.java | Package migration to calc-commons |
| iotdb-core/calc-commons/src/main/java/org/apache/iotdb/calc/execution/operator/process/function/partition/PartitionCache.java | Package migration to calc-commons |
| iotdb-core/calc-commons/src/main/java/org/apache/iotdb/calc/execution/operator/process/function/PartitionRecognizer.java | SortOrder import moved to commons + calc package refs |
| iotdb-core/calc-commons/src/main/java/org/apache/iotdb/calc/execution/operator/process/fill/linear/LinearFill.java | Package migration to calc-commons |
| iotdb-core/calc-commons/src/main/java/org/apache/iotdb/calc/execution/operator/process/fill/identity/IdentityLinearFill.java | Package migration to calc-commons |
| iotdb-core/calc-commons/src/main/java/org/apache/iotdb/calc/execution/operator/process/fill/identity/IdentityFill.java | Package migration to calc-commons |
| iotdb-core/calc-commons/src/main/java/org/apache/iotdb/calc/execution/operator/process/fill/filter/MonthIntervalUSFillFilter.java | Package migration to calc-commons |
| iotdb-core/calc-commons/src/main/java/org/apache/iotdb/calc/execution/operator/process/fill/filter/MonthIntervalNSFillFilter.java | Package migration to calc-commons |
| iotdb-core/calc-commons/src/main/java/org/apache/iotdb/calc/execution/operator/process/fill/filter/MonthIntervalMSFillFilter.java | Package migration to calc-commons |
| iotdb-core/calc-commons/src/main/java/org/apache/iotdb/calc/execution/operator/process/fill/filter/FixedIntervalFillFilter.java | Interface import moved to calc fill package |
| iotdb-core/calc-commons/src/main/java/org/apache/iotdb/calc/execution/operator/process/fill/filter/AbstractMonthIntervalFillFilter.java | Interface import moved to calc fill package |
| iotdb-core/calc-commons/src/main/java/org/apache/iotdb/calc/execution/operator/process/fill/ILinearFill.java | Package migration to calc-commons |
| iotdb-core/calc-commons/src/main/java/org/apache/iotdb/calc/execution/operator/process/fill/IFillFilter.java | Package migration to calc-commons |
| iotdb-core/calc-commons/src/main/java/org/apache/iotdb/calc/execution/operator/process/fill/IFill.java | Package migration to calc-commons |
| iotdb-core/calc-commons/src/main/java/org/apache/iotdb/calc/execution/operator/process/ValuesOperator.java | OperatorContext abstraction changed to CommonOperatorContext |
| iotdb-core/calc-commons/src/main/java/org/apache/iotdb/calc/execution/operator/process/TableTopKOperator.java | TIME_COLUMN_TEMPLATE source moved to CommonOperatorUtils |
| iotdb-core/calc-commons/src/main/java/org/apache/iotdb/calc/execution/operator/process/TableSortOperator.java | TIME_COLUMN_TEMPLATE source moved + DiskSpiller impl moved |
| iotdb-core/calc-commons/src/main/java/org/apache/iotdb/calc/execution/operator/process/TableMergeSortOperator.java | TIME_COLUMN_TEMPLATE source moved to CommonOperatorUtils |
| iotdb-core/calc-commons/src/main/java/org/apache/iotdb/calc/execution/operator/process/TableLinearFillWithGroupOperator.java | TIME_COLUMN_TEMPLATE source moved to CommonOperatorUtils |
| iotdb-core/calc-commons/src/main/java/org/apache/iotdb/calc/execution/operator/process/TableLinearFillOperator.java | OperatorContext abstraction changed + override visibility widened |
| iotdb-core/calc-commons/src/main/java/org/apache/iotdb/calc/execution/operator/process/TableFillOperator.java | OperatorContext abstraction changed + override visibility widened |
| iotdb-core/calc-commons/src/main/java/org/apache/iotdb/calc/execution/operator/process/SortOperator.java | DiskSpiller/SortKey moved to calc utils + ctor visibility widened |
| iotdb-core/calc-commons/src/main/java/org/apache/iotdb/calc/execution/operator/process/ProcessOperator.java | Package migration to calc-commons |
| iotdb-core/calc-commons/src/main/java/org/apache/iotdb/calc/execution/operator/process/PreviousFillWithGroupOperator.java | OperatorContext abstraction changed to CommonOperatorContext |
| iotdb-core/calc-commons/src/main/java/org/apache/iotdb/calc/execution/operator/process/OffsetOperator.java | OperatorContext abstraction changed to CommonOperatorContext |
| iotdb-core/calc-commons/src/main/java/org/apache/iotdb/calc/execution/operator/process/MergeSortOperator.java | OperatorContext abstraction changed + ctor visibility widened |
| iotdb-core/calc-commons/src/main/java/org/apache/iotdb/calc/execution/operator/process/MappingCollectOperator.java | TIME_COLUMN_TEMPLATE source moved to CommonOperatorUtils |
| iotdb-core/calc-commons/src/main/java/org/apache/iotdb/calc/execution/operator/process/LimitOperator.java | OperatorContext abstraction changed to CommonOperatorContext |
| iotdb-core/calc-commons/src/main/java/org/apache/iotdb/calc/execution/operator/process/EnforceSingleRowOperator.java | OperatorContext abstraction changed to CommonOperatorContext |
| iotdb-core/calc-commons/src/main/java/org/apache/iotdb/calc/execution/operator/process/CollectOperator.java | OperatorContext abstraction changed to CommonOperatorContext |
| iotdb-core/calc-commons/src/main/java/org/apache/iotdb/calc/execution/operator/process/AggregationMergeSortOperator.java | OperatorContext abstraction changed to CommonOperatorContext |
| iotdb-core/calc-commons/src/main/java/org/apache/iotdb/calc/execution/operator/process/AbstractConsumeAllOperator.java | Abstract operator base moved + OperatorContext abstraction changed |
| iotdb-core/calc-commons/src/main/java/org/apache/iotdb/calc/execution/operator/TsBlockWithPositionComparator.java | Package migration to calc-commons |
| iotdb-core/calc-commons/src/main/java/org/apache/iotdb/calc/execution/operator/SimpleTsBlockWithPositionComparator.java | SortOrder import moved to commons + calc utils refs |
| iotdb-core/calc-commons/src/main/java/org/apache/iotdb/calc/execution/operator/RowReferenceTsBlockManager.java | BigArray deps moved to calc |
| iotdb-core/calc-commons/src/main/java/org/apache/iotdb/calc/execution/operator/RowReference.java | Package migration to calc-commons |
| iotdb-core/calc-commons/src/main/java/org/apache/iotdb/calc/execution/operator/RowIdHashStrategy.java | Package migration to calc-commons |
| iotdb-core/calc-commons/src/main/java/org/apache/iotdb/calc/execution/operator/RowIdComparisonStrategy.java | Package migration to calc-commons |
| iotdb-core/calc-commons/src/main/java/org/apache/iotdb/calc/execution/operator/Operator.java | Operator API updated (context type changed) |
| iotdb-core/calc-commons/src/main/java/org/apache/iotdb/calc/execution/operator/IdRegistry.java | IntArrayFIFOQueue moved to calc |
| iotdb-core/calc-commons/src/main/java/org/apache/iotdb/calc/execution/operator/GroupedTopNRowNumberBuilder.java | TIME_COLUMN_TEMPLATE import moved + GroupByHash dependency updated |
| iotdb-core/calc-commons/src/main/java/org/apache/iotdb/calc/execution/operator/GroupedTopNRowNumberAccumulator.java | HeapTraversal + BigArray deps moved to calc |
| iotdb-core/calc-commons/src/main/java/org/apache/iotdb/calc/execution/operator/GroupedTopNBuilder.java | Package migration to calc-commons |
| iotdb-core/calc-commons/src/main/java/org/apache/iotdb/calc/execution/operator/AbstractOperator.java | OperatorContext abstraction changed to CommonOperatorContext |
| iotdb-core/calc-commons/src/main/java/org/apache/iotdb/calc/execution/aggregation/VarianceAccumulator.java | Package migration to calc-commons |
| iotdb-core/calc-commons/src/main/java/org/apache/iotdb/calc/execution/aggregation/Accumulator.java | Package migration to calc-commons |
| iotdb-core/calc-commons/src/main/java/org/apache/iotdb/calc/exception/QueryProcessException.java | Exception moved into calc-commons |
| iotdb-core/calc-commons/src/main/java/org/apache/iotdb/calc/exception/MemoryNotEnoughException.java | Exception moved into calc-commons |
| iotdb-core/calc-commons/src/main/codegen/templates/previousFillWithTimeDuration.ftl | Codegen output path/package updated for calc |
| iotdb-core/calc-commons/src/main/codegen/templates/previousFill.ftl | Codegen output path/package updated for calc |
| iotdb-core/calc-commons/src/main/codegen/templates/linearFill.ftl | Codegen output path/package updated for calc |
| iotdb-core/calc-commons/src/main/codegen/templates/constantFill.ftl | Codegen output path/package updated for calc |
| iotdb-core/calc-commons/src/main/codegen/templates/ModeAccumulator.ftl | Codegen updated to use CommonDescriptor |
| iotdb-core/calc-commons/src/main/codegen/templates/ArithmeticUnaryColumnTransformer.ftl | Codegen output path/package updated for calc transformation |
| iotdb-client/cli/src/main/java/org/apache/iotdb/tool/data/AbstractDataTool.java | Updated DateTimeUtils/SqlConstant imports to new common locations |
| integration-test/src/test/java/org/apache/iotdb/relational/it/query/view/old/query/IoTDBArithmeticTableViewIT.java | DateTimeUtils import updated to commons |
| integration-test/src/test/java/org/apache/iotdb/relational/it/query/old/query/IoTDBArithmeticTableIT.java | DateTimeUtils import updated to commons |
| integration-test/src/test/java/org/apache/iotdb/relational/it/query/old/builtinfunction/scalar/IoTDBFormatFunctionTableIT.java | DateTimeUtils import updated to commons |
| integration-test/src/test/java/org/apache/iotdb/relational/it/query/old/builtinfunction/scalar/IoTDBCastFunctionTableIT.java | DateTimeUtils import updated to commons |
| integration-test/src/test/java/org/apache/iotdb/relational/it/db/it/udf/IoTDBSQLFunctionManagementIT.java | TableBuiltinTableFunction import moved to commons |
| integration-test/src/test/java/org/apache/iotdb/relational/it/db/it/IoTDBMultiTAGsWithAttributesTableIT.java | JoinType static imports moved to commons |
| integration-test/src/test/java/org/apache/iotdb/confignode/it/procedure/IoTDBProcedureIT.java | SqlConstant import updated to calc location |
| integration-test/src/test/java/org/apache/iotdb/confignode/it/partition/IoTDBTimePartitionIT.java | SqlConstant import updated to calc location |
| integration-test/src/main/java/org/apache/iotdb/itbase/constant/BuiltinAggregationFunctionEnum.java | BuiltinAggregationFunction import moved to commons |
| integration-test/src/main/java/org/apache/iotdb/it/env/cluster/EnvUtils.java | DateTimeUtils static import moved to commons |
| integration-test/pom.xml | Added calc-commons dependency for integration tests |
| external-service-impl/rest/src/main/java/org/apache/iotdb/rest/protocol/v2/impl/RestApiServiceImpl.java | SessionInfo import moved to commons |
| external-service-impl/rest/src/main/java/org/apache/iotdb/rest/protocol/v2/handler/StatementConstructionHandler.java | TimestampPrecisionUtils import moved to commons |
| external-service-impl/rest/src/main/java/org/apache/iotdb/rest/protocol/v2/handler/ExceptionHandler.java | Exception imports updated to calc/commons locations |
| external-service-impl/rest/src/main/java/org/apache/iotdb/rest/protocol/v1/handler/StatementConstructionHandler.java | TimestampPrecisionUtils import moved to commons |
| external-service-impl/rest/src/main/java/org/apache/iotdb/rest/protocol/v1/handler/ExceptionHandler.java | Exception imports updated to calc/commons locations |
| external-service-impl/rest/src/main/java/org/apache/iotdb/rest/protocol/table/v1/impl/RestApiServiceImpl.java | SQL AST + SqlDialect types moved to commons |
| external-service-impl/rest/src/main/java/org/apache/iotdb/rest/protocol/table/v1/handler/StatementConstructionHandler.java | TimestampPrecisionUtils import moved to commons |
| external-service-impl/rest/src/main/java/org/apache/iotdb/rest/protocol/table/v1/handler/QueryDataSetHandler.java | SQL AST types moved to commons |
| external-service-impl/rest/src/main/java/org/apache/iotdb/rest/protocol/table/v1/handler/ExecuteStatementHandler.java | SQL AST types moved to commons |
| external-service-impl/rest/src/main/java/org/apache/iotdb/rest/protocol/table/v1/handler/ExceptionHandler.java | Exception + ParsingException imports moved to commons/calc |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+61
to
+69
| public LogicalIndexNavigation( | ||
| LogicalIndexPointer logicalIndexPointer, Map<IrLabel, Integer> mapping) { | ||
| this( | ||
| logicalIndexPointer.getLabels().stream().map(mapping::get).collect(toImmutableSet()), | ||
| logicalIndexPointer.isLast(), | ||
| logicalIndexPointer.isRunning(), | ||
| logicalIndexPointer.getLogicalOffset(), | ||
| logicalIndexPointer.getPhysicalOffset()); | ||
| } |
There was a problem hiding this comment.
mapping::get can return null for an IrLabel not present in mapping, and toImmutableSet() does not allow nulls, causing a runtime NPE. Validate the mapping contains all required labels (e.g., checkArgument(mapping.containsKey(label)) and/or wrap mapping.get(label) with requireNonNull and a clear message) before collecting.
| */ | ||
|
|
||
| package org.apache.iotdb.db.exception.query; | ||
| package org.apache.iotdb.calc.exception; |
There was a problem hiding this comment.
Moving QueryProcessException to a new package is a breaking change for any downstream code importing the old FQCN. If external modules/plugins are expected to compile against older packages, consider keeping a deprecated compatibility shim in the old package (extending or delegating to the new exception) for at least one release cycle.
| ListenableFuture<?> NOT_BLOCKED = immediateVoidFuture(); | ||
|
|
||
| OperatorContext getOperatorContext(); | ||
| CommonOperatorContext getOperatorContext(); |
There was a problem hiding this comment.
Changing Operator#getOperatorContext() from OperatorContext to CommonOperatorContext is a source/binary breaking API change for all Operator implementers. If cross-module implementers exist, consider introducing CommonOperatorContext as a subtype of the old context type (or providing an adapter/default bridge method) to reduce churn and preserve compatibility.
|
|
||
| default TsBlock nextWithTimer() throws Exception { | ||
| OperatorContext context = getOperatorContext(); | ||
| CommonOperatorContext context = getOperatorContext(); |
There was a problem hiding this comment.
Changing Operator#getOperatorContext() from OperatorContext to CommonOperatorContext is a source/binary breaking API change for all Operator implementers. If cross-module implementers exist, consider introducing CommonOperatorContext as a subtype of the old context type (or providing an adapter/default bridge method) to reduce churn and preserve compatibility.
|
|
||
| default boolean hasNextWithTimer() throws Exception { | ||
| OperatorContext context = getOperatorContext(); | ||
| CommonOperatorContext context = getOperatorContext(); |
There was a problem hiding this comment.
Changing Operator#getOperatorContext() from OperatorContext to CommonOperatorContext is a source/binary breaking API change for all Operator implementers. If cross-module implementers exist, consider introducing CommonOperatorContext as a subtype of the old context type (or providing an adapter/default bridge method) to reduce churn and preserve compatibility.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR performs a larger modularization refactor around table-model planning and execution code.
The main change is to extract shared code that was previously located in
datanodeinto common modules:PlanNoderelated code intonode-commonsOperatorimplementations and their required dependencies intocalc-commonsMotivation
Previously, a portion of table-model planning and execution code lived in
datanodeeven though the logic itself was not truly DataNode-specific. That made module boundaries unclear and introduced unnecessarydependencies from common logic onto
datanode.This refactor aims to:
datanodeMain Changes
PlanNodecode fromdatanodetonode-commonsOperatorcode and related dependencies fromdatanodetocalc-commonsImpact
Notes
This PR is part of a larger ongoing modularization effort. Because of that, the diff contains substantial file moves and dependency boundary adjustments.