Skip to content

Refactor: extract shared table-model PlanNode and Operator code from datanode #17526

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
shuwenwei wants to merge 47 commits into
base: master
Choose a base branch
from

Merge branch 'iotdb_master' into calc_commons

97af27f
Select commit
Loading
Failed to load commit list.
Open

Refactor: extract shared table-model PlanNode and Operator code from datanode #17526

Merge branch 'iotdb_master' into calc_commons
97af27f
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis failed Apr 21, 2026 in 7m 24s

Quality Gate failed

Failed conditions
7.3% Duplication on New Code (required ≤ 5%)
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Annotations

Check failure on line 272 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/relational/sql/util/DataNodeSqlFormatter.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Define a constant instead of duplicating this literal " COMMENT '" 3 times. 

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AZ2vkHnlGZOU-I61b21O&open=AZ2vkHnlGZOU-I61b21O&pullRequest=17526

Check failure on line 1155 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/relational/analyzer/StatementAnalyzer.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this method to reduce its Cognitive Complexity from 18 to the 15 allowed. 

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AZ2vkHrUGZOU-I61b21x&open=AZ2vkHrUGZOU-I61b21x&pullRequest=17526

Check warning on line 24 in iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/queryengine/plan/relational/function/ITableFunctionAINodeServiceProvider.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Abbreviation in name 'getTableFunctionAINodeService' must contain no more than '2' consecutive capital letters. 

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AZ2vkGwVGZOU-I61b20g&open=AZ2vkGwVGZOU-I61b20g&pullRequest=17526

Check warning on line 153 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/utils/DataNodeDateTimeUtils.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

All overloaded methods should be placed next to each other. Placing non-overloaded methods in between overloaded methods with the same type is a violation. Previous overloaded method located at line '62'. 

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AZ2vkISjGZOU-I61b227&open=AZ2vkISjGZOU-I61b227&pullRequest=17526

Check warning on line 1607 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/relational/analyzer/StatementAnalyzer.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Add the "@Override" annotation above this method signature 

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AZ2vkHrUGZOU-I61b21z&open=AZ2vkHrUGZOU-I61b21z&pullRequest=17526

Check warning on line 1250 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/planner/DataNodeTableOperatorGenerator.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Line is longer than 100 characters (found 101). 

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AZ2vkH_yGZOU-I61b22d&open=AZ2vkH_yGZOU-I61b22d&pullRequest=17526

Check warning on line 142 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/planner/plan/node/DataNodePlanNodeDeserializer.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

A Singleton implementation was detected. Make sure the use of the Singleton pattern is required and the implementation is the right one for the context. 

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AZ2vkH8_GZOU-I61b21-&open=AZ2vkH8_GZOU-I61b21-&pullRequest=17526

Check warning on line 42 in iotdb-core/calc-commons/src/main/java/org/apache/iotdb/calc/service/AbstractTemporaryQueryDataFileService.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

A Singleton implementation was detected. Make sure the use of the Singleton pattern is required and the implementation is the right one for the context. 

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AZ2vkJBCGZOU-I61b23b&open=AZ2vkJBCGZOU-I61b23b&pullRequest=17526

Check warning on line 653 in iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/queryengine/plan/relational/sql/util/CommonQuerySqlFormatter.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Call "Optional#isPresent()" before accessing the value. 

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AZ2vkG8SGZOU-I61b20k&open=AZ2vkG8SGZOU-I61b20k&pullRequest=17526

Check warning on line 1014 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/planner/DataNodeTableOperatorGenerator.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Abbreviation in name 'viewTTL' must contain no more than '2' consecutive capital letters. 

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AZ2vkH_yGZOU-I61b22Z&open=AZ2vkH_yGZOU-I61b22Z&pullRequest=17526

Check warning on line 607 in iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/queryengine/plan/relational/sql/util/CommonQuerySqlFormatter.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Call "Optional#isPresent()" before accessing the value. 

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AZ2vkG8SGZOU-I61b20u&open=AZ2vkG8SGZOU-I61b20u&pullRequest=17526

Check warning on line 576 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/planner/DataNodeTableOperatorGenerator.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Extract this nested ternary operation into an independent statement. 

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AZ2vkH_yGZOU-I61b22M&open=AZ2vkH_yGZOU-I61b22M&pullRequest=17526

Check warning on line 53 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/relational/analyzer/predicate/PredicateVisitor.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

"visitInPredicate" is defined in the "CommonQueryAstVisitor" interface and can be removed from this class. 

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AZ2vkHosGZOU-I61b21h&open=AZ2vkHosGZOU-I61b21h&pullRequest=17526

Check warning on line 1964 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/planner/DataNodeTableOperatorGenerator.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Declare "descendingCount" on a separate line. 

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AZ2vkH_yGZOU-I61b22R&open=AZ2vkH_yGZOU-I61b22R&pullRequest=17526

Check warning on line 5031 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/parser/ASTVisitor.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

All overloaded methods should be placed next to each other. Placing non-overloaded methods in between overloaded methods with the same type is a violation. Previous overloaded method located at line '3,153'. 

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AZ2vkID8GZOU-I61b22l&open=AZ2vkID8GZOU-I61b22l&pullRequest=17526

Check warning on line 1058 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/conf/IoTDBDescriptor.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove the parentheses around the "v" parameter 

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AZ2vkIU5GZOU-I61b228&open=AZ2vkIU5GZOU-I61b228&pullRequest=17526

Check failure on line 3502 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/relational/analyzer/StatementAnalyzer.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this method to reduce its Cognitive Complexity from 20 to the 15 allowed. 

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AZ2vkHrUGZOU-I61b214&open=AZ2vkHrUGZOU-I61b214&pullRequest=17526

Check failure on line 348 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/relational/analyzer/AggregationAnalyzer.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this method to not always return the same value. 

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AZ2vkHqDGZOU-I61b21t&open=AZ2vkHqDGZOU-I61b21t&pullRequest=17526

Check warning on line 446 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/relational/sql/ast/AstVisitor.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Abbreviation in name 'visitShowAIDevices' must contain no more than '2' consecutive capital letters. 

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AZ2vkHlzGZOU-I61b21H&open=AZ2vkHlzGZOU-I61b21H&pullRequest=17526

Check warning on line 769 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/relational/analyzer/StatementAnalyzer.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Add the "@Override" annotation above this method signature 

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AZ2vkHrUGZOU-I61b21w&open=AZ2vkHrUGZOU-I61b21w&pullRequest=17526

Check failure on line 320 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/relational/sql/util/DataNodeSqlFormatter.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Define a constant instead of duplicating this literal " TABLE " 6 times. 

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AZ2vkHnlGZOU-I61b21V&open=AZ2vkHnlGZOU-I61b21V&pullRequest=17526

Check failure on line 3290 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/relational/analyzer/StatementAnalyzer.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this method to reduce its Cognitive Complexity from 27 to the 15 allowed. 

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AZ2vkHrUGZOU-I61b212&open=AZ2vkHrUGZOU-I61b212&pullRequest=17526

Check failure on line 62 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/utils/DataNodeDateTimeUtils.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this method to reduce its Cognitive Complexity from 27 to the 15 allowed. 

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AZ2vkISjGZOU-I61b225&open=AZ2vkISjGZOU-I61b225&pullRequest=17526

Check warning on line 434 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/planner/DataNodeTableOperatorGenerator.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Abbreviation in name 'viewTTL' must contain no more than '2' consecutive capital letters. 

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AZ2vkH_yGZOU-I61b22W&open=AZ2vkH_yGZOU-I61b22W&pullRequest=17526

Check warning on line 39 in iotdb-core/calc-commons/src/main/java/org/apache/iotdb/calc/plan/relational/metadata/CommonMetadataUtils.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Add a private constructor to hide the implicit public one. 

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AZ2vkI_tGZOU-I61b23M&open=AZ2vkI_tGZOU-I61b23M&pullRequest=17526
View more details on SonarQubeCloud