Repository navigation
[python] Fix cascade drop ignoring tables found during recheck - #10425
Merged
JingsongLi merged 5 commits intoOct 8, 2026
Merged
JingsongLi merged 5 commits into
JingsongLi merged 5 commits into
Conversation
XiaoHongbo-Hope
changed the title
XiaoHongbo-Hope
changed the title
XiaoHongbo-Hope
marked this pull request as ready for review
October 8, 2026 10:06
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
During newer-PyArrow compatibility work in #9821, we found a pre-existing Catalog bug:
drop_database(cascade=True)lists tables again after deleting the initially listed tables, but ignores a nonempty result and recursively deletes the database directory. A newly created table already visible in that second listing is therefore deleted too.Raise an error when the second listing finds remaining tables, preserving those tables for inspection or an explicit retry. This fix is independent of the PyArrow upgrade.
Scope: this protects tables observed by the second listing. It does not make database drop atomic or address tables created after that listing. FileIO deletion behavior is unchanged.
Validation
A real local Catalog regression creates a new table after deletion of the original table, verifies the new table remains loadable after the error, and verifies an explicit retry succeeds. This regression fails on the unmodified base.
Catalog/FileIO tests: 49 passed (PyArrow 19.0.1). Flake8 and
git diff --checkpass. Remote object stores were not tested.