Remove deprecated HttpMethod.custom 4-arg overload (since 1.4.0)#1123
Draft
He-Pin wants to merge 2 commits into
Draft
Remove deprecated HttpMethod.custom 4-arg overload (since 1.4.0)#1123He-Pin wants to merge 2 commits into
He-Pin wants to merge 2 commits into
Conversation
….4.0) Motivation: The 4-arg overload of HttpMethod.custom was deprecated since pekko-http 1.4.0 in favor of the 5-arg overload that includes contentLengthAllowed parameter. Modification: Removed deprecated HttpMethod.custom(name, safe, idempotent, requestEntityAcceptance) from both Scala and Java APIs. Also removed the private helper oldContentLengthCondition that was only used by the deprecated method. Added MiMa filters for binary compatibility exceptions. Result: Deprecated API removed. Users should use the 5-arg custom overload.
Member
|
I, personally, prefer to keep deprecated methods around for a while and these were only deprecated recently. 1.4.0 has not been released yet. |
Member
Author
|
Ok ,let's keep it for the next major release |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The 4-arg overload of
HttpMethod.customwas deprecated since pekko-http 1.4.0 in favor of the 5-arg overload withcontentLengthAllowedparameter.Modification
Removed
HttpMethod.custom(name, safe, idempotent, requestEntityAcceptance)from Scala and Java APIs. Removed privateoldContentLengthConditionhelper. Added MiMa filters.Result
Deprecated API removed. Users should use the 5-arg
customoverload.