Skip to content

Remove deprecated HttpMethod.custom 4-arg overload (since 1.4.0) #1123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
He-Pin wants to merge 2 commits into
base: main
Choose a base branch
from
+3 −36
Draft

Remove deprecated HttpMethod.custom 4-arg overload (since 1.4.0) #1123

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a564472
refactor: remove deprecated HttpMethod.custom 4-arg overload (since 1…
He-Pin Jul 5, 2026
9b97411
Merge branch 'main' into remove/deprecated-httpmethod-custom
He-Pin Jul 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 0 additions & 21 deletions http-core/src/main/java/org/apache/pekko/http/javadsl/model/HttpMethods.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,27 +34,6 @@ private HttpMethods() {}
public static final HttpMethod QUERY = org.apache.pekko.http.scaladsl.model.HttpMethods.QUERY();
public static final HttpMethod TRACE = org.apache.pekko.http.scaladsl.model.HttpMethods.TRACE();

/**
* Create a custom method type.
*
* @deprecated The created method will compute the presence of Content-Length headers based on
* deprecated logic, use {@link #custom(String, boolean, boolean,
* org.apache.pekko.http.javadsl.model.RequestEntityAcceptance, boolean)} instead. Deprecated
* since 1.4.0.
*/
@Deprecated(since = "1.4.0")
public static HttpMethod custom(
String value,
boolean safe,
boolean idempotent,
org.apache.pekko.http.javadsl.model.RequestEntityAcceptance requestEntityAcceptance) {
// This cast is safe as implementation of RequestEntityAcceptance only exists in Scala
org.apache.pekko.http.scaladsl.model.RequestEntityAcceptance scalaRequestEntityAcceptance =
(org.apache.pekko.http.scaladsl.model.RequestEntityAcceptance) requestEntityAcceptance;
return org.apache.pekko.http.scaladsl.model.HttpMethod.custom(
value, safe, idempotent, scalaRequestEntityAcceptance);
}

/**
* Create a custom method type.
*
Expand Down
3 changes: 3 additions & 0 deletions http-core/src/main/mima-filters/2.0.x.backwards.excludes/remove-deprecated-methods.excludes
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,6 +126,9 @@ ProblemFilters.exclude[DirectMissingMethodProblem]("org.apache.pekko.http.scalad
ProblemFilters.exclude[DirectMissingMethodProblem]("org.apache.pekko.http.scaladsl.settings.ServerSettings.getWebsocketRandomFactory")
ProblemFilters.exclude[DirectMissingMethodProblem]("org.apache.pekko.http.scaladsl.settings.ServerSettings.withWebsocketRandomFactory")

# Remove deprecated HttpMethod.custom 4-arg (since 1.4.0)
ProblemFilters.exclude[DirectMissingMethodProblem]("org.apache.pekko.http.scaladsl.model.HttpMethod.custom")
ProblemFilters.exclude[DirectMissingMethodProblem]("org.apache.pekko.http.javadsl.model.HttpMethods.custom")
# Remove deprecated ParserSettings.apply/create (since Akka HTTP 10.2.0)
ProblemFilters.exclude[DirectMissingMethodProblem]("org.apache.pekko.http.scaladsl.settings.ParserSettings.apply")
ProblemFilters.exclude[DirectMissingMethodProblem]("org.apache.pekko.http.scaladsl.settings.ParserSettings.default")
Expand Down
15 changes: 0 additions & 15 deletions http-core/src/main/scala/org/apache/pekko/http/scaladsl/model/HttpMethod.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,21 +55,6 @@ final case class HttpMethod private[http] (

object HttpMethod {

// the allowsEntity condition was used to determine what responses provided the Content-Length header, before the fix
private def oldContentLengthCondition(status: StatusCode) = status.allowsEntity

/**
* Create a custom method type.
* @deprecated The created method will compute the presence of Content-Length headers based on deprecated logic.
*/
@deprecated("Use the overload with contentLengthAllowed parameter", since = "1.4.0")
def custom(name: String, safe: Boolean, idempotent: Boolean, requestEntityAcceptance: RequestEntityAcceptance)
: HttpMethod = {
require(name.nonEmpty, "value must be non-empty")
require(!safe || idempotent, "An HTTP method cannot be safe without being idempotent")
apply(name, safe, idempotent, requestEntityAcceptance, oldContentLengthCondition)
}

/**
* Create a custom method type.
*/
Expand Down