Repository navigation
Conversation
Author
|
The |
This was referenced Oct 28, 2026
Author
|
Depends on #2730 |
A daemon with the containerd image store can hold several variants of a multi-platform buildpackage. Inspecting it without a platform either finds no labels, failing the build, or picks the host's variant, putting another architecture's buildpack into the image. Resolve the target's digest first, as the builder and lifecycle fetches already do (buildpacks#2589, buildpacks#2467). Targets without an architecture keep the plain fetch: digest resolution needs an exact OS/architecture match. Signed-off-by: Niklas Herder <niklas.herder@gmail.com>
A package built locally and never pushed has no registry digest for FetchForPlatform to resolve. Fetch already tolerates that and uses the daemon's copy, so fall back to it. Signed-off-by: Niklas Herder <niklas.herder@gmail.com>
herder
force-pushed
the
fix/buildpack-fetch-per-platform
branch
from
November 16, 2026 14:48
0e6b029 to
030ad89
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When building to a daemon that uses the containerd image store, pack fetches buildpackages from
project.tomlor a registry without a platform. The daemon can hold several variants of a multi-platform buildpackage, so the inspect either:This change makes
extractPackageduseFetchForPlatformin daemon mode, as the builder (#2589) and lifecycle (#2467) fetches already do. Targets without an architecture, such aspack buildpack packagewith{OS: linux}, keep the plainFetch, because digest resolution needs an exact OS/architecture match. If the digest can't be resolved, for example for a package built locally and never pushed, it falls back toFetch, which uses the daemon's copy as before. Remote fetches are unchanged; they already select the platform viaWithDefaultPlatform.Output
The repro from #2726:
pack build --platform linux/arm64without--publishon an amd64 host, with Docker 29 and the containerd image store.Before
could not find label 'io.buildpacks.buildpackage.metadata'tiny-health-checker-x86_64-…), and/layers/paketo-buildpacks_health-checker/thc/thcisx86-64.After
tiny-health-checker-aarch64-…, andthcisARM aarch64.--platformstill uses the x86_64 binary.Documentation
Related
Resolves #2726