Skip to content

test: only assert the last line of quiet-mode local build output - #2730

Merged
jjbustamante merged 1 commit into
buildpacks:mainfrom
Pranav-IIITM:fix-quiet-mode-test-containerd
Nov 2, 2026
Merged

jjbustamante merged 1 commit into
buildpacks:mainfrom
Pranav-IIITM:fix-quiet-mode-test-containerd

Conversation

@Pranav-IIITM

Copy link
Copy Markdown
Member

Summary

Fixes the test (linux) failure that is blocking open PRs (e.g. #2727, #2728).

GitHub's ubuntu-latest runner moved to ubuntu-26.04, whose Docker daemon uses containerd image storage. When building without --publish, pack prints a warning about containerd storage performance before the image reference. The test Quiet mode / local / only prints app name and sha compared the whole output exactly, so it started failing even though pack behaves correctly.

Changes

  • The quiet-mode local build test now checks only the last line of output (the image@digest line), so it passes whether or not the daemon uses containerd storage.
  • No change to pack's behaviour.

Notes

Whether the containerd warning should be printed in quiet mode at all is a separate question and is left out of this PR.

Closes #2729

Runners whose Docker daemon uses containerd image storage print a
performance warning before the image reference, which broke the
exact-match assertion.

Signed-off-by: Pranav-IIITM <jogdandpranav2007@gmail.com>
@Pranav-IIITM
Pranav-IIITM requested review from a team as code owners October 28, 2026 13:25
@github-actions github-actions Bot added this to the 0.41.0 milestone Oct 28, 2026
@github-actions github-actions Bot added the type/enhancement Issue that requests a new feature or improvement. label Oct 28, 2026
@Pranav-IIITM

Copy link
Copy Markdown
Member Author

@jjbustamante @jkutner CI is green on this PR. test (linux) ran on the ubuntu-26.04 runner (the same image that fails #2727 and #2728), and Quiet mode / local / only prints app name and sha now passes.

Once this is merged, #2727, #2728 and any other PR hitting this failure should go green after a rebase or CI re-run.

@jjbustamante jjbustamante left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is one is fine for now, just to unblock the other PRs, but we need to fix the root cause

@jjbustamante
jjbustamante merged commit cddf381 into buildpacks:main Nov 2, 2026
16 checks passed
@jjbustamante jjbustamante modified the milestones: 0.41.0, 0.40.11 Nov 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type/enhancement Issue that requests a new feature or improvement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Quiet-mode build test fails on ubuntu-26.04 runners

2 participants