Repository navigation
test: only assert the last line of quiet-mode local build output - #2730
Merged
jjbustamante merged 1 commit intoNov 2, 2026
Merged
Conversation
Runners whose Docker daemon uses containerd image storage print a performance warning before the image reference, which broke the exact-match assertion. Signed-off-by: Pranav-IIITM <jogdandpranav2007@gmail.com>
Member
Author
|
@jjbustamante @jkutner CI is green on this PR. Once this is merged, #2727, #2728 and any other PR hitting this failure should go green after a rebase or CI re-run. |
This was referenced Nov 2, 2026
jjbustamante
approved these changes
Nov 2, 2026
jjbustamante
left a comment
Member
There was a problem hiding this comment.
This is one is fine for now, just to unblock the other PRs, but we need to fix the root cause
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the
test (linux)failure that is blocking open PRs (e.g. #2727, #2728).GitHub's
ubuntu-latestrunner moved toubuntu-26.04, whose Docker daemon uses containerd image storage. When building without--publish, pack prints a warning about containerd storage performance before the image reference. The testQuiet mode / local / only prints app name and shacompared the whole output exactly, so it started failing even though pack behaves correctly.Changes
image@digestline), so it passes whether or not the daemon uses containerd storage.Notes
Whether the containerd warning should be printed in quiet mode at all is a separate question and is left out of this PR.
Closes #2729