Skip to content

Add logical facts and refine cardinality semantics - #108

Draft
chopradish wants to merge 1 commit into
stack/cardinality-03-suite-workflowsfrom
stack/cardinality-04-sketch-estimation
Draft

chopradish wants to merge 1 commit into
stack/cardinality-03-suite-workflowsfrom
stack/cardinality-04-sketch-estimation

Conversation

@chopradish

@chopradish chopradish commented Oct 5, 2026 •

Copy link
Copy Markdown

Problem

The estimator mixed value lineage and predicate constraints with estimation policy, making repeated predicates and join domains hard to reason about.

Changes

Added logical-facts analysis and used its equivalence, range, nullability, and key facts in non-sketch cardinality estimation.

How do you know it works?

Logical-facts and core analysis tests pass without default features, and workspace Clippy passes.

@codecov-commenter

codecov-commenter commented Oct 5, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 88.38235% with 79 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (stack/cardinality-03-suite-workflows@41febc0). Learn more about missing BASE report.

Files with missing lines Patch % Lines
optd/core/src/analysis/logical_facts.rs 88.3% 79 Missing ⚠️
Additional details and impacted files
Files with missing lines Coverage Δ
optd/core/src/analysis.rs 93.3% <ø> (ø)
optd/core/src/catalog.rs 83.4% <100.0%> (ø)
optd/core/src/lib.rs 86.5% <ø> (ø)
optd/core/src/analysis/logical_facts.rs 88.3% <88.3%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@chopradish
chopradish force-pushed the stack/cardinality-04-sketch-estimation branch from 68882e5 to 6fa3c05 Compare October 5, 2026 17:01
@chopradish
chopradish added this pull request to stack #110 October 5, 2026 19:56
@chopradish
chopradish force-pushed the stack/cardinality-04-sketch-estimation branch from 6fa3c05 to 5afa1a3 Compare October 5, 2026 20:11
@chopradish chopradish changed the title Add sketch-aware cardinality estimation Add logical facts analysis Oct 5, 2026
@chopradish
chopradish force-pushed the stack/cardinality-04-sketch-estimation branch from a98303d to 18650a5 Compare October 5, 2026 20:40
@chopradish chopradish changed the title Add logical facts analysis Add logical facts and refine cardinality semantics Oct 5, 2026
@chopradish
chopradish force-pushed the stack/cardinality-04-sketch-estimation branch 2 times, most recently from 96446fc to 867b5d5 Compare October 6, 2026 02:04
@chopradish
chopradish removed this pull request from stack #110 October 6, 2026 02:20
@chopradish
chopradish added this pull request to stack #114 October 6, 2026 02:21
@chopradish
chopradish force-pushed the stack/cardinality-04-sketch-estimation branch from 867b5d5 to 3792a2c Compare October 6, 2026 02:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants