ci: re-enable MetaDrive simulator driving test (#30693)#38136
Open
themoddedcube wants to merge 2 commits into
Open
ci: re-enable MetaDrive simulator driving test (#30693)#38136themoddedcube wants to merge 2 commits into
themoddedcube wants to merge 2 commits into
Conversation
The job was disabled with `if: false` after timeouts. Root cause was a 2-minute total timeout on a job where scons alone takes 10-40 minutes. Changes: - Remove `if: false` gate on simulator_driving job - Set build timeout to 10 min (nsc) / 40 min (free ubuntu-24.04) - Set driving test timeout to 15 min (nsc) / 20 min (free runner) - Pass MAX_TIME_PER_STEP=120 on free runners so MetaDrive's software OpenGL (llvmpipe) has enough time to start and render - Pass COLLECT_LOGS=1 to keep loggerd running for artifact collection - Upload qlog/rlog/camera files as metadrive-logs artifact - Make max_time_per_step configurable via MAX_TIME_PER_STEP env var Closes commaai#30693 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Contributor
Process replay diff reportReplays driving segments through this PR and compares the behavior to master. ✅ 0 changed, 66 passed, 0 errors |
The MetaDrive + openpilot pipeline requires the 8-core namespace runner. Fork PRs that run on the 2-core ubuntu-24.04 runner cannot complete the test in time. Add an if: condition that mirrors the runs-on condition so the job is skipped for fork PRs and only executes on the commaai/openpilot namespace runner where it was previously working. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The job was disabled with
if: falseafter timeouts. Root cause was a 2-minute total timeout on a job where scons alone takes 10-40 minutes.Changes:
if: falsegate on simulator_driving jobCloses #30693