Repository navigation
fix: preserve list-valued filters - #657
Shubham-Padkonde wants to merge 1 commit into
Conversation
|
Fixed the test-case type inference reported by the sanity mypy job in 177df45. The explicit case annotation preserves all test inputs and runtime behavior. Validation: Prepared with OpenAI Codex assistance; the contributor personally signed off this commit. |
Honny1
left a comment
There was a problem hiding this comment.
Please sqoush comiints in to one. I have just one qestion about type.
PTAL @timcoding1988
| criteria[key].append(str_value) | ||
| else: | ||
| criteria[key] = [str_value] | ||
| values = value if isinstance(value, list) else [value] |
177df45 to
1685e6f
Compare
|
Updated the filter handling to preserve tuples as well as lists and extended the regression cases to cover both. Squashed the three personally signed commits into 1685e6f as requested; verified the squashed file tree is identical to the signed pre-squash tree. The prepared patch passed 13 focused tests with 14 subtests, Ruff and the Linux-target mypy check before signing. Full hosted distribution/integration checks are running and are not claimed passed. Prepared with Codex assistance. |
|
I checked all five failing distribution jobs on 1685e6f. They share five URL-history assertions comparing percent-encoded socket paths ( The new filter cases pass, as do unit coverage, sanity, DCO and all seven RPM builds. I have kept the patch scoped to filter handling; the distribution checks are still red. Example full log: https://artifacts.dev.testing-farm.io/91afd380-fa62-4e9f-b33e-bcf8cb585534/work-all_python_6llwv4x/plans/distro/all_python/execute/data/guest/default-0/tests/tests/all_python-1/output.txt Prepared with Codex assistance. |
Fixes containers#542 Signed-off-by: Shubham Padkonde <shubhampadkonde12@gmail.com>
1685e6f to
32ad26f
Compare
Fixes #542: dictionaries containing list-valued filters now encode each element as a separate filter value rather than serializing the entire Python list as one string. Scalar conversion remains unchanged; empty lists and None values contribute no criteria.
Tests cover multiple labels, mixed scalar/list filters, numeric elements, empty/None entries, and the actual ContainersManager.list HTTP query without mutating the caller's filter dictionary.
Validation:
Remaining hosted checks are not all green: distro-sanity errors before lint with
/bin/sh: - : invalid option; Fedora 43 and rawhide RPM builds failed (build logs could not yet be retrieved), and several distro integration checks are pending. The passing Linux unit/coverage check resolves the original local validation blocker; these remaining checks still need investigation before merge.Prepared with OpenAI Codex assistance. No local Podman daemon or container data was modified.