Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 4 additions & 6 deletions podman/api/http_utils.py
Original file line number Diff line number Diff line change
Expand Up @@ -45,12 +45,10 @@ def _format_dict(filters, criteria):
for key, value in filters.items():
if value is None:
continue
str_value = str(value)

if key in criteria:
criteria[key].append(str_value)
else:
criteria[key] = [str_value]
values = value if isinstance(value, (list, tuple)) else [value]
for item in values:
if item is not None:
criteria.setdefault(key, []).append(str(item))


def _format_string(filters, criteria):
Expand Down
25 changes: 25 additions & 0 deletions podman/tests/unit/test_api_utils.py
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,31 @@ class TestCase:
if actual is not None:
self.assertIsInstance(actual, str)

def test_format_list_valued_filters(self) -> None:
cases: list[tuple[dict[str, Any], Optional[dict[str, list[str]]]]] = [
({"label": ["team=platform", "env=test"]}, {"label": ["team=platform", "env=test"]}),
({"label": ["enabled"], "exited": 0}, {"label": ["enabled"], "exited": ["0"]}),
({"exited": [0, 1]}, {"exited": ["0", "1"]}),
({"label": [], "status": "running"}, {"status": ["running"]}),
({"label": [None, "enabled"], "status": None}, {"label": ["enabled"]}),
({"label": []}, None),
({"label": [None]}, None),
]
cases.extend(
(
{
key: tuple(value) if isinstance(value, list) else value
for key, value in filters.items()
},
expected,
)
for filters, expected in list(cases)
)
for filters, expected in cases:
with self.subTest(filters=filters):
actual = api.prepare_filters(filters)
self.assertEqual(json.loads(actual) if actual is not None else None, expected)

def test_containerignore_404(self) -> None:
actual = api.prepare_containerignore("/does/not/exists")
self.assertListEqual([], actual)
Expand Down
14 changes: 14 additions & 0 deletions podman/tests/unit/test_containersmanager.py
Original file line number Diff line number Diff line change
Expand Up @@ -144,6 +144,20 @@ def test_list_filtered(self, mock):
"6dc84cc0a46747da94e4c1571efcc01a756b4017261440b4b8985d37203c3c03",
)

@requests_mock.Mocker()
def test_list_multiple_labels(self, mock):
filters = {"label": ["team=platform", "env=test"], "status": "running"}
mock.get(tests.LIBPOD_URL + "/containers/json", json=[FIRST_CONTAINER])

actual = self.client.containers.list(filters=filters)

self.assertEqual([container.id for container in actual], [FIRST_CONTAINER["Id"]])
self.assertEqual(
json.loads(mock.last_request.qs["filters"][0]),
{"label": ["team=platform", "env=test"], "status": ["running"]},
)
self.assertEqual(filters, {"label": ["team=platform", "env=test"], "status": "running"})

@requests_mock.Mocker()
def test_list_no_filters(self, mock):
mock.get(
Expand Down