Repository navigation
Restore samplerate dependency -- broke VR separation on Linux/Windows - #15
Merged
Merged
Conversation
The CI added in #13/#14 just caught its first real bug: vr_auto and vr_cpu failed on ubuntu-latest with ModuleNotFoundError: No module named 'samplerate' lazily raised from inside librosa.resample(). librosa's resample() lazily imports the `samplerate` package for several res_type values, including the VR-arch model params' default. separate.py forces 'polyphase' (scipy-backed, no samplerate needed) on Apple Silicon specifically (see the ARM check in separate.py:1207/1544), which is why this was invisible when the original dependency modernization was tested only on macOS -- and why grepping our own code for direct `import samplerate` (which found nothing) wasn't sufficient: it's a transitive runtime dependency triggered by a parameter value, not a direct import. Restored `samplerate` to requirements.txt with an explanatory comment so it doesn't get grep-and-removed again. Built by dotdev.dev Claude-Session: https://claude.ai/code/session_01LjMNiTr56yH2jqLheNSdS8
This was referenced Sep 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Progresses #1 -- the CI added in #13/#14 just caught its first real Linux-specific bug.
`vr_auto` and `vr_cpu` failed on ubuntu-latest with `ModuleNotFoundError: No module named 'samplerate'`, lazily raised from inside librosa's `resample()`.
librosa lazily imports the `samplerate` package for several `res_type` values, including the VR-arch model params' default. `separate.py` forces `'polyphase'` (scipy-backed, no samplerate needed) specifically on Apple Silicon (see the ARM check at separate.py:1207/1544) -- which is exactly why this was invisible when the original dependency modernization (#5) was tested only on macOS, and why grepping our own code for `import samplerate` (which correctly found nothing direct) wasn't sufficient: it's a transitive runtime dependency triggered by a parameter value, not a direct import in our code.
Restored `samplerate` to requirements.txt with a comment explaining why, so it doesn't get grep-and-removed again by a future cleanup pass.
This is a good demonstration of exactly why #13's CI is worth having.
Built by dotdev.dev