Skip to content

Restore samplerate dependency -- broke VR separation on Linux/Windows #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dotdevdotdev merged 1 commit into from
Sep 6, 2026
Merged

Restore samplerate dependency -- broke VR separation on Linux/Windows #15

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,13 @@ audioread
pydub
resampy
six
# librosa.resample lazily imports `samplerate` for several res_type values
# (e.g. the VR-arch model params' default type) on non-ARM platforms --
# separate.py forces 'polyphase' (scipy-backed, no samplerate needed) on
# Apple Silicon only, so this was missed by grepping our own code for direct
# imports during the original dependency modernization. Confirmed via CI:
# broke every VR-architecture separation on Linux/Windows/Intel Mac.
samplerate

# --- Deep learning (install torch/torchvision separately; see header) ---
einops
Expand Down
Loading