Repository navigation
fix: raise siso remote timeout for Windows clang-cl compiles - #912
Merged
Merged
Conversation
Chromium's clang-cl rules use a 2 minute siso remote timeout. Heavy Windows compiles exceed it, fall back to local execution, and since local results are not cached they recompile on every warm build. Apply the existing macOS 10m bump to Windows clang-cl rules as well. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01GkpQ9nmAGxxVpwT8wPzfbC
dsanders11
approved these changes
Oct 15, 2026
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
MarshallOfSound
enabled auto-merge (squash)
October 15, 2026 07:03
MarshallOfSound
approved these changes
Oct 15, 2026
claude Bot
pushed a commit
to electron/electron
that referenced
this pull request
Oct 15, 2026
Bump the pinned @electron/build-tools SHA from 32e2253f to 3bf7c9f5 to pick up electron/build-tools#912, which raises siso's remote timeout for Windows clang-cl compiles to 10m (matching macOS) so heavy compiles finish remotely and get cached instead of falling back to local on every warm build. Also picks up electron/build-tools#911 (e-rcv only). Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01GkpQ9nmAGxxVpwT8wPzfbC
jkleinsc
pushed a commit
to electron/electron
that referenced
this pull request
Oct 15, 2026
…4958) Bump the pinned @electron/build-tools SHA from 32e2253f to 3bf7c9f5 to pick up electron/build-tools#912, which raises siso's remote timeout for Windows clang-cl compiles to 10m (matching macOS) so heavy compiles finish remotely and get cached instead of falling back to local on every warm build. Also picks up electron/build-tools#911 (e-rcv only). Claude-Session: https://claude.ai/code/session_01GkpQ9nmAGxxVpwT8wPzfbC Co-authored-by: Claude <noreply@anthropic.com>
MarshallOfSound
pushed a commit
to electron/electron
that referenced
this pull request
Oct 15, 2026
…5026) Bump the pinned @electron/build-tools SHA from 5a3a3bf9 to 3bf7c9f5 to pick up electron/build-tools#912, which raises siso's remote timeout for Windows clang-cl compiles to 10m (matching macOS) so heavy compiles finish remotely and get cached instead of falling back to local on every warm build. Also picks up electron/build-tools#911 (e-rcv only). Manual backport of #54958. Claude-Session: https://claude.ai/code/session_01GkpQ9nmAGxxVpwT8wPzfbC Co-authored-by: Claude <noreply@anthropic.com>
MarshallOfSound
pushed a commit
to electron/electron
that referenced
this pull request
Oct 15, 2026
…5025) Bump the pinned @electron/build-tools SHA from 5a3a3bf9 to 3bf7c9f5 to pick up electron/build-tools#912, which raises siso's remote timeout for Windows clang-cl compiles to 10m (matching macOS) so heavy compiles finish remotely and get cached instead of falling back to local on every warm build. Also picks up electron/build-tools#911 (e-rcv only). Manual backport of #54958. Claude-Session: https://claude.ai/code/session_01GkpQ9nmAGxxVpwT8wPzfbC Co-authored-by: Claude <noreply@anthropic.com>
MarshallOfSound
pushed a commit
to electron/electron
that referenced
this pull request
Oct 15, 2026
…5027) Bump the pinned @electron/build-tools SHA from 5a3a3bf9 to 3bf7c9f5 to pick up electron/build-tools#912, which raises siso's remote timeout for Windows clang-cl compiles to 10m (matching macOS) so heavy compiles finish remotely and get cached instead of falling back to local on every warm build. Also picks up electron/build-tools#911 (e-rcv only). Manual backport of #54958. Claude-Session: https://claude.ai/code/session_01GkpQ9nmAGxxVpwT8wPzfbC Co-authored-by: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by David Babenko-Sanders · Slack thread
Windows clang-cl compiles that take longer than Chromium's 2-minute siso remote timeout fall back to local execution, and local results aren't written to the cache, so every warm Windows build recompiles the same few heavy files:
desktop_window_tree_host_win.obj(~380s),media_factory.obj(~340s) andelectron_api_msix_updater.obj(~200s). The nightly win-x64 log shows theffallback markers andfallback:10 cache-write:0in the siso stats: https://github.com/electron/electron/actions/runs/38568230835/job/115867161777. The existing 10m bump intools/main.staronly covered macOSclang/rules; this applies it to Windowsclang-cl/rules too, so those compiles finish remotely and get cached. Not yet verified on CI; the next warm Windows build should showfallback:0(visible without-quiet, e.g. in the nightly).🤖 Generated with Claude Code
https://claude.ai/code/session_01GkpQ9nmAGxxVpwT8wPzfbC
Generated by Claude Code