Skip to content

fix: raise siso remote timeout for Windows clang-cl compiles #912

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MarshallOfSound merged 1 commit into from
Oct 15, 2026
Merged

fix: raise siso remote timeout for Windows clang-cl compiles #912

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 11 additions & 8 deletions tools/main.star
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,15 +36,18 @@ def init(ctx):
"clang_large": step_config["platforms"]["default"],
})

# Chromium's clang rules carry a 2 minute timeout that siso applies
# client-side to the whole remote step (upload + RBE queue + execution
# + download). When it fires siso re-runs the compile locally, and on
# the 5-core / 14 GB macOS CI runners a local ThinLTO compile takes
# 5-10 minutes and lands on the critical path (75 such fallbacks in
# one release build). Give remote compiles a deadline that survives
# RBE queueing; local fallback stays as the safety net.
# Chromium's clang and clang-cl rules carry a 2 minute timeout that siso
# applies client-side to the whole remote step (upload + RBE queue +
# execution + download). When it fires siso re-runs the compile locally,
# which lands on the critical path: a local ThinLTO compile takes 5-10
# minutes on the macOS CI runners (75 such fallbacks in one release
# build), and since local results are not cached, a few heavy Windows
# clang-cl compiles (e.g. desktop_window_tree_host_win.obj) rerun locally
# on every warm build. Give remote compiles a deadline that survives RBE
# queueing; local fallback stays as the safety net.
if runtime.os != "linux":
for rule in step_config["rules"]:
if rule["name"].startswith("clang/") and rule.get("remote"):
if (rule["name"].startswith("clang/") or rule["name"].startswith("clang-cl/")) and rule.get("remote"):
rule["timeout"] = "10m"

# Add additional Windows SDK headers needed by Electron. Use
Expand Down
Loading