Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ranges ending at
pendingcurrently stop at the canonical head, soeth_getLogsomits logs from OP's local pending flashblock. This restores the expected canonical-plus-pending result while preserving range/response limits and excluding stale-branch pending blocks.Stacked on #23046 and pins
ethereum-optimism/reth@1c51c30. The affected range handling is shared with upstream Reth, where it also omits logs from locally built pending blocks; the impact is not limited to OP flashblocks.Closes #23104. Related review finding: #23046 (comment)
The full Reth update reviewer was not rerun because this PR contains one focused fix from the already-reviewed bump; the Rust implementation reviewer completed with no remaining findings.