Collapse REICAT/SBN and MAG digital-assets sections on the book form (#274)#276
Conversation
|
Warning Review limit reached
Next review available in: 31 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughLe sezioni REICAT/SBN e Copie Digitalizzate diventano accordion accessibili, inizializzate in base alla presenza di dati e aperte automaticamente dopo importazioni o aggiunte riuscite. ChangesSezioni catalografiche accordion
Estimated code review effort: 2 (Simple) | ~10 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
…ions Both plugin-injected sections (z39-server's REICAT/SBN cataloguing panel and oai-pmh-server's MAG digital-copies panel) rendered fully expanded on the book form, crowding it for the majority of users who don't catalogue against SBN or manage digitised copies (#274). Each is now a collapsible accordion: - Collapsed by default on a fresh create (no data). - Auto-opens when the book already carries data (REICAT: sbn_bid or subjects; MAG: existing digital assets) — so editing a catalogued/digitised record still shows it expanded. - Header is a clickable toggle (type="button", chevron rotates, aria-expanded). - Opens on demand, and stays open when an SBN import / asset-add lands. Note: the whole REICAT/SBN section can also be removed entirely by deactivating the z39-server plugin (Admin → Plugins); this just makes it unobtrusive while keeping the plugin active. The collapsed body stays in the DOM, so all fields still submit — verified a save with the section collapsed persists the book and preserves sbn_bid. No new user-facing strings (headers reuse existing __() keys). Verified live on create + edit for both sections: default state, toggle, auto-open, save; no console errors. PHPStan level 5 clean.
8bab473 to
991bdd4
Compare
Closes #274.
Both plugin-injected sections on the book form — z39-server's REICAT/SBN cataloguing panel and oai-pmh-server's MAG digital-copies panel — rendered fully expanded, crowding the form for the majority of users who don't catalogue against SBN or manage digitised copies.
Each is now a collapsible accordion:
sbn_bidor subjects; MAG: existing digital assets — so editing a catalogued/digitised record still shows it expanded.type="button", chevron rotates,aria-expanded).For anyone who wants REICAT/SBN gone entirely rather than just collapsed, the whole section can still be removed by deactivating the z39-server plugin (Admin → Plugins) — this PR just makes it unobtrusive while keeping the plugin active.
The collapsed body stays in the DOM, so all fields still submit — I verified a save with the section collapsed persists the book and preserves
sbn_bid. No new user-facing strings (headers reuse existing__()keys).Verified live on create + edit for both sections: default state, toggle open/close, auto-open on pre-existing data, save with section collapsed; zero console errors. PHPStan level 5 clean.
Summary by CodeRabbit
Nuove funzionalità
Accessibilità