Repository navigation
Add Adaptive Gating to the EGM Lite design - #458
Merged
Merged
Conversation
Extends docs/designs/lite.md with Adaptive Gating. It builds on the core 5-phase flow and adds an optional spec review of the checklist before any file is edited. Direct execution remains available for routine changes. - Adds Phase 2A (checklist with a recommendation based on fixed complexity criteria) and Phase 2B (spec review by a fresh-context subagent against a Spec Review Rubric). - Defines command routing: review and goldfish start the spec review after the checklist and the diff review after execution or on an existing diff. An out-of-order command returns a state advisory. - Extends Phase 5 to handle both spec review and diff review responses. A clean spec review prompts for exec. - Names Phase 4 Adversarial Diff Review and covers doc-only diffs. - Updates the flowchart and adds a sixth verification invariant.
1 task done
eewing314
reviewed
Nov 16, 2026
eewing314
reviewed
Nov 16, 2026
eewing314
approved these changes
Nov 16, 2026
1 task done
njeunje
added a commit
that referenced
this pull request
Nov 17, 2026
Implements the /egm-lite rapid engineering protocol skill, behavioral evaluation benchmark, keyline assets, packaging manifests, and Starlight documentation in google/elephant-goldfish-model, implementing the design specified in #419 and #458. - Skill Core (skills/egm-lite/): - Implements /egm-lite in skills/egm-lite/SKILL.md with Adaptive Gating (Sections 2A/2B and 5), skippable spec review, and state transition advisories. - Records review baseline before the first edit and inventories untracked and committed task changes. - Includes canonical 24x24 dual-facet keyline vector artwork (#465). - Verification Suite: - Adds interactive protocol verification checklist in skills/egm-lite/TEST.md. - Implements 28 declarative behavioral evaluation scenarios in skills/egm-lite/test_scenarios.yaml. - Packaging & Starlight Documentation: - Registers egm-lite in scripts/pack_plugin.py and updates test assertions. - Adds docs/site/skills/egm-lite.md and Starlight routing. Co-authored-by: Oliver Newth <5912894+n3wth@users.noreply.github.com> Closes #460 Closes #461
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Key Changes
Extends the EGM Lite design in
docs/designs/lite.mdwith Adaptive Gating. It builds on the core 5-phase flow and adds one more option: the checklist can be reviewed by a fresh-context subagent before any file is edited. The core flow stays as it is, and direct execution remains available for routine changes. This PR changes the design doc only. The implementation follows in the PR stacked on top.reviewandgoldfishstart the spec review after the checklist, and the diff review after execution or on an existing diff. An out-of-order command returns a state advisory.exec.Stacked on #438.
Refs #461
Contribution Type
Track: Feature / Architectural Change -- Stage 1: Design Doc PR
Verification
pytest tests/unit: 385 passed, 2 skipped.Human Accountability Affirmation