Skip to content

Add Adaptive Gating to the EGM Lite design - #458

Merged
eewing314 merged 5 commits into
feat/egm-lite-corefrom
docs/egm-lite-adaptive-gating
Nov 16, 2026
Merged

eewing314 merged 5 commits into
feat/egm-lite-corefrom
docs/egm-lite-adaptive-gating

Conversation

@njeunje

@njeunje njeunje commented Nov 16, 2026 •

Copy link
Copy Markdown
Member

Summary of Key Changes

Extends the EGM Lite design in docs/designs/lite.md with Adaptive Gating. It builds on the core 5-phase flow and adds one more option: the checklist can be reviewed by a fresh-context subagent before any file is edited. The core flow stays as it is, and direct execution remains available for routine changes. This PR changes the design doc only. The implementation follows in the PR stacked on top.

  • Adds Phase 2A (checklist plus a recommendation based on fixed complexity criteria) and Phase 2B (spec review against a Spec Review Rubric).
  • Defines command routing: review and goldfish start the spec review after the checklist, and the diff review after execution or on an existing diff. An out-of-order command returns a state advisory.
  • Extends Phase 5 to handle both spec review and diff review responses. A clean spec review prompts for exec.
  • Names Phase 4 Adversarial Diff Review, to tell it apart from the spec review, and covers doc-only diffs.
  • States that the diff review is optional: a task can end after execution without it.
  • Updates the flowchart and adds a sixth verification invariant.

Stacked on #438.

Refs #461

Contribution Type

Track: Feature / Architectural Change -- Stage 1: Design Doc PR

Verification

  • pytest tests/unit: 385 passed, 2 skipped.

Human Accountability Affirmation

Extends docs/designs/lite.md with Adaptive Gating. It builds on the core
5-phase flow and adds an optional spec review of the checklist before any
file is edited. Direct execution remains available for routine changes.

- Adds Phase 2A (checklist with a recommendation based on fixed complexity
  criteria) and Phase 2B (spec review by a fresh-context subagent against a
  Spec Review Rubric).
- Defines command routing: review and goldfish start the spec review after
  the checklist and the diff review after execution or on an existing diff.
  An out-of-order command returns a state advisory.
- Extends Phase 5 to handle both spec review and diff review responses. A
  clean spec review prompts for exec.
- Names Phase 4 Adversarial Diff Review and covers doc-only diffs.
- Updates the flowchart and adds a sixth verification invariant.
@njeunje njeunje self-assigned this Nov 16, 2026
@njeunje
njeunje requested a review from eewing314 November 16, 2026 18:43
@njeunje njeunje added docs Improvements or additions to documentation design-ready Maintainer-approved inquiry unlocked for an EGM Design Document PR and removed design-ready Maintainer-approved inquiry unlocked for an EGM Design Document PR labels Nov 16, 2026
Comment thread docs/designs/lite.md Resolved
Comment thread docs/designs/lite.md Resolved
@eewing314
eewing314 merged commit 1f2b5a0 into feat/egm-lite-core Nov 16, 2026
8 checks passed
@eewing314
eewing314 deleted the docs/egm-lite-adaptive-gating branch November 16, 2026 23:56
njeunje added a commit that referenced this pull request Nov 17, 2026
Implements the /egm-lite rapid engineering protocol skill, behavioral evaluation benchmark, keyline assets, packaging manifests, and Starlight documentation in google/elephant-goldfish-model, implementing the design specified in #419 and #458.

- Skill Core (skills/egm-lite/):
  - Implements /egm-lite in skills/egm-lite/SKILL.md with Adaptive Gating (Sections 2A/2B and 5), skippable spec review, and state transition advisories.
  - Records review baseline before the first edit and inventories untracked and committed task changes.
  - Includes canonical 24x24 dual-facet keyline vector artwork (#465).
- Verification Suite:
  - Adds interactive protocol verification checklist in skills/egm-lite/TEST.md.
  - Implements 28 declarative behavioral evaluation scenarios in skills/egm-lite/test_scenarios.yaml.
- Packaging & Starlight Documentation:
  - Registers egm-lite in scripts/pack_plugin.py and updates test assertions.
  - Adds docs/site/skills/egm-lite.md and Starlight routing.

Co-authored-by: Oliver Newth <5912894+n3wth@users.noreply.github.com>
Closes #460
Closes #461
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants