Skip to content

feat(skills): implement EGM Lite rapid engineering protocol (Stage 2) - #438

Merged
eewing314 merged 1 commit into
mainfrom
feat/egm-lite-core
Nov 18, 2026
Merged

eewing314 merged 1 commit into
mainfrom
feat/egm-lite-core

Conversation

@njeunje

@njeunje njeunje commented Nov 13, 2026 •

Copy link
Copy Markdown
Member

Summary of Key Changes

Implements the /egm-lite rapid engineering protocol skill, behavioral evaluation benchmark, keyline assets, packaging manifests, and Starlight documentation in google/elephant-goldfish-model, implementing the design specified in #419 and the adaptive gating design from #458.

  • Skill Core (skills/egm-lite/):
    • Implements /egm-lite in skills/egm-lite/SKILL.md enforcing the decoupled state machine (critique pause -> checklist -> exec -> review -> resolution gate).
    • Implements Adaptive Gating (Sections 2A/2B and 5) with a skippable pre-implementation spec review, state transition advisories, and model rule markers. At the checklist gate, names commands and offers both; complexity criteria decide recommendations.
    • Implements fresh-context subagent isolation guard (invoke_subagent), presentation-only finding triage ([🛠️ X FIX | 🛡️ Y CONTEST]), and non-sycophantic tone.
    • Records a review baseline in the checklist before the first edit and gives the reviewer the full task change against it, including untracked files and commits made during the task.
    • Makes checklist the only command at the Critique Pause gate. exec there sends the user to checklist first; exec after the checklist, and after a review with agreed fixes, still works.
    • Adds 24x24 dual-facet keyline vector artwork (skills/egm-lite/assets/icon.svg).
    • Declares Codex/OpenAI extension metadata in skills/egm-lite/agents/openai.yaml.
  • Verification Suite:
    • Adds interactive protocol verification checklist in skills/egm-lite/TEST.md.
    • Implements 28 declarative behavioral evaluation scenarios in skills/egm-lite/test_scenarios.yaml.
  • Packaging & Manifests:
    • Registers egm-lite in scripts/pack_plugin.py.
    • Updates packaging assertions (7 -> 8 skills, color palette, service exclusions) in tests/unit/test_packaging.py.
    • Updates harness skill expectations in tests/unit/test_harnesses.py and OpenCode adapter assertions in tests/unit/test_opencode_adapter.py.
    • Adds /egm-lite to the root README.md quick reference table.
  • Starlight Site Documentation:
    • Adds docs/site/skills/egm-lite.md linking skills/egm-lite/SKILL.md.
    • Registers skills/egm-lite in site/scripts/check-docs.mjs and site/astro.config.mjs.
    • Maps lite icon in site/src/components/SkillIcon.astro and documents /egm-lite in docs/site/skills.md.

Closes #460
Closes #461

Contribution Type

Track: Feature / Architectural Change -- Stage 2: Implementation PR
(Implements Stage 1 Design Doc #419 and Adaptive Gating Design Doc #458)

Verification

  1. Behavioral Evaluation Suite:
    • 28 scenarios in skills/egm-lite/test_scenarios.yaml. Live model run of this file: not run. pytest tests/unit checks their structure only.
  2. Offline Unit & Packaging Tests:
    • pytest tests/unit/test_harnesses.py
    • pytest tests/unit/test_packaging.py
    • pytest tests/unit/test_opencode_adapter.py
  3. Site & Documentation Validation:
    • npm run check:docs

Human Accountability Affirmation

  • I am a human contributor. I personally reviewed this change and can explain every line.

@njeunje
njeunje marked this pull request as ready for review November 13, 2026 16:55
@njeunje
njeunje requested review from eewing314 and n3wth November 13, 2026 16:55
@njeunje

njeunje commented Nov 13, 2026

Copy link
Copy Markdown
Member Author

Hi @eewing314, @n3wth — opening this implementation PR stacked on #419 with all CI passing.

Suggested review focus:

  • @eewing314: Core skill protocol (skills/egm-lite/) and evaluation scenarios (test_scenarios.yaml).
  • @n3wth: Packaging (scripts/pack_plugin.py, tests) and Starlight site wiring (site/).

Thanks!

@njeunje njeunje added site Changes to the project website skills Changes to the skill(s) labels Nov 13, 2026
@njeunje njeunje self-assigned this Nov 13, 2026
n3wth
n3wth previously requested changes Nov 14, 2026

@n3wth n3wth left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The review phase can miss the implementation it is meant to audit. Please include untracked files and committed task changes in the reviewer input, as described in the inline comments. Packaging checks and the full offline suite pass with 385 tests and two native-probe skips.

Please keep this PR draft until the design PR merges and the aligned issue has pr-ready, as required by the contribution rules. The description calls this a draft, but GitHub marks it ready for review.

For the claimed behavioral evaluations, please record the host and version and link the results. The scenario coverage tests check structure, not live model behavior.

Comment thread skills/egm-lite/SKILL.md Resolved
Comment thread skills/egm-lite/SKILL.md Resolved
@njeunje

njeunje commented Nov 17, 2026

Copy link
Copy Markdown
Member Author

The 15 original scenarios were evaluated internally, on an internal copy of the skill with an internal evaluation tool, so I have no public host, version or link to record. The Verification section now marks a live run of this file as not run.

The PR is in draft and stays there until #419 merges and #460 has pr-ready.

@njeunje
njeunje requested a review from n3wth November 17, 2026 16:40
eewing314
eewing314 previously approved these changes Nov 17, 2026
@njeunje
njeunje marked this pull request as ready for review November 17, 2026 22:26
Base automatically changed from feat/add-egm-lite-skill to main November 17, 2026 23:31
Implements the /egm-lite rapid engineering protocol skill, behavioral evaluation benchmark, keyline assets, packaging manifests, and Starlight documentation in google/elephant-goldfish-model, implementing the design specified in #419 and #458.

- Skill Core (skills/egm-lite/):
  - Implements /egm-lite in skills/egm-lite/SKILL.md with Adaptive Gating (Sections 2A/2B and 5), skippable spec review, and state transition advisories.
  - Records review baseline before the first edit and inventories untracked and committed task changes.
  - Includes canonical 24x24 dual-facet keyline vector artwork (#465).
- Verification Suite:
  - Adds interactive protocol verification checklist in skills/egm-lite/TEST.md.
  - Implements 28 declarative behavioral evaluation scenarios in skills/egm-lite/test_scenarios.yaml.
- Packaging & Starlight Documentation:
  - Registers egm-lite in scripts/pack_plugin.py and updates test assertions.
  - Adds docs/site/skills/egm-lite.md and Starlight routing.

Co-authored-by: Oliver Newth <5912894+n3wth@users.noreply.github.com>
Closes #460
Closes #461
@njeunje
njeunje dismissed n3wth’s stale review November 17, 2026 23:51

Addressed in e45e0e4: review baseline capture and untracked file inventory included, 28 scenarios added, and branch cleanly rebased on main following PR #419 merge.

@njeunje
njeunje requested a review from eewing314 November 17, 2026 23:52
@eewing314
eewing314 merged commit 70406c4 into main Nov 18, 2026
21 checks passed
@eewing314
eewing314 deleted the feat/egm-lite-core branch November 18, 2026 01:40
@smituparmar01 smituparmar01 mentioned this pull request Nov 19, 2026
1 task done
Acrazie added a commit to Acrazie/elephant-goldfish-model that referenced this pull request Nov 20, 2026
* fix(review): save GoldfishContext URLs as files (google#289)

Co-authored-by: n3wth <5912894+n3wth@users.noreply.github.com>

* Propose the TRIZ inventive catalyst design specification (google#290)

Co-authored-by: Brian Suchy <briansuchy@google.com>

* docs(install): link the published desktop plugin (google#301)

* feat(agents): add the TRIZ inventive catalyst reviewer (google#299)

Co-authored-by: Brian Suchy <briansuchy@google.com>

* docs(site): propose the documentation architecture (google#304)

* docs(contributing): clarify the first contribution (google#330)

* docs(prs): simplify the pull request template (google#331)

* fix(plugin): separate publisher policy destinations (google#314)

* Configure Gemini Code Assist review threshold and styleguide (google#320)

* feat(plugin): update listing and prepare v0.1.1 (google#316)

* docs(plugin): define the listing presentation scope (google#305)

* feat(site): add documentation dependencies and primitives (google#306)

* Add displayName and logo to root plugin manifest (google#336)

Co-authored-by: Oliver Newth <n3wth@users.noreply.github.com>

* Route CODEOWNERS reviews through @google/egm-maintainers (google#340)

Co-authored-by: Brian Suchy <briansuchy@google.com>

* Harden pr-scope-advisory workflow for pull_request_target policy (google#341)

Co-authored-by: Brian Suchy <briansuchy@google.com>

* docs(readme): add the EGM explainer video (google#352)

* fix(site): preserve accessible names across screen sizes (google#357)

* fix(site): improve search metadata and favicon support (google#354)

* Bump PyYAML to 6.0.3 for Python 3.14 on Windows (google#339)

* fix(bootstrap): recognize more source file extensions (google#324)

* fix(packaging): reject non-string manifest references (google#296)

Co-authored-by: n3wth <5912894+n3wth@users.noreply.github.com>

* fix(tests): handle Windows cwd and blank output in Codex reads (google#297)

* Check the Copilot manifest version against plugin.json (google#311)

* Update stale reviewer profile count in Copilot entry agent (google#323)

* Fix casing in OpenCode reviewer prompt check (google#360)

* build(deps): bump actions/setup-python from 7.0.0 to 7.1.0 in the actions group across 1 directory (google#362)

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Fix the Claude marketplace plugin root for Cowork (google#347)

* Align brainstorm and review designs with shipped skills (google#343)

* Correct stale design statuses and bootstrap test instructions (google#348)

* build(deps-dev): bump pytest from 8.3.5 to 9.0.3 in the pip group across 1 directory (google#384)

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Load analytics where cookie consent is not required (google#381)

* Add a Cursor marketplace catalog descriptor (google#377)

* State pull request title, label, and harness evidence rules in AGENTS.md (google#392)

* Add VS Code workspace discovery for Copilot (google#378)

* Add a brownfield quickstart and clarify .gitignore guidance (google#374)

* Delete committed Claude runtime before release branch exists (google#393)

* Write website skill pages for readers (google#395)

* Add Stage-1 GitHub Actions PR triage review and gate CODEOWNERS (google#380)

Co-authored-by: Brian Suchy <briansuchy@google.com>

* docs(site): add guide and skill page copy (google#401)

* feat(site): render docs from Markdown exports (google#402)

* Harden Stage-1 PR triage with pull_request_target and deterministic pre-checks (google#413)

Co-authored-by: Brian Suchy <briansuchy@google.com>

* Fix egm-bootstrap .NET detection for egm-bootstrap/SKILL.md (google#409)

* docs(windsurf): design experimental support (google#407)

* docs(contributing): clarify stacked PR workflow (google#400)

* refactor(site): share analytics component (google#403)

* feat(site): reuse header and styles on docs pages (google#404)

* feat(site): replace homepage with concise example (google#396)

* Set timeouts on the tests, deploy, and release jobs (google#424)

* Add OpenSSF Scorecard workflow (google#425)

* Publish the provenance bundle with release assets (google#426)

* Lint Python and workflow files in CI (google#427)

* Derive Claude root source in packaging (google#394)

* Add the EGM explainer video to the homepage (google#431)

* Align the explainer section with the two-column page grid (google#432)

* Add experimental Windsurf (Devin Desktop) adapter (google#379)

* build(deps): bump astro from 7.4.5 to 7.4.12 in /site (google#440)

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Fix bare-mention neutralization bypass via stray fence backtick (google#439)

Signed-off-by: Siddhardha Nanda <sn3199@columbia.edu>

* docs(designs): propose EGM Lite rapid engineering protocol (Stage 1) (google#419)

Co-authored-by: n3wth <5912894+n3wth@users.noreply.github.com>

* Align Claude manifest author with Google LLC directory entries (google#466)

* feat(skills): implement EGM Lite rapid engineering protocol (Stage 2) (google#438)

Co-authored-by: Oliver Newth <5912894+n3wth@users.noreply.github.com>

* docs(designs): record approved upstream sync design for 70406c4

---------

Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: Siddhardha Nanda <sn3199@columbia.edu>
Co-authored-by: Aryan Atre <155140996+atrearyan@users.noreply.github.com>
Co-authored-by: n3wth <5912894+n3wth@users.noreply.github.com>
Co-authored-by: briansuchy <suchybrian@gmail.com>
Co-authored-by: Brian Suchy <briansuchy@google.com>
Co-authored-by: Oliver Newth <n3wth@users.noreply.github.com>
Co-authored-by: Yahya Sherif <120673276+Yahiasherif002@users.noreply.github.com>
Co-authored-by: Rishab Dugar Jain <rishabdugar.jain@gmail.com>
Co-authored-by: Vishal Kannankara <kvishalv@gmail.com>
Co-authored-by: wonseok-u <spark142857@gmail.com>
Co-authored-by: Rup Sarmah <84681565+sarmah-rup@users.noreply.github.com>
Co-authored-by: Akshat <akshat21shukla@gmail.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: mathewgeejo <mathewgeejo2006@gmail.com>
Co-authored-by: casali10 <63318448+casali10@users.noreply.github.com>
Co-authored-by: fouad <fouadsaidy@gmail.com>
Co-authored-by: Siddhardha Nanda <99672439+SID-6921@users.noreply.github.com>
Co-authored-by: Jonathan Njeunje <38731927+njeunje@users.noreply.github.com>
Co-authored-by: Acrazie <acrazie@acrazies-macbook-pro.home>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

site Changes to the project website skills Changes to the skill(s)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add Adaptive Gating to EGM Lite Add EGM Lite, a lightweight protocol for small changes

3 participants