Skip to content

Fix equirectangular typo in generate_spherical_xml default#339

Open
Hashim1999164 wants to merge 1 commit into
google:masterfrom
Hashim1999164:fix/equirectangular-typo
Open

Fix equirectangular typo in generate_spherical_xml default#339
Hashim1999164 wants to merge 1 commit into
google:masterfrom
Hashim1999164:fix/equirectangular-typo

Conversation

@Hashim1999164

@Hashim1999164 Hashim1999164 commented Jul 27, 2026

Copy link
Copy Markdown

Summary

  • Corrects the default projection value in generate_spherical_xml from equiretangular to equirectangular.
  • Without this, callers that omit projection (GUI and docker paths) fail the equality check and inject non-spherical metadata.
  • Adds unit tests covering the default and none projection paths.

Fixes #336

Test plan

  • python3 -m unittest spatialmedia_test.TestGenerateSphericalXml -v
  • Confirm GUI/docker inject paths now emit equirectangular spherical XML by default

The default projection was misspelled as equiretangular, so callers that omit projection (GUI and docker) never matched equirectangular and injected non-spherical metadata. Fixes google#336.
@google-cla

google-cla Bot commented Jul 27, 2026

Copy link
Copy Markdown

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Typo in metadata_utils.generate_spherical_xml signature (equiretangular)

1 participant