Skip to content

Fix equirectangular typo in generate_spherical_xml default #339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jamiesonpepper merged 1 commit into from
Jul 27, 2026
+13 −1
Merged

Fix equirectangular typo in generate_spherical_xml default #339

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion spatialmedia/metadata_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -540,7 +540,7 @@ def inject_metadata(src, dest, metadata, console):
console("Unknown file type")


def generate_spherical_xml(projection="equiretangular", stereo=None, crop=None):
def generate_spherical_xml(projection="equirectangular", stereo=None, crop=None):
# Configure inject xml.
additional_xml = ""
if stereo == "top-bottom":
Expand Down
12 changes: 12 additions & 0 deletions spatialmedia_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,6 +151,18 @@ def test_inject_v2_rectangular_top_bottom(self):
self.assertTrue(contents.find('Stereo Mode: 1') >= 0)


class TestGenerateSphericalXml(unittest.TestCase):
def test_default_projection_is_equirectangular(self):
"""Default projection must match the equirectangular comparison string."""
xml = metadata_utils.generate_spherical_xml()
self.assertIn('equirectangular', xml)
self.assertIn('<GSpherical:Spherical>true</GSpherical:Spherical>', xml)

def test_none_projection_is_not_spherical(self):
xml = metadata_utils.generate_spherical_xml(projection='none')
self.assertNotIn('equirectangular', xml)
self.assertIn('<GSpherical:Spherical>false</GSpherical:Spherical>', xml)

if __name__ == '__main__':
try:
os.mkdir('test_output')
Expand Down