Skip to content

chore: address linter errors and explicitly discard errors and leverage propper methods and field names - #170

Merged
nodyhub merged 1 commit into
mainfrom
chore/fix-linter
Oct 26, 2026
Merged

nodyhub merged 1 commit into
mainfrom
chore/fix-linter

Conversation

@nodyhub

@nodyhub nodyhub commented Oct 26, 2026 •

Copy link
Copy Markdown
Collaborator

To follow up on latest dependency updates, we need to ensure that our test verifies code quality. This PR addresses mainly linter errors.

PCI review checklist

  • If applicable, I’ve documented a plan to revert these changes if they require more than reverting the pull request.

  • If applicable, I’ve worked with GRC to document the impact of any changes to security controls.

    Examples of changes to controls include access controls, encryption, logging, etc.

  • If applicable, I’ve worked with GRC to ensure compliance due to a significant change to the cardholder data environment.

    Examples include changes to operating systems, ports, protocols, services, cryptography-related components, PII processing code, etc.

If you have any questions, please contact your direct supervisor, GRC (#team-grc), or the PCI working group (#proj-pci-core). You can also find more information at PCI Compliance.

@nodyhub
nodyhub requested a review from a team as a code owner October 26, 2026 10:31
@hashicorp-cla-app

Copy link
Copy Markdown

CLA assistant check

Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement

Learn more about why HashiCorp requires a CLA and what the CLA includes


NodyHub seems not to be a GitHub user.
You need a GitHub account to be able to sign the CLA.
If you have already a GitHub account, please add the email address used for this commit to your account.

Have you signed the CLA already but the status is still pending? Recheck it.

1 similar comment
@hashicorp-cla-app

Copy link
Copy Markdown

CLA assistant check

Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement

Learn more about why HashiCorp requires a CLA and what the CLA includes


NodyHub seems not to be a GitHub user.
You need a GitHub account to be able to sign the CLA.
If you have already a GitHub account, please add the email address used for this commit to your account.

Have you signed the CLA already but the status is still pending? Recheck it.

@nodyhub
nodyhub merged commit b26bdff into main Oct 26, 2026
9 of 10 checks passed
@nodyhub
nodyhub deleted the chore/fix-linter branch October 26, 2026 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants