chore: address linter errors and explicitly discard errors and leverage propper methods and field names

7zip.go

@@ -46,8 +46,8 @@ func unpack7Zip(ctx context.Context, t Target, dst string, src io.Reader, cfg *C
 	}
 	defer func() {
 		if f, ok := sra.(*os.File); ok {
-			f.Close()
-			os.Remove(f.Name())
+			_ = f.Close()
+			_ = os.Remove(f.Name())
 		}
 	}()
 
@@ -131,7 +131,7 @@ func (z *sevenZipEntry) Linkname() string {
 	if err != nil {
 		return ""
 	}
-	defer f.Close()
+	defer func() { _ = f.Close() }()
 	c, err := io.ReadAll(f)
 	if err != nil {
 		return ""

cmd/run.go

@@ -114,7 +114,7 @@ func Run(version, commit, date string) {
 			logger.Error("opening archive failed", "err", err)
 			os.Exit(-1)
 		} else {
-			defer archive.(*os.File).Close()
+			defer func() { _ = archive.(*os.File).Close() }()
 		}
 	}
 

decompress.go

@@ -38,7 +38,7 @@ func decompress(ctx context.Context, t Target, dst string, src io.Reader, cfg *C
 	}
 	defer func() {
 		if closer, ok := decompressedStream.(io.Closer); ok {
-			closer.Close()
+			_ = closer.Close()
 		}
 	}()
 	// check if context is canceled

extractor.go

@@ -89,7 +89,7 @@ func (e extractors) GetUnpackFunctionByFileName(name string) unpackFunc {
 	ext := strings.ToLower(name)
 	if strings.Contains(ext, ".") {
 		ext = filepath.Ext(ext)
-		ext = strings.Replace(ext, ".", "", -1) // remove leading dot if the file extension is the only part of the file name (e.g. ".tar")
+		ext = strings.ReplaceAll(ext, ".", "") // remove leading dot if the file extension is the only part of the file name (e.g. ".tar")
 	}
 
 	if ae, found := e[ext]; found {
@@ -363,7 +363,7 @@ func extract(ctx context.Context, t Target, dst string, src archiveWalker, cfg *
 					if err != nil {
 						return handleError(cfg, td, "failed to open file", err), false
 					}
-					defer fin.Close()
+					defer func() { _ = fin.Close() }()
 
 					// create file
 					n, err := createFile(t, dst, ae.Name(), fin, ae.Mode(), cfg.MaxExtractionSize()-extractionSize, cfg)
@@ -520,13 +520,13 @@ func readerToReaderAtSeeker(c *Config, r io.Reader) (seekerReaderAt, error) {
 
 	// copy reader to temp file
 	if _, err := io.Copy(tmpFile, ler); err != nil {
-		defer os.Remove(tmpFile.Name())
+		defer func() { _ = os.Remove(tmpFile.Name()) }()
 		return nil, fmt.Errorf("cannot copy reader to file: %w", err)
 	}
 
 	// seek to start
 	if _, err := tmpFile.Seek(0, io.SeekStart); err != nil {
-		defer os.Remove(tmpFile.Name())
+		defer func() { _ = os.Remove(tmpFile.Name()) }()
 		return nil, err
 	}
 

rar.go

@@ -54,7 +54,7 @@ func processRar(ctx context.Context, t Target, dst string, src io.Reader, cfg *C
 		if err != nil {
 			return handleError(cfg, td, "cannot create rar decoder", err)
 		}
-		defer a.Close()
+		defer func() { _ = a.Close() }()
 		return extract(ctx, t, dst, &rarWalker{&a.Reader}, cfg, td)
 	}
 

target_disk.go

@@ -60,7 +60,7 @@ func (d *TargetDisk) CreateFile(path string, src io.Reader, mode fs.FileMode, ov
 		return 0, fmt.Errorf("failed to create file: %w", err)
 	}
 	defer func() {
-		dstFile.Close()
+		_ = dstFile.Close()
 	}()
 
 	// write data to file

target_memory.go

@@ -667,7 +667,7 @@ func (m *TargetMemory) ReadFile(path string) ([]byte, error) {
 	if err != nil {
 		return nil, &fs.PathError{Op: "ReadFile", Path: path, Err: fs.ErrNotExist}
 	}
-	defer f.Close()
+	defer func() { _ = f.Close() }()
 
 	// check if it is a directory
 	stat, err := f.Stat()

target_memory_test.go

@@ -40,7 +40,7 @@ func TestMemoryOpen(t *testing.T) {
 	if err != nil {
 		t.Fatalf("Open() failed: %s", err)
 	}
-	defer f.Close()
+	defer func() { _ = f.Close() }()
 
 	// check the file permissions
 	stat, err := f.Stat()
@@ -87,7 +87,7 @@ func TestMemoryOpen(t *testing.T) {
 	if err != nil {
 		t.Fatalf("Open() failed: %s", err)
 	}
-	defer f.Close()
+	defer func() { _ = f.Close() }()
 
 	// read content of the symlink
 	data, err = io.ReadAll(f)
@@ -201,7 +201,7 @@ func TestMemoryOpen2(t *testing.T) {
 	if err != nil {
 		t.Fatalf("Open() failed: %s", err)
 	}
-	defer f.Close()
+	defer func() { _ = f.Close() }()
 
 	// read the file
 	data, err := io.ReadAll(f)
@@ -868,7 +868,7 @@ func TestUnpackToMemoryWithPreserveFileAttributesAndOwner(t *testing.T) {
 				if err != nil {
 					t.Fatalf("error getting file stats: %v", err)
 				}
-				if !(c.Mode&fs.ModeSymlink != 0) { // skip symlink checks
+				if c.Mode&fs.ModeSymlink == 0 { // skip symlink checks
 					if stat.Mode().Perm() != c.Mode.Perm() {
 						t.Fatalf("expected file mode %v, got %v, file %s", c.Mode.Perm(), stat.Mode().Perm(), path)
 					}

unpack_test.go

@@ -1211,7 +1211,7 @@ func TestUnsupportedArchiveNames(t *testing.T) {
 			if err != nil {
 				t.Fatalf("error opening file: %s", err)
 			}
-			defer src.Close()
+			defer func() { _ = src.Close() }()
 			if err := extract.Unpack(ctx, tmpDir, src, extract.NewConfig()); err != nil {
 				t.Fatalf("error unpacking file: %s", err)
 			}
@@ -1727,7 +1727,7 @@ func asIoReader(t *testing.T, b []byte) io.Reader {
 	t.Helper()
 	r, w := io.Pipe()
 	go func() {
-		defer w.Close()
+		defer func() { _ = w.Close() }()
 		if _, err := w.Write(b); err != nil {
 			t.Logf("error writing data to pipe: %v", err)
 			t.Fail()

unpack_unix_test.go

@@ -35,7 +35,7 @@ func TestUnpackWithPreserveFileAttributes(t *testing.T) {
 				if err != nil {
 					t.Fatalf("error getting file stats: %v", err)
 				}
-				if !(c.Mode&fs.ModeSymlink != 0) { // skip symlink checks
+				if c.Mode&fs.ModeSymlink == 0 { // skip symlink checks
 					if stat.Mode().Perm() != c.Mode.Perm() {
 						t.Fatalf("expected file mode %v, got %v, file %s", c.Mode.Perm(), stat.Mode().Perm(), c.Name)
 					}

zip.go

@@ -46,8 +46,8 @@ func unpackZip(ctx context.Context, t Target, dst string, src io.Reader, c *Conf
 	}
 	defer func() {
 		if f, ok := src.(*os.File); ok {
-			f.Close()
-			os.Remove(f.Name())
+			_ = f.Close()
+			_ = os.Remove(f.Name())
 		}
 	}()
 
@@ -110,23 +110,23 @@ type zipEntry struct {
 
 // Name returns the name of the entry
 func (z *zipEntry) Name() string {
-	return z.zf.FileHeader.Name
+	return z.zf.Name
 }
 
 // Size returns the size of the entry
 func (z *zipEntry) Size() int64 {
-	return int64(z.zf.FileHeader.UncompressedSize64)
+	return int64(z.zf.UncompressedSize64)
 }
 
 // Mode returns the mode of the entry
 func (z *zipEntry) Mode() os.FileMode {
-	return z.zf.FileHeader.Mode()
+	return z.zf.Mode()
 }
 
 // Linkname returns the linkname of the entry
 func (z *zipEntry) Linkname() string {
 	rc, _ := z.zf.Open()
-	defer func() { rc.Close() }()
+	defer func() { _ = rc.Close() }()
 	data, _ := io.ReadAll(rc)
 	return string(data)
 }