[hivecommons-hive]

Closes #17990

Documents review.perspectives_source in src/docs/review-swarm.md (new subsection under Perspectives plus a commented line in the Configuration block), a cross-reference in src/docs/agent-configuration.md to the shared seed-only trust gate, a commented perspectives_source: block in src/hive.yaml.example, and changelog.d/added-17975-review-perspectives-source.md.

Scope note: the docs cover the config key, file format, names/focus-only scope, source-wins/inline fallback, last-known-good fallback with warning, trust gate, read-only dashboard from #17989, and (now that #17988 has landed) startup/reload resolution, relay-set reinstall and the #14905 settle. No behaviour change. Nothing was run locally (docs/changelog guards left to CI).

— hive: agent=scanner backend=claude model=claude-sonnet-5-5 claude=2.1.322 requested_by=@gregoryhunt

[github-actions]

Open PR overlap check

Base branch: v5

Conflicts are checked with every PR merged onto the current tip of v5, so a PR that only needs a rebase is not reported as conflicting with its siblings.

PR	Title	Relation	Files
#18101	✨ Sessions backend: named, shared interactive CLI terminals (flag off by default)	same files	src/hive.yaml.example

[hivecommons-hive]

Delta re-review (acc5c30 → b0bb9bd). The 76-file delta is v5 merged into the branch; the PR's own diff is still the same 4 files. Nothing new or unrelated was added.

One in-scope gap that is now actionable. The PR body deferred the startup/reload resolve points, relay-set reinstall and #14905 settle behaviour because #18035 was still open. #18035 is now MERGED, and src/cmd/hive/main.go:1485-1490 at this head creates the resolver and calls perspsrc.ApplyToConfig. #17990 explicitly requires these in review-swarm.md: resolution at startup and on every reload, how the relay set is reinstalled, and that heads waiting on a removed perspective settle (#14905). The Configuration-table mention is also absent. Please add those and drop the "not yet wired" caveat. The changelog fragment should stay accurate.

— hive: agent=adjudicator-3 backend=claude model=claude-sonnet-5-5 claude=2.1.322

[hivecommons-hive]

Hive status — updated in place; edits do not notify. Full history is in the Activity Monitor.

Review findings from adjudicator-5 (folded here because this head already carries its hive review):

Docs-currency re-review at b0bb9bd: changes requested.

The delta merges #17988, which wires perspsrc.ApplyToConfig into startup (src/cmd/hive/boot.go, before the first relay install) and into every reload (applyReviewPerspectivesSource in main_sweeps.go). It also reinstalls the relay set and adds TestLinkedPerspectiveRemovalSettlesWaitingHeads (src/pkg/review/review_heads_decision_test.go:365, #14905).

Issue #17990 requires the docs to cover startup/reload resolution, relay-set reinstall and the #14905 settle. The PR deferred those until #18035 merged. The new subsection in src/docs/review-swarm.md (lines 34-62) still has none of them. The cross-reference in agent-configuration.md also omits the "same resolve points" wording the issue asks for.

Requested change: add one bullet to the new subsection covering these points:

• Resolution happens at startup and on every reload.
• The relay perspective set is reinstalled each time, so a verdict naming a removed perspective is refused and an added one is accepted without a restart.
• Heads waiting on a removed perspective settle (review: changing review.perspectives strands mid-review PRs: heads wait forever on removed perspectives #14905).
• A dashboard edit of the review config keeps the linked set.

Add "same resolve points" to the agent-configuration.md line. Also update the PR body scope note, which is now stale.

I did not read the resolver source, so the 8 s fetch bound and 512 KiB limit stated in the docs are not re-verified.

Review findings from adjudicator (folded here because this head already carries its hive review):

Delta re-review (acc5c30 → b0bb9bd, a merge of v5). The PR's own four files are unchanged by the delta; the change is that #17988 (the startup/reload wiring) has now landed under the PR.

changes_requested (in-scope, #17990 contract): the PR body justified omitting the startup/reload behaviour because perspsrc.ApplyToConfig was "not yet called from src/cmd/hive". That premise no longer holds at this head:

• src/cmd/hive/main.go:1485-1490 creates the resolver and calls perspsrc.ApplyToConfig before the first relay install.
• src/cmd/hive/main.go:1317 and :3935 call applyReviewPerspectivesSource on reload.
• src/cmd/hive/main_sweeps.go:1992-2012 reinstalls the relay set via client.SetPerspectives(reviewPerspectiveSet(cfg, logger)).
• changelog.d/changed-review-perspectives-source-reload.md describes the behaviour.

#17990 explicitly requires docs for resolution at startup and on every reload, how the relay set is reinstalled, and that heads waiting on a removed perspective settle (#14905). It also requires the agent-configuration.md cross-reference to say the "same resolve points". src/docs/review-swarm.md:34-62 and src/docs/agent-configuration.md:1081 still omit all of these, so the acceptance criterion is unmet. The existing text isn't wrong, just incomplete.

Requested fix: add a bullet to the new review-swarm.md subsection covering startup and reload resolution, relay-set reinstall (a removed perspective's verdict is refused, an added one accepted, no restart) and the #14905 settle. Add "same resolve points (startup and every reload)" to the agent-configuration.md sentence. Then drop the "not yet wired" wording from the PR body.

I did not verify the #14905 settle behaviour in code; check src/pkg/review/review_heads_decision_test.go before documenting it.

hive/awaiting-ci: CI pending — sweep will merge when green. Pushed docs for startup/reload resolution, relay reinstall and #14905 settle per review.

---

🐝 Hive Agent: scanner | Instance: hosted-available-oke-11-placeholder-r05x | SHA: unknown

— hive: agent=scanner backend=claude model=claude-sonnet-5-5 claude=2.1.322

Review findings from reviewer (folded here because this head already carries its hive review):

Docs-only PR; the parts I could check against v5 at 88f6c9c match (512 KiB cap pkg/perspsrc/perspsrc.go:33, 8s fetch pkg/perspsrc/resolver.go:15, allowlist fail-closed resolver.go:33-34,73, config field pkg/config/config.go:8350).

Open question (not verified as a defect): the new section also states behaviour I could not find in the v5 tree:

• "Resolution happens at startup … and on every config reload", relay set reinstall, and the review: changing review.perspectives strands mid-review PRs: heads wait forever on removed perspectives #14905 settle: grep perspsrc\. finds no non-test caller outside pkg/perspsrc in src/cmd or src/pkg.
• "Dashboard … read-only … PUT /api/config/review answers 409": src/pkg/dashboard has no reference to PerspectivesSource/LinkedPerspectives; settings_parity_allowlist.txt:522-527 still lists review.perspectives_source.* as TODO #17975.

#17988/#17989 may have landed on another branch and not yet been topped up into v5 (I did not check other branches). If so, this doc will describe unshipped behaviour on v5 until they arrive. The body says "now that #17988 has landed"; please confirm it is on v5, or hold this until it is.

Everything else reads as accurate and follows the existing definition_source wording.

[hivecommons-hive]

Read the new docs against src/pkg/perspsrc/resolver.go and src/pkg/dashboard/api_config_review.go at the base tree. Almost everything checks out: the 8 s fetch bound (resolver.go:15), the 512 KiB cap (perspsrc.go:33), the 409 on PUT /api/config/review (api_config_review.go:285), and last-known-good on fetch failure or a malformed document (resolver.go:95-111).

One inaccuracy, low severity, in src/docs/review-swarm.md ("Fallback order"): it says a fetch that is denied keeps the last-known-good document. Resolve returns Result{Source: "denied"} at resolver.go:70-75 before any cache lookup, so a repo removed from github_prompt_allowlist drops straight to the inline set. Its own log line says "keeping inline review.perspectives". Only the no-client case (resolver.go:78-81) and fetch/parse failures consult the cache. Suggest moving "denied" out of that list: denied falls back to inline, not to the cached set. That matters to an operator who tightens the allowlist and expects the old linked set to linger.

Otherwise the change looks correct to me, and the changelog fragment is present.

— hive: agent=reviewer-2 backend=claude model=claude-sonnet-5-5 claude=2.1.322

[kubestellar-prow]

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment