fix(app): copy correct session URL on first Share Session click

[dewly-justice]

Summary

Fixes #2313.

On the Client Sessions page, clicking Share Session immediately after opening a session copied the previous URL (without sid/sfrom/sto). A reload was required for the button to copy the correct link.

Root cause: CopyToClipboard captured window.location.href into its text prop at render time. nuqs (setSelectedSessionQuery in SessionsPage.tsx:322) updates React state synchronously but flushes window.history asynchronously (batched via startTransition + throttleMs). SessionSidePanel rendered before the flush and froze the stale URL into the prop. After reload the URL already contained the params on initial render, which is why the bug "disappeared."

Fix: Replace CopyToClipboard with a plain onClick handler that reads window.location.href at click time — by then nuqs has flushed. Reuse the shared copyTextToClipboard util from packages/app/src/utils/clipboard.ts so we get the non-HTTPS <textarea> fallback and explicit error reporting for free.

Screenshots or video

Non-visual behavioral fix; no UI changes.

Before	After
First click after opening a session copies URL without sid/sfrom/sto	First click copies the full session URL

How to test on Vercel preview

Preview routes: /sessions

Steps:

1. Open /sessions and ensure at least one session card is visible (use the demo data).
2. Click any session card to open the side panel. The URL bar should update to include &sid=...&sfrom=...&sto=....
3. Click Share Session in the side panel header.
4. Paste the clipboard contents into the address bar or a text field.
5. Verify the pasted URL contains sid, sfrom, and sto query params on the first click (no reload needed).

References

• Issue: Share Session button copies stale URL on first click (missing sid/sfrom/sto) #2313

[vercel]

@dewly-justice is attempting to deploy a commit to the HyperDX Team on Vercel.

A member of the Team first needs to authorize it.

[changeset-bot]

🦋 Changeset detected

Latest commit: eeaa869

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages

Name	Type
@hyperdx/app	Patch
@hyperdx/api	Patch
@hyperdx/otel-collector	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[github-actions]

Deep Review

✅ No critical issues found. The fix correctly moves URL capture from render time to click time, the new tests directly exercise that contract, and the dependency is preserved (still used elsewhere). Remaining notes below are advisory.

🔵 P3 nitpicks (3)

• packages/app/src/SessionSidePanel.tsx:137 — Reading window.location.href at click time narrows but does not close the nuqs throttle window (default ~50ms), so a click landing within that window after panel open can still read a stale URL.
  • Fix: Construct the share URL from the same React state nuqs reads (sessionId + sfrom/sto from dateRange) rather than from window.location.href.
  • _{julik-frontend-races}
• packages/app/src/SessionSidePanel.tsx:136 — Button has no re-entry guard while the awaited copy is in flight; rapid double-click fires two copyTextToClipboard calls and two notifications. Pre-existing in spirit (the prior CopyToClipboard wrapper was also unguarded), but the await-based flow makes it slightly more observable.
  • Fix: Disable the button or set a local isCopying ref while the promise is pending.
  • _{julik-frontend-races, correctness}
• packages/app/src/__tests__/SessionSidePanel.test.tsx:52 — Three as any casts on prop fixtures (traceSource, sessionSource, session) deviate from the documented "avoid as casts" code-style guidance, though the pattern is consistent with other test files in packages/app/src/__tests__/.
  • Fix: Narrow the fixtures with satisfies Partial<TTraceSource>/Partial<TSessionSource> or pull in a typed fixture helper.

---

Reviewers (6): correctness, testing, maintainability, kieran-typescript, julik-frontend-races, project-standards.

Testing gaps:

• No test exercises a click landing inside the nuqs throttle window immediately after panel open — the exact race scenario the PR claims to fix is only approximated by manually mutating window.location between render and click.
• No test covers rapid double-click behavior on Share Session.
• Error-path test asserts that the red notification fires but does not explicitly assert the green notification did not (expect(mockedShow).not.toHaveBeenCalledWith({color: 'green', ...})).

[pulpdrew]

LGTM, thanks for the fix