Repository navigation
Reuse delete_stale_attachments command - #348
Merged
Merged
Conversation
kiwitcms-bot
force-pushed
the
refactor-stale-attachments
branch
4 times, most recently
from
October 5, 2026 12:30
1f12eff to
2622664
Compare
kiwitcms-bot
force-pushed
the
refactor-stale-attachments
branch
from
October 5, 2026 12:32
2622664 to
77484ed
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor
remove_stale_tenant_attachmentsso it inherits fromattachments.management.commands.delete_stale_attachments.Command(django-attachments) and delegates the removal of attachments whose related object is gone tosuper().handle(), once per tenant.handle()only adds the multi-tenant loop plus two tenant-specific extras:--dry-run:answeris forced tonbefore looping, so the upstream command reports each match without deleting.--check-storage: not supported upstream, so the extra pass over attachments whose file is missing is done here.The
-y/--yesoption comes from upstream; a new dry-run test is added, and the empty-object_idfixtures/assertions are dropped since that case is no longer special-cased.tcms_tenants/tests/test_remove_stale_tenant_attachments.pypasses.