fix: escape Rust keyword field/oneof names in generated accessors#14
Closed
connyay wants to merge 1 commit into
Closed
fix: escape Rust keyword field/oneof names in generated accessors#14connyay wants to merge 1 commit into
connyay wants to merge 1 commit into
Conversation
The plugin built field accessors (`self.<field>`) straight from raw proto names, so any field or oneof named with a Rust keyword broke codegen: `format_ident!` emitted invalid `self.type`, `parse_str::<Ident>` returned `Err`, and `Ident::new`/`new_raw` panicked on non-raw-able keywords like `self`. buffa names the underlying struct fields via `make_field_ident` (`type` -> `r#type`, `self` -> `self_`), so the accessors never lined up. Route every proto-name -> ident site through a shared `field_ident` helper that delegates to `buffa_codegen::idents::make_field_ident`, guaranteeing the emitted accessors match buffa's generated structs by construction. Covers the field-CEL, predefined-rule, CEL field-select, oneof, and message-`oneof` paths, and replaces the incomplete local `safe_ident` (which panicked on `self`/`super`/`Self`/`crate`). Add tests/keyword_idents.rs exercising the real emit::render pipeline for keyword-named fields and oneofs.
Contributor
|
Fixed in #17. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The plugin built field accessors (
self.<field>) straight from raw proto names, so any field or oneof named with a Rust keyword broke codegen:format_ident!emitted invalidself.type,parse_str::<Ident>returnedErr, andIdent::new/new_rawpanicked on non-raw-able keywords likeself. buffa names the underlying struct fields viamake_field_ident(type->r#type,self->self_), so the accessors never lined up.Route every proto-name -> ident site through a shared
field_identhelper that delegates tobuffa_codegen::idents::make_field_ident, guaranteeing the emitted accessors match buffa's generated structs by construction. Covers the field-CEL, predefined-rule, CEL field-select, oneof, and message-oneofpaths, and replaces the incomplete localsafe_ident(which panicked onself/super/Self/crate).Add tests/keyword_idents.rs exercising the real emit::render pipeline for keyword-named fields and oneofs.