fix!: consolidate keyword, connectrpc, and buffa fixes#17
Merged
Conversation
The plugin built field accessors (`self.<field>`) straight from raw proto names, so any field or oneof named with a Rust keyword broke codegen: `format_ident!` emitted invalid `self.type`, `parse_str::<Ident>` returned `Err`, and `Ident::new`/`new_raw` panicked on non-raw-able keywords like `self`. Route every proto-name to ident site through a shared `field_ident` helper that delegates to `buffa_codegen::idents::make_field_ident`, guaranteeing emitted accessors match buffa-generated structs by construction. Add keyword-name regression tests for the real emit::render pipeline.
The optional connect integration only needs ConnectError/ErrorCode, so opt out of connectrpc defaults to avoid pulling streaming and compression dependencies when the feature is enabled.
Update buffa, buffa-build, and buffa-codegen dependencies to the 0.7 line across the workspace. Move connectrpc to 0.7 as part of the bump so its transitive buffa dependency also resolves to 0.7 while keeping default features disabled.
This was referenced Jun 28, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Supersedes #14, #15, and #16.
Verification
Full workspace tests still require protoc on PATH for protovalidate-buffa-protos build scripts.