fix: disable connectrpc default features; bump lock to 0.6.1#15
Closed
connyay wants to merge 1 commit into
Closed
Conversation
protovalidate-buffa only uses connectrpc's ConnectError/ErrorCode types (src/connect.rs), but declared the dep with default features on. Those defaults are gzip + zstd + streaming, and because the `connect` feature is on by default and Cargo unifies features additively across the graph, every downstream consumer was forced to build zstd — whose C bindings don't compile on wasm32-unknown-unknown — regardless of their own `default-features = false`. Set `default-features = false` here so the crate requests only what it uses. Also bump Cargo.lock from connectrpc 0.6.0 to 0.6.1. 0.6.0 fails to compile (ClientTransport::send trait returns Result while the impl returns BoxFuture, E0053); 0.6.1 fixes the trait signature. The existing `version = "0.6"` spec already permitted it.
Contributor
|
Fixed in #17. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
protovalidate-buffa only uses connectrpc's ConnectError/ErrorCode types (src/connect.rs), but declared the dep with default features on. Those defaults are gzip + zstd + streaming, and because the
connectfeature is on by default and Cargo unifies features additively across the graph, every downstream consumer was forced to build zstd — whose C bindings don't compile on wasm32-unknown-unknown — regardless of their owndefault-features = false. Setdefault-features = falsehere so the crate requests only what it uses.Also bump Cargo.lock from connectrpc 0.6.0 to 0.6.1. 0.6.0 fails to compile (ClientTransport::send trait returns Result while the impl returns BoxFuture, E0053); 0.6.1 fixes the trait signature. The existing
version = "0.6"spec already permitted it.