Align Guacamole Windows VM image schema/defaults with supported image options#4970
Merged
Merged
Conversation
Copilot
AI
changed the title
[WIP] Fix installation failure for Data Science VM images
Align Guacamole Windows VM image schema/defaults with supported image options
Jul 14, 2026
jonnyry
self-requested a review
July 14, 2026 18:35
jonnyry
approved these changes
Jul 14, 2026
marrobi
approved these changes
Jul 14, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes Guacamole Windows user-resource deployment failures caused by mismatched os_image schema values/defaults versus the custom.image_options keys used by the Porter bundles, ensuring image selection maps to a valid option.
Changes:
- Align
os_image.enumvalues in the Windows VM and import/export review VMtemplate_schema.jsonfiles to match the Porter bundlecustom.image_optionskeys (now usingWindows Server 2025instead of removed DSVM keys). - Update stale
os_imagedefaults in the import/export review VMporter.yamlbundles toWindows Server 2025. - Bump bundle versions and add an unreleased
CHANGELOG.mdbug-fix entry documenting the correction.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| templates/workspace_services/guacamole/user_resources/guacamole-azure-windowsvm/template_schema.json | Updates os_image enum to remove unsupported DSVM entries and keep schema aligned with bundle image options. |
| templates/workspace_services/guacamole/user_resources/guacamole-azure-windowsvm/porter.yaml | Bumps bundle version and updates description to reflect current supported Windows Server image. |
| templates/workspace_services/guacamole/user_resources/guacamole-azure-import-reviewvm/template_schema.json | Aligns os_image enum to the supported image option key. |
| templates/workspace_services/guacamole/user_resources/guacamole-azure-import-reviewvm/porter.yaml | Bumps version and updates os_image default to a supported key. |
| templates/workspace_services/guacamole/user_resources/guacamole-azure-export-reviewvm/template_schema.json | Aligns os_image enum to the supported image option key. |
| templates/workspace_services/guacamole/user_resources/guacamole-azure-export-reviewvm/porter.yaml | Bumps version and updates os_image default to a supported key. |
| CHANGELOG.md | Adds an unreleased bug-fix entry documenting the image selection/schema/default alignment fix. |
marrobi
marked this pull request as ready for review
July 14, 2026 18:50
Member
|
/test-force-approve 2cbb294 |
|
🤖 pr-bot 🤖 ✅ Marking tests as complete (for commit 2cbb294) (in response to this comment from @marrobi) |
rudolphjacksonm
enabled auto-merge (squash)
July 14, 2026 18:53
Collaborator
|
/test-force-approve |
|
🤖 pr-bot 🤖 ✅ Marking tests as complete (for commit 2cbb294) (in response to this comment from @rudolphjacksonm) |
Unit Test Results0 tests 0 ✅ 0s ⏱️ Results for commit 2cbb294. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is being addressed
Guacamole Windows user-resource installs can fail with
The given key does not identify an element in this collection value.whenos_imagevalues fromtemplate_schema.jsondo not exist inporter.yamlcustom.image_options.This affected the Windows VM template and the Windows-based import/export review VM templates.
How is this addressed
Schema/Image key alignment
os_image.enumvalues to match actualcustom.image_optionskeys in:guacamole-azure-windowsvm/template_schema.jsonguacamole-azure-import-reviewvm/template_schema.jsonguacamole-azure-export-reviewvm/template_schema.jsonDefault value alignment
os_imagedefaults in review VM bundles to a supported key:guacamole-azure-import-reviewvm/porter.yamlguacamole-azure-export-reviewvm/porter.yamlTemplate versioning + metadata
tre-service-guacamole-windowsvm:1.4.5→1.4.6tre-service-guacamole-import-reviewvm:0.4.5→0.4.6tre-service-guacamole-export-reviewvm:0.3.6→0.3.7Documentation/release notes
CHANGELOG.mdbug-fix entry for image selection alignment across Windows/review VM templates.