Skip to content

Rename AppSource UI text to Marketplace - #9953

Open
Steffen Balslev (SBalslev) wants to merge 2 commits into
mainfrom
sbalslev-port-marketplace-rename
Open

Rename AppSource UI text to Marketplace#9953
Steffen Balslev (SBalslev) wants to merge 2 commits into
mainfrom
sbalslev-port-marketplace-rename

Conversation

@SBalslev

@SBalslev Steffen Balslev (SBalslev) commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Port AppSource-to-Marketplace UI text changes from Dynamics SMB NAV PR 238736 to BCApps.
  • Update additional user-facing captions, tooltips, labels, instructional text, and visible metadata found during the scan.
  • Keep technical identifiers, object names, URL constants, and AppSourceCop/config references unchanged where they are implementation details.

Reference

  • AB#617940: Rename AppSource to Marketplace in the UI
  • Bug 617940: Rename AppSource to Marketplace in the UI

Validation

  • git diff --check

Port the NAV AppSource-to-Marketplace UI text rename to BCApps and update additional user-facing captions, tooltips, labels, and visible metadata found during the scan.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@SBalslev
Steffen Balslev (SBalslev) requested review from a team August 4, 2026 13:59
@github-actions github-actions Bot added AL: System Application AL: Apps (W1) Add-on apps for W1 Other GitHub request for other area than SCM, Finance or Integration Ownership: Needs Review Ownership is Other, low confidence, or needs manual correction labels Aug 4, 2026
@github-actions

github-actions Bot commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

$\textbf{🟡\ Medium\ Severity\ —\ AppSource}$

In RecommendedAppCard.Page.al, the field's Caption was rebranded to "View on Marketplace", but the paired ToolTip still says "View app on Microsoft AppSource" and the underlying field value string is still 'Link to AppSource'. This leaves one control showing mixed AppSource/Marketplace branding to the user. Update the ToolTip and field value text to "Marketplace" so all three pieces of user-facing text on this control agree.

Suggested fix (apply manually — could not be anchored as a one-click suggestion):

            field("View on AppSource"; 'Link to Marketplace')
            {
                ApplicationArea = All;
                ToolTip = 'View app on Microsoft Marketplace';
                Caption = 'View on Marketplace';

Line mapping was unavailable, so this was posted as an issue comment.

👍 useful · ❤️ especially valuable · 👎 wrong - reply with why · AL review agent v1.27.4

@github-actions

github-actions Bot commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

$\textbf{🟡\ Medium\ Severity\ —\ AppSource}$

src/System Application/App/AppSource Gallery/app.json now describes the extension as "Marketplace Product Gallery" in brief and description, but the manifest name is still "AppSource Product Gallery". That leaves the extension/package display name out of sync with its own user-facing metadata and can surface mixed AppSource/Marketplace branding in extension management UI and listings. If the rebrand is intentional, rename the app's name (and any dependent manifests referencing it by name) so the metadata stays consistent; if the name must stay stable for compatibility, revert brief/description to keep AppSource terminology instead.

Line mapping was unavailable, so this was posted as an issue comment.

👍 useful · ❤️ especially valuable · 👎 wrong - reply with why · AL review agent v1.27.4

@github-actions github-actions Bot added this to the Version 29.0 milestone Aug 5, 2026
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@github-actions

github-actions Bot commented Aug 9, 2026

Copy link
Copy Markdown
Contributor

⚠️ Stale Status Check Deleted

The Pull Request Build workflow run for this PR was older than 72 hours and has been deleted.

📋 Why was it deleted?

Status checks that are too old may no longer reflect the current state of the target branch. To ensure this PR is validated against the latest code and passes up-to-date checks, a fresh build is required.


🔄 How to trigger a new status check:

  1. 📤 Push a new commit to the PR branch, or
  2. 🔁 Close and reopen the PR

This will automatically trigger a new Pull Request Build workflow run.

@SBalslev
Steffen Balslev (SBalslev) marked this pull request as draft August 12, 2026 06:52
auto-merge was automatically disabled August 12, 2026 06:52

Pull request was converted to draft

@SBalslev
Steffen Balslev (SBalslev) marked this pull request as ready for review August 12, 2026 06:52
auto-merge was automatically disabled August 12, 2026 07:08

Pull request was closed


var
Assert: Codeunit Assert;
MarketplaceURLNotFoundErr: Label 'Marketplace URL';

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

$\textbf{🟡\ Medium\ Severity\ —\ Testing}$

The new shared label MarketplaceURLNotFoundErr: Label 'Marketplace URL'; used with Assert.ExpectedError(MarketplaceURLNotFoundErr) is too broad to pin this negative test to the specific 'not found' error it is meant to verify. Assert.ExpectedError matches on a substring of the actual raised error, so any other failure that happens to mention 'Marketplace URL' would also make this assertion pass, weakening the test's ability to detect the wrong error. Use the full expected error text (matching the production AppSourceURLNotFoundErrLbl wording, 'Cannot get the Marketplace URL.') or another uniquely identifying fragment instead of the generic two-word substring.

Suggested fix (apply manually — could not be anchored as a one-click suggestion):

        MarketplaceURLNotFoundErr: Label 'Cannot get the Marketplace URL.';

Knowledge:

👍 useful · ❤️ especially valuable · 👎 wrong - reply with why · AL review agent v1.32.4

Comment thread src/System Application/App/AppSource Gallery/app.json
var
CatalogApiUrlLbl: Label 'https://catalogapi.azure.com/products/PUBID.%1|AID.%2|PAPPID.%3?market=US&api-version=2023-05-01-preview&language=en', Locked = true;
IncorrectAppSourceUrlLbl: Label '%1 is not a correct AppSource URL.', Locked = true, Comment = '%1 = App source URL';
IncorrectAppSourceUrlLbl: Label '%1 is not a correct Marketplace URL.', Locked = true, Comment = '%1 = App source URL';

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

$\textbf{🟡\ Medium\ Severity\ —\ Telemetry}$

IncorrectAppSourceUrlLbl feeds Session.LogMessage('0000I4I', ...) in ConnectivityAppsLogoMgt.Codeunit.al. The label's locked text changed from '%1 is not a correct AppSource URL.' to '%1 is not a correct Marketplace URL.', altering the payload of an existing telemetry event. This can break saved KQL queries or dashboards that match on the old message text. Keep the user-facing rename in UI-visible strings, but leave locked telemetry message text stable (or introduce telemetry-only text changes deliberately, coordinated with telemetry consumers) rather than changing it incidentally as part of a UI rebrand.

👍 useful · ❤️ especially valuable · 👎 wrong - reply with why · AL review agent v1.32.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AL: Apps (W1) Add-on apps for W1 AL: System Application Other GitHub request for other area than SCM, Finance or Integration Ownership: Needs Review Ownership is Other, low confidence, or needs manual correction

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants