Rename AppSource UI text to Marketplace - #9953
Rename AppSource UI text to Marketplace#9953Steffen Balslev (SBalslev) wants to merge 2 commits into
Conversation
Port the NAV AppSource-to-Marketplace UI text rename to BCApps and update additional user-facing captions, tooltips, labels, and visible metadata found during the scan. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
|
In RecommendedAppCard.Page.al, the field's Caption was rebranded to "View on Marketplace", but the paired ToolTip still says "View app on Microsoft AppSource" and the underlying field value string is still 'Link to AppSource'. This leaves one control showing mixed AppSource/Marketplace branding to the user. Update the ToolTip and field value text to "Marketplace" so all three pieces of user-facing text on this control agree. Suggested fix (apply manually — could not be anchored as a one-click suggestion): field("View on AppSource"; 'Link to Marketplace')
{
ApplicationArea = All;
ToolTip = 'View app on Microsoft Marketplace';
Caption = 'View on Marketplace';Line mapping was unavailable, so this was posted as an issue comment. 👍 useful · ❤️ especially valuable · 👎 wrong - reply with why · AL review agent v1.27.4 |
|
src/System Application/App/AppSource Gallery/app.json now describes the extension as "Marketplace Product Gallery" in Line mapping was unavailable, so this was posted as an issue comment. 👍 useful · ❤️ especially valuable · 👎 wrong - reply with why · AL review agent v1.27.4 |
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
|
Pull request was converted to draft
|
|
||
| var | ||
| Assert: Codeunit Assert; | ||
| MarketplaceURLNotFoundErr: Label 'Marketplace URL'; |
There was a problem hiding this comment.
The new shared label MarketplaceURLNotFoundErr: Label 'Marketplace URL'; used with Assert.ExpectedError(MarketplaceURLNotFoundErr) is too broad to pin this negative test to the specific 'not found' error it is meant to verify. Assert.ExpectedError matches on a substring of the actual raised error, so any other failure that happens to mention 'Marketplace URL' would also make this assertion pass, weakening the test's ability to detect the wrong error. Use the full expected error text (matching the production AppSourceURLNotFoundErrLbl wording, 'Cannot get the Marketplace URL.') or another uniquely identifying fragment instead of the generic two-word substring.
Suggested fix (apply manually — could not be anchored as a one-click suggestion):
MarketplaceURLNotFoundErr: Label 'Cannot get the Marketplace URL.';Knowledge:
👍 useful · ❤️ especially valuable · 👎 wrong - reply with why · AL review agent v1.32.4
| var | ||
| CatalogApiUrlLbl: Label 'https://catalogapi.azure.com/products/PUBID.%1|AID.%2|PAPPID.%3?market=US&api-version=2023-05-01-preview&language=en', Locked = true; | ||
| IncorrectAppSourceUrlLbl: Label '%1 is not a correct AppSource URL.', Locked = true, Comment = '%1 = App source URL'; | ||
| IncorrectAppSourceUrlLbl: Label '%1 is not a correct Marketplace URL.', Locked = true, Comment = '%1 = App source URL'; |
There was a problem hiding this comment.
IncorrectAppSourceUrlLbl feeds Session.LogMessage('0000I4I', ...) in ConnectivityAppsLogoMgt.Codeunit.al. The label's locked text changed from '%1 is not a correct AppSource URL.' to '%1 is not a correct Marketplace URL.', altering the payload of an existing telemetry event. This can break saved KQL queries or dashboards that match on the old message text. Keep the user-facing rename in UI-visible strings, but leave locked telemetry message text stable (or introduce telemetry-only text changes deliberately, coordinated with telemetry consumers) rather than changing it incidentally as part of a UI rebrand.
👍 useful · ❤️ especially valuable · 👎 wrong - reply with why · AL review agent v1.32.4
Summary
Reference
Validation
git diff --check