-
Notifications
You must be signed in to change notification settings - Fork 436
Rename AppSource UI text to Marketplace #9953
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -6,6 +6,7 @@ codeunit 139527 "Recommended Apps Tests" | |
|
|
||
| var | ||
| Assert: Codeunit Assert; | ||
| MarketplaceURLNotFoundErr: Label 'Marketplace URL'; | ||
|
SBalslev marked this conversation as resolved.
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The new shared label Suggested fix (apply manually — could not be anchored as a one-click suggestion): MarketplaceURLNotFoundErr: Label 'Cannot get the Marketplace URL.';Knowledge: 👍 useful · ❤️ especially valuable · 👎 wrong - reply with why · AL review agent v1.32.4 |
||
|
|
||
| [Test] | ||
| procedure TestInsertAppWhenURLAppInfoAreWrong() | ||
|
|
@@ -190,7 +191,7 @@ codeunit 139527 "Recommended Apps Tests" | |
| URL, | ||
| // URL is decoded | ||
| 'https://appsource.microsoft.com/en-us/product/dynamics-365-business-central/PUBID.thetasystemslimited|AID.bc_excel_importer|PAPPID.24466323-aee9-4049-a66d-a1af24466323?tab=Overview', | ||
| 'The AppSource URL is wrong.' | ||
| 'The Marketplace URL is wrong.' | ||
| ); | ||
| end; | ||
|
|
||
|
|
@@ -210,7 +211,7 @@ codeunit 139527 "Recommended Apps Tests" | |
| asserterror RecommendedApps.GetAppURL(CreateGuid()); | ||
|
|
||
| // [THEN] Am error is thrown | ||
| Assert.ExpectedError('Cannot get the AppSource URL.'); | ||
|
SBalslev marked this conversation as resolved.
|
||
| Assert.ExpectedError(MarketplaceURLNotFoundErr); | ||
| end; | ||
|
|
||
| local procedure InsertSingleApp(): Guid | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IncorrectAppSourceUrlLbl feeds Session.LogMessage('0000I4I', ...) in ConnectivityAppsLogoMgt.Codeunit.al. The label's locked text changed from '%1 is not a correct AppSource URL.' to '%1 is not a correct Marketplace URL.', altering the payload of an existing telemetry event. This can break saved KQL queries or dashboards that match on the old message text. Keep the user-facing rename in UI-visible strings, but leave locked telemetry message text stable (or introduce telemetry-only text changes deliberately, coordinated with telemetry consumers) rather than changing it incidentally as part of a UI rebrand.
👍 useful · ❤️ especially valuable · 👎 wrong - reply with why · AL review agent v1.32.4