Repository navigation
[stack] feat(sharebymail): use the new email blocks for share notifications - #65195
Merged
Merged
Conversation
skjnldsv
added
enhancement
2. developing
skjnldsv
added this pull request to stack #65196
October 6, 2026 14:56
skjnldsv
changed the title
skjnldsv
force-pushed
the
feature/sharebymail-mail-blocks
branch
from
October 6, 2026 14:58
818f4dd to
bd7358d
Compare
skjnldsv
added
enhancement
2. developing
skjnldsv
force-pushed
the
feature/sharebymail-mail-blocks
branch
from
October 6, 2026 15:59
bd7358d to
abfb3ab
Compare
skjnldsv
force-pushed
the
feature/sharebymail-mail-blocks
branch
from
October 6, 2026 16:51
abfb3ab to
d0e4767
Compare
5 of 7 tasks
skjnldsv
force-pushed
the
feature/sharebymail-mail-blocks
branch
from
October 6, 2026 18:15
d0e4767 to
44e508e
Compare
skjnldsv
removed this pull request from stack #65196
October 6, 2026 18:15
skjnldsv
force-pushed
the
feature/sharebymail-mail-blocks
branch
from
October 6, 2026 18:23
44e508e to
d574efb
Compare
5 of 9 tasks
skjnldsv
added this pull request to stack #65223
October 6, 2026 18:34
skjnldsv
marked this pull request as ready for review
October 6, 2026 18:35
skjnldsv
requested review from
come-nc,
leftybournes,
provokateurin and
salmart-dev
October 6, 2026 18:35
skjnldsv
force-pushed
the
feature/sharebymail-mail-blocks
branch
from
October 6, 2026 20:27
d574efb to
fb182a2
Compare
susnux
approved these changes
Oct 6, 2026
The share notification now shows the sharer with their initials, the note in a quote box and a details card with the shared item, its expiration date and whether a password is required. The sharer's email address is only shown when replies are sent to them. Assisted-by: ClaudeCode:claude-opus-5-5 Signed-off-by: John Molakvoæ <14975046+skjnldsv@users.noreply.github.com>
skjnldsv
force-pushed
the
feature/sharebymail-mail-blocks
branch
from
October 7, 2026 08:25
fb182a2 to
7e7357c
Compare
jancborchardt
approved these changes
Oct 7, 2026
jancborchardt
left a comment
jancborchardt
left a comment
Member
There was a problem hiding this comment.
Looks very nice! :) One thing only: On mobile, is the white stripe above the blue actually there in the mail body or is it a screenshot artifact (status bar)? Cause if it’s in the mail body, it could be removed on mobile?
Member
Author
Fair enough, will adjust as a followup 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Builds on #65194. Share-by-mail notifications now show who shared, their note, and a card with the file, its expiry date and whether a password is needed. The sharer's email is only shown when replies go to them.
New strings: "Note from %s", "Valid until", "Password", "Required".
Browser renders with sample data, after includes the restyle from #65194.
Checklist
AI (if applicable)
👾 This pull request was assisted by Claude Code, commits carry an
Assisted-bytrailer.