Skip to content

[stable32] fix(systemtags): update file node on tag assignment - #65337

Open
Antreesy wants to merge 1 commit into
stable32from
fix/noid/system-tags-event
Open

[stable32] fix(systemtags): update file node on tag assignment#65337
Antreesy wants to merge 1 commit into
stable32from
fix/noid/system-tags-event

Conversation

@Antreesy

@Antreesy Antreesy commented Oct 9, 2026

Copy link
Copy Markdown
Contributor
  • Resolves: UI reactivity

Summary

To reproduce:

  • Open details -> Actions menu -> Tags
  • Assign existing or create a new tag for the file
  • See chip appear on FileRow
  • File actions -> Manage tags
  • See tags are not selected there
Before After
image image

TODO

  • ...

Checklist

AI (if applicable)

  • The content of this PR was partly or fully generated using AI

@Antreesy
fix(systemtags): update file node on tag assignment
cd21e71 
- systemtags:node:updated only affect the chips appearance on a FileRow
- files:node:update also propagate changes to 'Manage tags' dialog

Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy Antreesy self-assigned this Oct 9, 2026
@Antreesy
Antreesy requested a review from a team as a code owner October 9, 2026 10:11
@Antreesy
Antreesy requested review from kristian-zendato, pringelmann and susnux and removed request for a team October 9, 2026 10:11
pringelmann
pringelmann approved these changes Oct 9, 2026
View reviewed changes

@pringelmann pringelmann left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, but why not master + stable backports?

@Antreesy

Antreesy commented Oct 9, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Code looks good, but why not master + stable backports?

stable33 and recent do not longer have this issue (with specified reproduction steps), targeting only affected branch

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pringelmann pringelmann pringelmann approved these changes
@susnux susnux Awaiting requested review from susnux susnux is a code owner automatically assigned from nextcloud/server-frontend
@kristian-zendato kristian-zendato Awaiting requested review from kristian-zendato kristian-zendato is a code owner automatically assigned from nextcloud/server-frontend

At least 2 approving reviews are required to merge this pull request.

Assignees

@Antreesy Antreesy

Labels

3. to review Waiting for reviews bug feature: tags

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Antreesy @pringelmann