Repository navigation
fix(dav): reject negative seeks in assembly streams - #65399
Draft
joshtrichards wants to merge 2 commits into
Draft
joshtrichards wants to merge 2 commits into
joshtrichards wants to merge 2 commits into
Conversation
Reject seek offsets below zero after resolving SEEK_CUR and SEEK_END. This prevents invalid positions and avoids selecting a nonexistent node when seeking backward in an empty assembly. Signed-off-by: Josh <josh.t.richards@gmail.com>
Test seek modes and boundaries, including negative offsets, EOF, and failed-seek position preservation. Also cover empty assemblies, resource-backed chunks, short reads, and stream position and size. Assisted-by: Copilot:gpt-6-luna Signed-off-by: Josh <josh.t.richards@gmail.com>
joshtrichards
added
bug
2. developing
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TODO
Checklist
3. to review, feature component)stable32)AI (if applicable)