Repository navigation
perf(sharing): skip resolving group shares when there are none - #65461
Open
CarlSchwan wants to merge 1 commit into
Open
CarlSchwan wants to merge 1 commit into
CarlSchwan wants to merge 1 commit into
Conversation
CarlSchwan
requested review from
come-nc,
icewind1991,
leftybournes and
sorbaugh
and removed request for
a team
October 13, 2026 10:46
Setting up the mount of a received share looks up group shares for the path, and then queries the user specific group share entries to apply them, even when no group share was found. The result can only change the group shares found, so skip the query when there are none. This saves a query on every access to a received share for users without group shares for the path. Assisted-by: ClaudeCode:claude-opus-5-5 Signed-off-by: Carl Schwan <carl@carlschwan.eu>
CarlSchwan
force-pushed
the
carl/share-skip-empty-group-resolve
branch
from
October 13, 2026 19:44
603aa88 to
30853f5
Compare
provokateurin
approved these changes
Oct 14, 2026
come-nc
reviewed
Oct 14, 2026
Comment on lines
+1074
to
1077
| if ($shares2 === []) { | ||
| return []; | ||
| } | ||
| $shares = $this->resolveGroupShares($shares2, $userId, $path, $forChildren); |
Contributor
There was a problem hiding this comment.
The test should be inside resolveGroupShares, if share list is empty it should early return.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Skip looking up for the user specific group share entries when no group share was found. This saves a query on every access to a received share for users without group shares for the path.
TODO
Checklist
3. to review, feature component)stable32)AI (if applicable)