Repository navigation
test: overwrite base url in test - #65471
Merged
Merged
Conversation
icewind1991
requested review from
come-nc,
leftybournes,
provokateurin,
salmart-dev and
sorbaugh
and removed request for
a team
October 13, 2026 15:23
Member
Author
|
/backport to stable35 |
provokateurin
left a comment
Member
There was a problem hiding this comment.
If I'm not mistaken it is already set for unit tests though 🤔 At least there are some unit tests that generate a URL and they don't care about the environment. Maybe it's still better to explicitly override it though.
Member
Author
|
It fails for me with the actual base url 🤷 |
provokateurin
approved these changes
Oct 13, 2026
provokateurin
left a comment
Member
There was a problem hiding this comment.
I was not able to find those tests, maybe I just misremembered it.
provokateurin
enabled auto-merge
October 13, 2026 15:30
icewind1991
force-pushed
the
share-test-base-url
branch
2 times, most recently
from
October 13, 2026 17:48
924e3fe to
88b9d86
Compare
Contributor
|
Possible performance regression detected Show Output |
icewind1991
force-pushed
the
share-test-base-url
branch
from
October 13, 2026 18:10
88b9d86 to
6b627b3
Compare
Signed-off-by: Robin Appelman <robin@icewind.nl>
icewind1991
force-pushed
the
share-test-base-url
branch
from
October 14, 2026 14:42
6b627b3 to
aac7fac
Compare
Member
Author
|
reworked it to be a bit simpler and apply on all tests |
come-nc
approved these changes
Oct 15, 2026
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
don't make the test rely on the actual base url
Checklist
3. to review, feature component)stable32)AI (if applicable)