Repository navigation
fix(viewer): read legacy dav permission strings - #65482
Merged
Merged
Conversation
Apps pass OCA.Viewer.open() the permissions dav answers, a string such as CKWNVGDR, as the photos app does for every photo. The shim handed it to the node as is, and a node only takes a bitmask: Error: Invalid permissions A string is now parsed with parsePermissions(); a number is kept. Assisted-by: ClaudeCode:claude-opus-5-5 Signed-off-by: John Molakvoæ <14975046+skjnldsv@users.noreply.github.com>
skjnldsv
requested review from
kristian-zendato,
pringelmann and
susnux
and removed request for
a team
October 13, 2026 19:42
susnux
approved these changes
Oct 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OCA.Viewer.open()still fails for the photos app after #65009, one check further into the node:Apps pass the permissions dav answers, a string such as
CKWNVGDR, and the shim handed it to the node as is. A node only takes a bitmask. A string is now parsed withparsePermissions()from@nextcloud/files/dav; a number is kept.Failing run on nextcloud/photos#3877: https://github.com/nextcloud/photos/actions/runs/38433136372
The new case in
legacy.spec.tsuses a file info shaped like the one photos sends. It fails without the change and passes with it, so no further node check fails behind this one.👾 This pull request was assisted by Claude Code, commits carry an
Assisted-bytrailer.