Skip to content

feat: log changes made regarding app passwords and unified sharing - #65546

Open
GhassenKefi wants to merge 2 commits into
masterfrom
feat/admin-audit-core-sharing
Open

GhassenKefi wants to merge 2 commits into
masterfrom
feat/admin-audit-core-sharing

Conversation

@GhassenKefi

@GhassenKefi GhassenKefi commented Oct 15, 2026 •

Copy link
Copy Markdown
Contributor
  • Resolves: #

Summary

Add audit log entries for actions in :

  • Core (passwords, password reset requests and finished remote wipes)
  • sharing (log changes made through the unified sharing API)

TODO

  • ...

Checklist

AI (if applicable)

  • The content of this PR was partly or fully generated using AI

…emote wipes

App passwords created through login flow v1 and v2 and the app
password API, and deleting an app password through the API, are now
written to the audit log with the same operations the settings app
uses (auth.app_password.created and auth.app_password.deleted).

A password reset request is logged with the resolved user ID once the
reset token has been created, and a finished remote wipe is logged
when the device confirms it.

The token and the password are never logged.

Assisted-by: ClaudeCode:claude-opus-5-5
Signed-off-by: Ghassen kefi <ghassen.kefi.dev@gmail.com>
The unified sharing API (behind sharing.unified_api_enable) changed
shares, their sources, recipients, permissions, properties and
recipient secrets without any audit entry. SharingManager now writes
one entry per change, with unified_sharing.* operations, so they can
be told apart from the legacy sharing.share.* entries, which carry
different parameters.

Recipient secrets (the public link token) and property values are
never logged.

Assisted-by: ClaudeCode:claude-opus-5-5
Signed-off-by: Ghassen kefi <ghassen.kefi.dev@gmail.com>
@GhassenKefi GhassenKefi added this to the Nextcloud 36 milestone Oct 15, 2026
@GhassenKefi GhassenKefi self-assigned this Oct 15, 2026
@GhassenKefi
GhassenKefi requested a review from a team as a code owner October 15, 2026 10:28
@GhassenKefi
GhassenKefi requested review from icewind1991 and removed request for a team October 15, 2026 10:28
@GhassenKefi
GhassenKefi requested a review from susnux October 15, 2026 10:28
@susnux susnux changed the title Feat/admin audit core sharing feat: log changes made regarding app passwords and unified sharing Oct 17, 2026
@GhassenKefi
GhassenKefi force-pushed the feat/admin-audit-core-sharing branch from 103016a to 9883a71 Compare October 19, 2026 09:06

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant