Repository navigation
feat(dav): limit scoped app passwords to the collections they open - #65552
Draft
pringelmann wants to merge 1 commit into
Draft
pringelmann wants to merge 1 commit into
pringelmann wants to merge 1 commit into
Conversation
Signed-off-by: Peter Ringelmann <peter.ringelmann@nextcloud.com>
pringelmann
added this pull request to stack #65341
October 15, 2026 13:19
pringelmann
requested review from
CarlSchwan,
artonge,
come-nc and
nickvergessen
and removed request for
sorbaugh
October 15, 2026 13:19
pringelmann
marked this pull request as draft
October 15, 2026 15:47
Contributor
Author
|
Drafting for now, got feedback that necessitates major changes |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
I'm new to DAV and leaned heavily on Claude for this PR. I went through the code with it until I understood how the plugin hooks into Sabre and why each rule is there, but reviews from people who know DAV well would help the most here, especially on the calendar and contacts rules.
Summary
Stacked on #65340, which does the same for index.php and OCS.
Sabre plugin that refuses DAV requests outside the token's scopes (403) and drops refused items from multistatus responses, so multiget can't read around it. Loaded in
remote.php/davand the legacy caldav, carddav and webdav endpoints. Default deny per top-level collection.files:read. Writes are left to the mount permissionscontacts:readTokens without scopes aren't affected.
Testing
Tested locally with Thunderbird
140.17.0and acalendar:read calendar:writetoken:contacts:readfiles:*token finds no calendarsChecklist
3. to review, feature component)stable32)AI (if applicable)