Repository navigation
dynamic-load: check overlay names now that overlay list returns a table - #1300
Merged
Merged
Conversation
Contributor
|
Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
overlay listreturns a table withnameandactivecolumns now, so'.nu' in (overlay list)is a parse error and the dynamic-load hook can't be used at all. This checks the names instead, same fix as the one auto-venv got in #1260.Checked on 0.116.1 that the condition is true when
~/.nuexists and isn't loaded yet, and false afteroverlay use ~/.nu as .nu.