Skip to content

Prove controlled-session lifecycle in Docker - #31

Open
omry wants to merge 1 commit into
pr30from
pr31
Open

Prove controlled-session lifecycle in Docker#31
omry wants to merge 1 commit into
pr30from
pr31

Conversation

@omry

@omry omry commented Aug 9, 2026

Copy link
Copy Markdown
Owner

@omry
omry changed the base branch from main to pr30 August 9, 2026 06:19
@omry

omry commented Aug 9, 2026

Copy link
Copy Markdown
Owner Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Keep it up!

Reviewed commit: faa10ba33f

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@omry omry added the approved PR reviewed and approved label Aug 9, 2026
@omry
omry marked this pull request as ready for review August 9, 2026 13:42
Copilot AI lite review requested due to automatic review settings August 9, 2026 13:42

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR strengthens the Docker-based “controlled-session” lifecycle proof by injecting a payload that resembles a terminal “terminated” result into workload output and asserting that it survives output finalization—helping demonstrate that supervisor/controller lifecycle handling is not confused by forged in-band bytes.

Changes:

  • Inject a forged “terminated” JSON payload (prefixed with 0x1e) into workload output during the resize step.
  • Assert that the forged payload is present in the captured output at WorkloadOutputsFinalized, alongside existing exit/interrupt evidence.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved PR reviewed and approved

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants