Skip to content

*: update client-go to fix undetermined commit handling - #71587

Closed
gengliqi wants to merge 1 commit into
pingcap:masterfrom
gengliqi:update-client-go
Closed

gengliqi wants to merge 1 commit into
pingcap:masterfrom
gengliqi:update-client-go

Conversation

@gengliqi

@gengliqi gengliqi commented Sep 24, 2026 •

Copy link
Copy Markdown
Contributor

What problem does this PR solve?

Issue Number: close #71585

Problem Summary:

What changed and how does it work?

See #71585

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Summary by CodeRabbit

  • Chores
    • Updated the underlying TiKV client integration. No user-facing changes are noted.

Signed-off-by: gengliqi <gengliqiii@gmail.com>
@ti-chi-bot ti-chi-bot Bot added release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 24, 2026
@coderabbitai

coderabbitai Bot commented Sep 24, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Advanced

Run ID: 1e4ef3c0-6aa5-4dc8-a42a-47728ba1746a

📥 Commits

Reviewing files that changed from the base of the PR and between 067c50b and b474dfe.

⛔ Files ignored due to path filters (1)
  • go.sum is excluded by !**/*.sum
📒 Files selected for processing (2)
  • DEPS.bzl
  • go.mod

Included review availability: Your plan provides up to 10 included reviews per hour; 9 remain after this review.


📝 Walkthrough

Walkthrough

The client-go dependency pin changed in go.mod and DEPS.bzl to version v2.0.8-0.20260923034936-1fd036c3e010. The Bazel declaration also uses the updated checksum.

Changes

client-go dependency update

Layer / File(s) Summary
Update client-go dependency pin
go.mod, DEPS.bzl
Both dependency declarations now use version v2.0.8-0.20260923034936-1fd036c3e010. The DEPS.bzl checksum was also updated.

Priority: ➖ Normal

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Bug fix · Severity of issue fixed: Medium

Suggested reviewers: lcwangchao

Merge Risk: ⚪ Minimal · up to b474d

The dependency update is internally consistent and no concrete current-head failure was identified.

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (1 warning, 1 inconclusive)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 1 files. (1 skipped: 1 … Write docstrings for the functions missing them to satisfy the coverage threshold.
Linked Issues check ❓ Inconclusive Issue #71585 requires client-go to close the client connection when the commit result remains undetermined. The pull request updates github.com/tikv/client-go/v2 in go.mod and DEPS.bzl to commit… Evidence is required that client-go commit 1fd036c3e010 contains the fix from client-go PR #2063 and closes the client connection for undetermined commit results.
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title follows the repository format and clearly describes the client-go dependency update and its purpose of fixing undetermined commit handling.
Description check ✅ Passed The description includes the required issue reference, change summary link, testing selection, side-effect and documentation checklists, and release-note section. The Problem Summary field is empty, b…
Out of Scope Changes check ✅ Passed The reviewed changes only update the github.com/tikv/client-go/v2 dependency in go.mod and DEPS.bzl. This change directly supports issue #71585 and no unrelated change is shown.
Full details: Linked Issues check

Explanation

Issue #71585 requires client-go to close the client connection when the commit result remains undetermined. The pull request updates github.com/tikv/client-go/v2 in go.mod and DEPS.bzl to commit 1fd036c3e010. The available summary does not establish that this commit contains the fix from client-go PR #2063 or that it implements the required connection-close behavior. go.sum is excluded from review, so its contents cannot resolve this gap.

Full details: Docstring Coverage

Explanation

Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 1 files. (1 skipped: 1 unsupported.)

  • Fix all pre-merge checks with AI
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

A rabbit checks the version line,
The Go and Bazel pins align.
A fresh checksum joins the view,
The client-go pin is current too.
Hop, hop, the update’s through!

Comment @coderabbitai help to get the list of available commands.

@ti-chi-bot

ti-chi-bot Bot commented Sep 24, 2026

Copy link
Copy Markdown

@LykxSassinator: adding LGTM is restricted to approvers and reviewers in OWNERS files.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@codecov

codecov Bot commented Sep 24, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 72.0884%. Comparing base (067c50b) to head (b474dfe).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #71587        +/-   ##
================================================
- Coverage   76.2996%   72.0884%   -4.2113%     
================================================
  Files          2041       2109        +68     
  Lines        554520     598504     +43984     
================================================
+ Hits         423097     431452      +8355     
- Misses       130523     165728     +35205     
- Partials        900       1324       +424     
Flag Coverage Δ
integration 40.6068% <ø> (+0.9350%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 58.8395% <ø> (ø)
parser ∅ <ø> (∅)
br 46.5727% <ø> (-16.1371%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ti-chi-bot

ti-chi-bot Bot commented Sep 24, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: LykxSassinator, wfxr
Once this PR has been reviewed and has the lgtm label, please assign cfzjywxk for approval. For more information see the Code Review Process.
Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot

ti-chi-bot Bot commented Sep 24, 2026

Copy link
Copy Markdown

@wfxr: adding LGTM is restricted to approvers and reviewers in OWNERS files.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@wfxr wfxr mentioned this pull request Sep 24, 2026
13 tasks
@gengliqi

Copy link
Copy Markdown
Contributor Author

/retest

@gengliqi

Copy link
Copy Markdown
Contributor Author

Closing in favor of #71608, which also includes the undetermined commit fixes from tikv/client-go#2063.

@gengliqi gengliqi closed this Sep 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Transactions may return ordinary errors when the commit result is undetermined

3 participants