*: update client-go to latest master - #71608
Conversation
Pick up the Go 1.25.14 upgrade, transaction fixes, and RU v2 cleanup from client-go master. Signed-off-by: Wenxuan Zhang <wenxuangm@gmail.com>
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Advanced Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (2)
Included review availability: Your plan provides up to 10 included reviews per hour; 7 remain after this review. 📝 WalkthroughWalkthroughThe ChangesTiKV client-go dependency update
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~5 minutes Change: Other Suggested reviewers: Merge Risk: ⚪ Minimal · up to No actionable issue is established for this dependency update. It is mergeable after normal checks. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Full details: Docstring CoverageExplanation Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 1 files. (1 skipped: 1 unsupported.)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. A rabbit checks the version string, Comment |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cfzjywxk, lcwangchao The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #71608 +/- ##
================================================
- Coverage 76.2996% 72.0833% -4.2164%
================================================
Files 2041 2110 +69
Lines 554520 604156 +49636
================================================
+ Hits 423097 435496 +12399
- Misses 130523 166685 +36162
- Partials 900 1975 +1075
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
|
/retest |
|
/retest |
2 similar comments
|
/retest |
|
/retest |
|
In response to a cherrypick label: new pull request could not be created: failed to create pull request against pingcap/tidb#release-nextgen-202609 from head ti-chi-bot:cherry-pick-71608-to-release-nextgen-202609: status code 422 not one of [201], body: {"message":"Validation Failed","errors":[{"resource":"PullRequest","code":"custom","message":"No commits between pingcap:release-nextgen-202609 and ti-chi-bot:cherry-pick-71608-to-release-nextgen-202609"}],"documentation_url":"https://docs.github.com/rest/pulls/pulls#create-a-pull-request","status":"422"} |
What problem does this PR solve?
Issue Number: ref #71489
Problem Summary:
TiDB
masterstill pins client-go5f38569c8cc0, which predates the client-go Go 1.25.14 upgrade. The current client-gomasterhead isb9fc0b7719d3.What changed and how does it work?
Update
github.com/tikv/client-go/v2tov2.0.8-0.20260923121349-b9fc0b7719d3and regenerate its Go checksums and Bazel dependency entry. This picks up the Go 1.25.14 upgrade, transaction fixes, and the later RU v2 cleanup. TiDB already uses Go 1.25.14.This overlaps #71587, which updates client-go only through
1fd036c3e010for undetermined commit handling. This PR targets the current client-gomasterhead for the separate version-sync purpose. If #71587 merges first, this PR should be rebased so that only the remaining update is shown.Check List
Tests
GOWORK=off GOTOOLCHAIN=go1.25.14 ./tools/check/failpoint-go-test.sh pkg/store/driver -run '^TestTxnGet$' -count=1 -tags=intest,deadlockGOTOOLCHAIN=go1.25.14 make bazel_prepareGOWORK=off GOTOOLCHAIN=go1.25.14 go mod verifyGOWORK=off GOTOOLCHAIN=go1.25.14 go mod tidygit show --format= --check HEADcheckcommit hook reformatted unrelatedbr/pkg/restore/ingestrec/foreign_key.goand blocked the commit; that hook output was restored, and thego-mod-tidyhook passed. Full suite and integration tests were not run locally.Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.
Summary by CodeRabbit