Rename sovereign cloud environments in CloudManager and Microsoft365Environment#1787
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Renames sovereign cloud environment identifiers in Microsoft365Environment and updates CloudManager (plus tests) to use the new names, aiming to align with 1P tooling terminology and reduce confusion.
Changes:
- Renamed enum members for French/German/Singapore sovereign cloud environments.
- Updated
CloudManagerdomain-to-environment mapping and authority host mappings to use the renamed enum members. - Updated
CloudManagerTeststo validate the new environment names (including adding.sgcoverage).
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| src/sdk/PnP.Core/Services/Core/Microsoft365Environment.cs | Renames sovereign cloud enum members and updates related XML docs. |
| src/sdk/PnP.Core/Services/Core/CloudManager.cs | Switch mappings updated to new enum names for URI parsing and authority resolution. |
| src/sdk/PnP.Core.Test/Misc/CloudManagerTests.cs | Test data updated to assert the renamed enum values and added .sg URI coverage. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+41
to
45
| BleuCloud = 7, | ||
|
|
||
| /// <summary> | ||
| /// Represents the GovDe Cloud environment option. Operated by an SAP subsidiary and aligned with German Cloud Platform Requirements. See https://learn.microsoft.com/en-us/industry/sovereign-cloud/national-partner-clouds/overview-national-partner-clouds | ||
| /// Represents the DelosCloud Cloud environment option. Operated by an SAP subsidiary and aligned with German Cloud Platform Requirements. See https://learn.microsoft.com/en-us/industry/sovereign-cloud/national-partner-clouds/overview-national-partner-clouds | ||
| /// </summary> |
|
|
||
| /// <summary> | ||
| /// Represents the GovDe Cloud environment option. Operated by an SAP subsidiary and aligned with German Cloud Platform Requirements. See https://learn.microsoft.com/en-us/industry/sovereign-cloud/national-partner-clouds/overview-national-partner-clouds | ||
| /// Represents the DelosCloud Cloud environment option. Operated by an SAP subsidiary and aligned with German Cloud Platform Requirements. See https://learn.microsoft.com/en-us/industry/sovereign-cloud/national-partner-clouds/overview-national-partner-clouds |
|
|
||
| /// <summary> | ||
| /// Represents the GovSG Cloud environment option. Operated by a Singaporean government-owned company and aligned with Singapore's Sovereign Cloud Framework. See https://learn.microsoft.com/en-us/industry/sovereign-cloud/national-partner-clouds/overview-national-partner-clouds | ||
| /// Represents the GovSGCloud Cloud environment option. Operated by a Singaporean government-owned company and aligned with Singapore's Sovereign Cloud Framework. See https://learn.microsoft.com/en-us/industry/sovereign-cloud/national-partner-clouds/overview-national-partner-clouds |
Comment on lines
+15
to
+18
| "de" => Microsoft365Environment.DelosCloud, | ||
| "cn" => Microsoft365Environment.China, | ||
| "fr" => Microsoft365Environment.GovFr, | ||
| "sg" => Microsoft365Environment.GovSg, | ||
| "fr" => Microsoft365Environment.BleuCloud, | ||
| "sg" => Microsoft365Environment.GovSGCloud, |
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #1787 +/- ##
==========================================
- Coverage 82.42% 81.21% -1.21%
==========================================
Files 416 637 +221
Lines 28590 45413 +16823
Branches 0 4780 +4780
==========================================
+ Hits 23565 36882 +13317
- Misses 5025 7119 +2094
- Partials 0 1412 +1412 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Adam-it
added a commit
that referenced
this pull request
Jun 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Renaming it align with 1P tooling and avoid confusion