Skip to content

Edit column descriptions - #135

Closed
mccoogp wants to merge 4 commits into
mainfrom
Edit-Column-Descriptions
Closed

mccoogp wants to merge 4 commits into
mainfrom
Edit-Column-Descriptions

Conversation

@mccoogp

@mccoogp mccoogp commented Sep 29, 2026

Copy link
Copy Markdown
Member

I've updated the column descriptions. I took a lot of them from the README, edited some down to fit a hover tooltip, and some aren't covered in the README. Feel free to edit any of them @RubyFri.

Taken exactly from the read me descriptions
domain, sent_gpc, uspapi_before_gpc, uspapi_after_gpc, usp_cookies_before_gpc, usp_cookies_after_gpc, gpp_before_gpc, gpp_after_gpc, OneTrustWPCCPAGoogleOptOut_before_gpc, OneTrustWPCCPAGoogleOptOut_after_gpc, OTGPPConsent_before_gpc, OTGPPConsent_after_gpc

Changed from the read me
site_id, gpp_version, OptanonConsent_before_gpc, OptanonConsent_after_gpc, urlClassification

Not in ReadMe
error, Well-known, decoded_gpp_before_gpc, decoded_gpp_after_gpc, USPS implementation, usps_before_gpc, usps_after_gpc, third_party_count, third_party_urls, Site URL, status, reasons_non_compliant, Tranco, unique_ad_networks, num_unique_ad_networks

@mccoogp
mccoogp requested a review from RubyFri September 29, 2026 23:52
@mccoogp

mccoogp commented Sep 30, 2026

Copy link
Copy Markdown
Member Author

Changed Tranco description to include that it's from 2023 in accordance with #119

@mccoogp mccoogp mentioned this pull request Sep 30, 2026
2 of 3 tasks
@mccoogp

mccoogp commented Oct 1, 2026

Copy link
Copy Markdown
Member Author

I’ve added the new descriptions from the crawl data legend. While looking at the legends I found decoded_gpp_before_gpc and decoded_gpp_after_gpc are exactly the same. I assume it should be the same except “before” should be changed to “after”. I can make that change in the 4 sheets if that’s the only place it exists, but let me know if this appears in more places.

Here is the breakdown of the new descriptions. @RubyFri

Taken exactly from the read me or legend descriptions:
domain, sent_gpc, uspapi_before_gpc, uspapi_after_gpc, usp_cookies_before_gpc, usp_cookies_after_gpc, gpp_before_gpc, gpp_after_gpc, OneTrustWPCCPAGoogleOptOut_before_gpc, OneTrustWPCCPAGoogleOptOut_after_gpc, OTGPPConsent_before_gpc, OTGPPConsent_after_gpc, Site URL, status, usps_before_gpc, usps_after_gpc, USPS implementation, Well-known, Tranco, third_party_count, third_party_urls, unique_ad_networks, num_unique_ad_networks

Changed slightly:
Site_id, gpp_version, OptanonConsent_before_gpc, OptanonConsent_after_gpc, urlClassification, decoded_gpp_before_gpc, decoded_gpp_after_gpc, error, site_isnull

@SebastianZimmeck

Copy link
Copy Markdown
Member

Thanks @mccoogp!

I’ve added the new descriptions from the crawl data legend. While looking at the legends I found decoded_gpp_before_gpc and decoded_gpp_after_gpc are exactly the same. I assume it should be the same except “before” should be changed to “after”. I can make that change in the 4 sheets if that’s the only place it exists, but let me know if this appears in more places.

Yes, that is a good catch. It should we what you said.

@RubyFri

RubyFri commented Oct 11, 2026

Copy link
Copy Markdown
Member

Great re-writing @mccoogp ! I approve of everything but 2 hover descriptions.
I think Compliance Result must also list None sites (as mentioned in last weeks meeting)
Also, site_id is entirely gone? Is that a mistake?

@mccoogp

mccoogp commented Oct 12, 2026

Copy link
Copy Markdown
Member Author

The site_id was removed a few updates to edit columns ago, but I will add it back. I will also update the results description soon. Both these changes will come in a new PR soon, but I will close this one for now as the rest of the changes are covered in #138

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants