Skip to content

FROMLIST: clk: qcom: gcc-qcs8300: clk: qcom: gcc-qcs8300: Fix suspend/resume issues for USB and PCIe - #173

Open
akakum-qualcomm wants to merge 1 commit into
qualcomm-linux:resolute-qcom-develfrom
akakum-qualcomm:akash/resolute-clk-qcs8300-pwrsts-ret-on
Open

akakum-qualcomm wants to merge 1 commit into
qualcomm-linux:resolute-qcom-develfrom
akakum-qualcomm:akash/resolute-clk-qcs8300-pwrsts-ret-on

Conversation

@akakum-qualcomm

@akakum-qualcomm akakum-qualcomm commented Oct 16, 2026 •

Copy link
Copy Markdown

FROMLIST: clk: qcom: gcc-qcs8300: clk: qcom: gcc-qcs8300: Fix suspend/resume issues for USB and PCIe

The USB subsystem does not expect to lose its state on suspend:

  xhci-hcd xhci-hcd.1.auto: xHC error in resume, USBSTS 0x401, Reinit
  usb usb1: root hub lost power or was reset

To maintain state during suspend, the relevant GDSCs need to stay in
retention mode, like they do on other similar SoCs. Change the mode to
PWRSTS_RET_ON to fix.

Fixes: 95eeb2ffce73 ("clk: qcom: Add support for Global Clock Controller on QCS8300")
Link: https://lore.kernel.org/all/20260629-monza-suspend-v1-2-b601d8a2f2f8@oss.qualcomm.com/
Signed-off-by: Loic Poulain <loic.poulain@oss.qualcomm.com>
Signed-off-by: Akash Kumar <akakum@qti.qualcomm.com>

CR-Fixed: 4710067
CR-Fixed: 4645099

@quic-tingweiz

Copy link
Copy Markdown

This is a WA change. Please provide approved JIRA. Has this been merged on qcom-next? Has it been verified on Ubuntu Kernel?

@pareekpa

pareekpa commented Oct 19, 2026 •

Copy link
Copy Markdown

This is a WA change. Please provide approved JIRA. Has this been merged on qcom-next? Has it been verified on Ubuntu Kernel?

I've checked with the Image team. The corresponding PR is older than JIRA exception work flow was established.
QLI 2.0 PR: qualcomm-linux/kernel#281

@quic-tingweiz

Copy link
Copy Markdown

WA is supposed to be temporary, and it should be replaced by formal fix. If the WA is there for so long, I doubt we can still carry this WA. Please seek the approval from JIRA.

…/resume issues for USB and PCIe

The USB subsystem does not expect to lose its state on suspend:

  xhci-hcd xhci-hcd.1.auto: xHC error in resume, USBSTS 0x401, Reinit
  usb usb1: root hub lost power or was reset

To maintain state during suspend, the relevant GDSCs need to stay in
retention mode, like they do on other similar SoCs. Change the mode to
PWRSTS_RET_ON to fix.

Fixes: 95eeb2f ("clk: qcom: Add support for Global Clock Controller on QCS8300")
Link: https://lore.kernel.org/all/20260629-monza-suspend-v1-2-b601d8a2f2f8@oss.qualcomm.com/
Signed-off-by: Loic Poulain <loic.poulain@oss.qualcomm.com>
Signed-off-by: Akash Kumar <akakum@qti.qualcomm.com>
@akakum-qualcomm
akakum-qualcomm force-pushed the akash/resolute-clk-qcs8300-pwrsts-ret-on branch from 69fc3b4 to 6d4503b Compare October 21, 2026 10:58
@akakum-qualcomm akakum-qualcomm changed the title WORKAROUND: clk: qcom: gcc-qcs8300: Use PWRSTS_RET_ON for USB GDSCs FROMLIST: clk: qcom: gcc-qcs8300: clk: qcom: gcc-qcs8300: Fix suspend/resume issues for USB and PCIe Oct 21, 2026
@akakum-qualcomm

Copy link
Copy Markdown
Author

WA is supposed to be temporary, and it should be replaced by formal fix. If the WA is there for so long, I doubt we can still carry this WA. Please seek the approval from JIRA.

this is approved change in upstteam and merged QLI2.0
so changed tag to FROMLIST.

lore link: https://lore.kernel.org/all/20260629-monza-suspend-v1-0-b601d8a2f2f8@oss.qualcomm.com/
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/clk/qcom/gcc-qcs8300.c?h=v7.3

@akakum-qualcomm

Copy link
Copy Markdown
Author

validated No issue seen on Rb4 after suspend resume.
Please help merge change.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants