Repository navigation
Fix Rectangular Grid click options dialog - #1169
bflatastic merged 1 commit into
Conversation
|
Thanks for picking up the Rectangular Grid click dialog @FredApps, and welcome! It's a real gap. The existing shape click dialogs already handle length fields, units and validation (
A few smaller points:
Maintainers can't push to this branch, so I can't make the change myself. I'd be glad to merge a slimmer version. If you'd like to chat with the team, come say hi on Discord: https://discord.gg/artcraft |
|
Thanks @bflatastic and I'm already in the discord, feel free to message if you'd like to chat. Updated in 0fbf3bd to use the existing shared dialog path, with 100 pt defaults, saved divider counts and capitalized labels. Removed the custom module, roadmap/process docs and unrelated catalog changes. |
0fbf3bd to
c570414
Compare
|
Thanks @FredApps, merged! This version is just what I hoped for: it goes through the shared dialog path, has 100 pt defaults and saved counts, and the tests are thorough. Your branch had intermediate commits that no longer applied to main, so I folded them into one commit (still credited to you) and rebased it. The full local gate passed, and over MCP a Rectangular Grid click opens the #1192 (Polar Grid) can follow the same pattern now. I left notes there. |
What and why
The Rectangular Grid tool already emitted a dialog request on a canvas click, but the UI did not handle it. Connect that route through the existing shared Shape dialog and form. The dialog uses 100 pt dimension defaults, saved divider counts, standard unit-aware length widgets and capitalized labels. Confirmation uses the existing shape and perspective command path and saves tool options after successful creation.
The final diff spans 16 files, with 385 additions and 7 deletions: around 30 production lines, seven focused regressions and two labels in ten catalogs. The bespoke dialog module, process documents and unrelated Linux translation rows were removed.
Validation
Fresh exact-tree validation in a Linux test environment passed all seven local CI gates: 5,337 tests passed, zero failed and four ignored. Upstream was integrated at
d1a6926f63f918584ef24589becedaeb4f3d1ffb; the final tested tree is08ef5b847e9466dd600c310aa68f204a79b647c4, at head0fbf3bd7873f9f827c5bc891be508d6013742b1f.Native acceptance passed canvas click, default dimensions, mm/inch edits, divider geometry, undo/redo, Cancel/Escape/reopen, saved counts across tool switching, Enter/repeat and ordinary perspective creation.
The hosted Affinity 3 corpus workflow requires maintainer action (
action_required) and has no check runs. Hosted workflow status is separate from these local passes; no hosted CI pass is claimed.Scope and disclosure
Rectangular Grid single-click options only. Uses original synthetic fixtures. Contributor credit @FredApps. AI-assisted with OpenAI.