Repository navigation
Add a Polar Grid canvas-click dialog - #1192
Conversation
|
Thanks @FredApps. I'm holding this one until it's slimmed down the same way #1169 was. #1169 (Rectangular Grid) is landing tonight on the shared shape-dialog path. With that in place, Polar Grid needs only a few lines on the same path, not a separate
Please also leave out the progress-doc edits (they conflict with main, and we update the docs in batches). Maintainer edits are off on this branch, so I can't rebase it or push the change myself. I'd be glad to merge the slim version. |
|
@bflatastic Thanks for the input, it's all slimmed down now! Reworked in e9e59a2 to use the existing shared shape dialog. The bespoke module and large test file are gone; the PR now has two focused tests, two translated labels and no progress-doc changes. Rectangular Grid behavior is preserved. All seven local CI gates passed (5,368 tests, zero failures, four ignored), and native checks covered dimensions/units, saved counts, cancellation, repeated creation, undo/redo and perspective. Independent review cleared this exact head. The PR description has the exact validation details and limitations. |
A click with the Polar Grid tool opens the shared shape dialog (width, height, concentric and radial dividers), as the Rectangular Grid tool does, and keeps the divider counts as the tool's options.
e9e59a2 to
62bf8c8
Compare
|
Thanks @FredApps, merged! The slimmed-down version on the shared shape dialog is exactly right. What I did: squashed the branch into one commit of yours on current main (the catalog conflicts were only appended rows), and added Hungarian and Korean rows for the two labels in a commit on top, since both catalogs became complete in the meantime. Checked: |
What and why
A canvas click with the Polar Grid tool now opens the shared shape dialog, following the same path as Rectangular Grid. Width and Height default to
100 pt; Concentric Dividers and Radial Dividers use saved counts. Dimensions use the standard length widgets, and confirmation uses the existingshape.polarGridshape and perspective route. Divider counts are saved through the shared grid handling.This follows the maintainer's requested simplification: shared dialog registration, field ordering and capitalized labels, two focused behavioral tests, and catalog rows for the two new labels. The final diff is 16 files, +113/-4, with no progress-document edits.
Contributor credit @FredApps. Implementation and testing were AI-assisted with OpenAI.
How it was tested
Validated head:
e9e59a2af0dd2df4cc55fc7ee52cb34b39061df9; base:2ac3ba2b866ad9d34b2252dd8024f73e34f4b2b8; tree:360c24c6ae4c9e4b1233f3728976e716418240f2.cargo xtask cigates passed: 5,368 tests passed, zero failed, four ignored; 21 WASM packages passed.Hosted CI is separate from these local results. At the metadata update, the hosted
affinity3check was in progress; no hosted CI pass is claimed.Checklist
cargo xtask cipasses (fmt, clippy, tests, assets, brands, layers, wasm), locally on the validated head above.unwrap(),expect(),panic!,unreachable!,todo!orunimplemented!outside tests, and no new unchecked indexing on data from files, parameters or messages. Errors are returned asResultand shown to the user (why and how).ASSETS.md(no new assets).